To support flattened dwc3 dt model and drop the glue layer, introduce the
`dwc3-generic` driver. This enables direct binding of the DWC3 core driver
and offers an alternative to the existing glue driver `dwc3-of-simple`.
Signed-off-by: Ze Huang <huang.ze@linux.dev>
---
drivers/usb/dwc3/Kconfig | 11 +++
drivers/usb/dwc3/Makefile | 1 +
drivers/usb/dwc3/dwc3-generic-plat.c | 182 +++++++++++++++++++++++++++++++++++
3 files changed, 194 insertions(+)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 310d182e10b50b253d7e5a51674806e6ec442a2a..4925d15084f816d3ff92059b476ebcc799b56b51 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -189,4 +189,15 @@ config USB_DWC3_RTK
or dual-role mode.
Say 'Y' or 'M' if you have such device.
+config USB_DWC3_GENERIC_PLAT
+ tristate "DWC3 Generic Platform Driver"
+ depends on OF && COMMON_CLK
+ default USB_DWC3
+ help
+ Support USB3 functionality in simple SoC integrations.
+ Currently supports SpacemiT DWC USB3. Platforms using
+ dwc3-of-simple can easily switch to dwc3-generic by flattening
+ the dwc3 child node in the device tree.
+ Say 'Y' or 'M' here if your platform integrates DWC3 in a similar way.
+
endif
diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile
index 830e6c9e5fe073c1f662ce34b6a4a2da34c407a2..96469e48ff9d189cc8d0b65e65424eae2158bcfe 100644
--- a/drivers/usb/dwc3/Makefile
+++ b/drivers/usb/dwc3/Makefile
@@ -57,3 +57,4 @@ obj-$(CONFIG_USB_DWC3_IMX8MP) += dwc3-imx8mp.o
obj-$(CONFIG_USB_DWC3_XILINX) += dwc3-xilinx.o
obj-$(CONFIG_USB_DWC3_OCTEON) += dwc3-octeon.o
obj-$(CONFIG_USB_DWC3_RTK) += dwc3-rtk.o
+obj-$(CONFIG_USB_DWC3_GENERIC_PLAT) += dwc3-generic-plat.o
diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-generic-plat.c
new file mode 100644
index 0000000000000000000000000000000000000000..f251dda60903364d6b326a0904ec9b113e61f5c0
--- /dev/null
+++ b/drivers/usb/dwc3/dwc3-generic-plat.c
@@ -0,0 +1,182 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * dwc3-generic-plat.c - DesignWare USB3 generic platform driver
+ *
+ * Copyright (C) 2025 Ze Huang <huang.ze@linux.dev>
+ *
+ * Inspired by dwc3-qcom.c and dwc3-of-simple.c
+ */
+
+#include <linux/clk.h>
+#include <linux/platform_device.h>
+#include <linux/reset.h>
+#include "glue.h"
+
+struct dwc3_generic {
+ struct device *dev;
+ struct dwc3 dwc;
+ struct clk_bulk_data *clks;
+ int num_clocks;
+ struct reset_control *resets;
+};
+
+static void dwc3_generic_reset_control_assert(void *data)
+{
+ reset_control_assert(data);
+}
+
+static void dwc3_generic_clk_bulk_disable_unprepare(void *data)
+{
+ struct dwc3_generic *dwc3 = data;
+
+ clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks);
+}
+
+static int dwc3_generic_probe(struct platform_device *pdev)
+{
+ struct dwc3_probe_data probe_data = {};
+ struct device *dev = &pdev->dev;
+ struct dwc3_generic *dwc3;
+ struct resource *res;
+ int ret;
+
+ dwc3 = devm_kzalloc(dev, sizeof(*dwc3), GFP_KERNEL);
+ if (!dwc3)
+ return -ENOMEM;
+
+ dwc3->dev = dev;
+
+ platform_set_drvdata(pdev, dwc3);
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res) {
+ dev_err(&pdev->dev, "missing memory resource\n");
+ return -ENODEV;
+ }
+
+ dwc3->resets = devm_reset_control_array_get_optional_exclusive(dev);
+ if (IS_ERR(dwc3->resets))
+ return dev_err_probe(dev, PTR_ERR(dwc3->resets), "failed to get resets\n");
+
+ ret = reset_control_assert(dwc3->resets);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to assert resets\n");
+
+ ret = devm_add_action_or_reset(dev, dwc3_generic_reset_control_assert, dwc3->resets);
+ if (ret)
+ return ret;
+
+ usleep_range(10, 1000);
+
+ ret = reset_control_deassert(dwc3->resets);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to deassert resets\n");
+
+ ret = devm_clk_bulk_get_all(dwc3->dev, &dwc3->clks);
+ if (ret < 0)
+ return dev_err_probe(dev, ret, "failed to get clocks\n");
+
+ dwc3->num_clocks = ret;
+
+ ret = clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to enable clocks\n");
+
+ ret = devm_add_action_or_reset(dev, dwc3_generic_clk_bulk_disable_unprepare, dwc3);
+ if (ret)
+ return ret;
+
+ dwc3->dwc.dev = dev;
+ probe_data.dwc = &dwc3->dwc;
+ probe_data.res = res;
+ probe_data.ignore_clocks_and_resets = true;
+ ret = dwc3_core_probe(&probe_data);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to register DWC3 Core\n");
+
+ return 0;
+}
+
+static void dwc3_generic_remove(struct platform_device *pdev)
+{
+ struct dwc3_generic *dwc3 = platform_get_drvdata(pdev);
+
+ dwc3_core_remove(&dwc3->dwc);
+}
+
+static int dwc3_generic_suspend(struct device *dev)
+{
+ struct dwc3_generic *dwc3 = dev_get_drvdata(dev);
+ int ret;
+
+ ret = dwc3_pm_suspend(&dwc3->dwc);
+ if (ret)
+ return ret;
+
+ clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks);
+
+ return 0;
+}
+
+static int dwc3_generic_resume(struct device *dev)
+{
+ struct dwc3_generic *dwc3 = dev_get_drvdata(dev);
+ int ret;
+
+ ret = clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks);
+ if (ret)
+ return ret;
+
+ ret = dwc3_pm_resume(&dwc3->dwc);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static int dwc3_generic_runtime_suspend(struct device *dev)
+{
+ struct dwc3_generic *dwc3 = dev_get_drvdata(dev);
+
+ return dwc3_runtime_suspend(&dwc3->dwc);
+}
+
+static int dwc3_generic_runtime_resume(struct device *dev)
+{
+ struct dwc3_generic *dwc3 = dev_get_drvdata(dev);
+
+ return dwc3_runtime_resume(&dwc3->dwc);
+}
+
+static int dwc3_generic_runtime_idle(struct device *dev)
+{
+ struct dwc3_generic *dwc3 = dev_get_drvdata(dev);
+
+ return dwc3_runtime_idle(&dwc3->dwc);
+}
+
+static const struct dev_pm_ops dwc3_generic_dev_pm_ops = {
+ SET_SYSTEM_SLEEP_PM_OPS(dwc3_generic_suspend, dwc3_generic_resume)
+ SET_RUNTIME_PM_OPS(dwc3_generic_runtime_suspend, dwc3_generic_runtime_resume,
+ dwc3_generic_runtime_idle)
+};
+
+static const struct of_device_id dwc3_generic_of_match[] = {
+ { .compatible = "spacemit,k1-dwc3", },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, dwc3_generic_of_match);
+
+static struct platform_driver dwc3_generic_driver = {
+ .probe = dwc3_generic_probe,
+ .remove = dwc3_generic_remove,
+ .driver = {
+ .name = "dwc3-generic-plat",
+ .of_match_table = dwc3_generic_of_match,
+ .pm = &dwc3_generic_dev_pm_ops,
+ },
+};
+module_platform_driver(dwc3_generic_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("DesignWare USB3 generic platform driver");
--
2.50.0
On Sat, Jul 05, 2025, Ze Huang wrote: > To support flattened dwc3 dt model and drop the glue layer, introduce the > `dwc3-generic` driver. This enables direct binding of the DWC3 core driver > and offers an alternative to the existing glue driver `dwc3-of-simple`. > > Signed-off-by: Ze Huang <huang.ze@linux.dev> > --- > drivers/usb/dwc3/Kconfig | 11 +++ > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-generic-plat.c | 182 +++++++++++++++++++++++++++++++++++ > 3 files changed, 194 insertions(+) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 310d182e10b50b253d7e5a51674806e6ec442a2a..4925d15084f816d3ff92059b476ebcc799b56b51 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -189,4 +189,15 @@ config USB_DWC3_RTK > or dual-role mode. > Say 'Y' or 'M' if you have such device. > > +config USB_DWC3_GENERIC_PLAT > + tristate "DWC3 Generic Platform Driver" > + depends on OF && COMMON_CLK > + default USB_DWC3 > + help > + Support USB3 functionality in simple SoC integrations. > + Currently supports SpacemiT DWC USB3. Platforms using > + dwc3-of-simple can easily switch to dwc3-generic by flattening > + the dwc3 child node in the device tree. > + Say 'Y' or 'M' here if your platform integrates DWC3 in a similar way. > + > endif > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > index 830e6c9e5fe073c1f662ce34b6a4a2da34c407a2..96469e48ff9d189cc8d0b65e65424eae2158bcfe 100644 > --- a/drivers/usb/dwc3/Makefile > +++ b/drivers/usb/dwc3/Makefile > @@ -57,3 +57,4 @@ obj-$(CONFIG_USB_DWC3_IMX8MP) += dwc3-imx8mp.o > obj-$(CONFIG_USB_DWC3_XILINX) += dwc3-xilinx.o > obj-$(CONFIG_USB_DWC3_OCTEON) += dwc3-octeon.o > obj-$(CONFIG_USB_DWC3_RTK) += dwc3-rtk.o > +obj-$(CONFIG_USB_DWC3_GENERIC_PLAT) += dwc3-generic-plat.o > diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-generic-plat.c > new file mode 100644 > index 0000000000000000000000000000000000000000..f251dda60903364d6b326a0904ec9b113e61f5c0 > --- /dev/null > +++ b/drivers/usb/dwc3/dwc3-generic-plat.c > @@ -0,0 +1,182 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * dwc3-generic-plat.c - DesignWare USB3 generic platform driver > + * > + * Copyright (C) 2025 Ze Huang <huang.ze@linux.dev> > + * > + * Inspired by dwc3-qcom.c and dwc3-of-simple.c > + */ > + > +#include <linux/clk.h> > +#include <linux/platform_device.h> > +#include <linux/reset.h> > +#include "glue.h" > + > +struct dwc3_generic { > + struct device *dev; > + struct dwc3 dwc; > + struct clk_bulk_data *clks; > + int num_clocks; > + struct reset_control *resets; > +}; > + > +static void dwc3_generic_reset_control_assert(void *data) > +{ > + reset_control_assert(data); > +} > + > +static void dwc3_generic_clk_bulk_disable_unprepare(void *data) > +{ > + struct dwc3_generic *dwc3 = data; > + > + clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks); > +} > + > +static int dwc3_generic_probe(struct platform_device *pdev) > +{ > + struct dwc3_probe_data probe_data = {}; > + struct device *dev = &pdev->dev; > + struct dwc3_generic *dwc3; > + struct resource *res; > + int ret; > + > + dwc3 = devm_kzalloc(dev, sizeof(*dwc3), GFP_KERNEL); > + if (!dwc3) > + return -ENOMEM; > + > + dwc3->dev = dev; > + > + platform_set_drvdata(pdev, dwc3); > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) { > + dev_err(&pdev->dev, "missing memory resource\n"); > + return -ENODEV; > + } > + > + dwc3->resets = devm_reset_control_array_get_optional_exclusive(dev); > + if (IS_ERR(dwc3->resets)) > + return dev_err_probe(dev, PTR_ERR(dwc3->resets), "failed to get resets\n"); > + > + ret = reset_control_assert(dwc3->resets); > + if (ret) > + return dev_err_probe(dev, ret, "failed to assert resets\n"); > + > + ret = devm_add_action_or_reset(dev, dwc3_generic_reset_control_assert, dwc3->resets); > + if (ret) > + return ret; > + > + usleep_range(10, 1000); > + > + ret = reset_control_deassert(dwc3->resets); > + if (ret) > + return dev_err_probe(dev, ret, "failed to deassert resets\n"); > + > + ret = devm_clk_bulk_get_all(dwc3->dev, &dwc3->clks); > + if (ret < 0) > + return dev_err_probe(dev, ret, "failed to get clocks\n"); > + > + dwc3->num_clocks = ret; > + > + ret = clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks); > + if (ret) > + return dev_err_probe(dev, ret, "failed to enable clocks\n"); > + > + ret = devm_add_action_or_reset(dev, dwc3_generic_clk_bulk_disable_unprepare, dwc3); > + if (ret) > + return ret; > + > + dwc3->dwc.dev = dev; > + probe_data.dwc = &dwc3->dwc; > + probe_data.res = res; > + probe_data.ignore_clocks_and_resets = true; > + ret = dwc3_core_probe(&probe_data); > + if (ret) > + return dev_err_probe(dev, ret, "failed to register DWC3 Core\n"); > + > + return 0; > +} > + > +static void dwc3_generic_remove(struct platform_device *pdev) > +{ > + struct dwc3_generic *dwc3 = platform_get_drvdata(pdev); > + > + dwc3_core_remove(&dwc3->dwc); > +} > + > +static int dwc3_generic_suspend(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + int ret; > + > + ret = dwc3_pm_suspend(&dwc3->dwc); > + if (ret) > + return ret; > + > + clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks); > + > + return 0; > +} > + > +static int dwc3_generic_resume(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + int ret; > + > + ret = clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks); > + if (ret) > + return ret; > + > + ret = dwc3_pm_resume(&dwc3->dwc); > + if (ret) > + return ret; > + > + return 0; > +} > + > +static int dwc3_generic_runtime_suspend(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + > + return dwc3_runtime_suspend(&dwc3->dwc); > +} > + > +static int dwc3_generic_runtime_resume(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + > + return dwc3_runtime_resume(&dwc3->dwc); > +} > + > +static int dwc3_generic_runtime_idle(struct device *dev) > +{ > + struct dwc3_generic *dwc3 = dev_get_drvdata(dev); > + > + return dwc3_runtime_idle(&dwc3->dwc); > +} > + > +static const struct dev_pm_ops dwc3_generic_dev_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_generic_suspend, dwc3_generic_resume) > + SET_RUNTIME_PM_OPS(dwc3_generic_runtime_suspend, dwc3_generic_runtime_resume, > + dwc3_generic_runtime_idle) > +}; > + > +static const struct of_device_id dwc3_generic_of_match[] = { > + { .compatible = "spacemit,k1-dwc3", }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, dwc3_generic_of_match); > + > +static struct platform_driver dwc3_generic_driver = { > + .probe = dwc3_generic_probe, > + .remove = dwc3_generic_remove, > + .driver = { > + .name = "dwc3-generic-plat", > + .of_match_table = dwc3_generic_of_match, > + .pm = &dwc3_generic_dev_pm_ops, You're still not using the new pm_ptr()/pm_sleep_ptr. The kernel build bot will complain about the maybe unused functions. BR, Thinh
On Fri, Jul 11, 2025 at 11:37:32PM +0000, Thinh Nguyen wrote: > On Sat, Jul 05, 2025, Ze Huang wrote: > > To support flattened dwc3 dt model and drop the glue layer, introduce the > > `dwc3-generic` driver. This enables direct binding of the DWC3 core driver > > and offers an alternative to the existing glue driver `dwc3-of-simple`. > > > > Signed-off-by: Ze Huang <huang.ze@linux.dev> > > --- > > drivers/usb/dwc3/Kconfig | 11 +++ > > drivers/usb/dwc3/Makefile | 1 + > > drivers/usb/dwc3/dwc3-generic-plat.c | 182 +++++++++++++++++++++++++++++++++++ > > 3 files changed, 194 insertions(+) > > [...] > > +static const struct dev_pm_ops dwc3_generic_dev_pm_ops = { > > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_generic_suspend, dwc3_generic_resume) > > + SET_RUNTIME_PM_OPS(dwc3_generic_runtime_suspend, dwc3_generic_runtime_resume, > > + dwc3_generic_runtime_idle) > > +}; > > + > > +static const struct of_device_id dwc3_generic_of_match[] = { > > + { .compatible = "spacemit,k1-dwc3", }, > > + { /* sentinel */ } > > +}; > > +MODULE_DEVICE_TABLE(of, dwc3_generic_of_match); > > + > > +static struct platform_driver dwc3_generic_driver = { > > + .probe = dwc3_generic_probe, > > + .remove = dwc3_generic_remove, > > + .driver = { > > + .name = "dwc3-generic-plat", > > + .of_match_table = dwc3_generic_of_match, > > + .pm = &dwc3_generic_dev_pm_ops, > > You're still not using the new pm_ptr()/pm_sleep_ptr. The kernel build > bot will complain about the maybe unused functions. Thanks for your patience. I found they are caused by using SET_RUNTIME_PM_OPS and SET_SYSTEM_SLEEP_PM_OPS macros. I'll replace them with new RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS and wrap the dwc3_generic_dev_pm_ops with pm_ptr() > > BR, > Thinh
Hi Ze, kernel test robot noticed the following build warnings: [auto build test WARNING on d9946fe286439c2aeaa7953b8c316efe5b83d515] url: https://github.com/intel-lab-lkp/linux/commits/Ze-Huang/dt-bindings-usb-dwc3-add-support-for-SpacemiT-K1/20250705-210419 base: d9946fe286439c2aeaa7953b8c316efe5b83d515 patch link: https://lore.kernel.org/r/20250705-dwc3_generic-v5-2-9dbc53ea53d2%40linux.dev patch subject: [PATCH v5 2/2] usb: dwc3: add generic driver to support flattened config: arc-randconfig-001-20250706 (https://download.01.org/0day-ci/archive/20250706/202507060206.iiBP6CQi-lkp@intel.com/config) compiler: arc-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250706/202507060206.iiBP6CQi-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202507060206.iiBP6CQi-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/usb/dwc3/dwc3-generic-plat.c:151:12: warning: 'dwc3_generic_runtime_idle' defined but not used [-Wunused-function] static int dwc3_generic_runtime_idle(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/usb/dwc3/dwc3-generic-plat.c:144:12: warning: 'dwc3_generic_runtime_resume' defined but not used [-Wunused-function] static int dwc3_generic_runtime_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/usb/dwc3/dwc3-generic-plat.c:137:12: warning: 'dwc3_generic_runtime_suspend' defined but not used [-Wunused-function] static int dwc3_generic_runtime_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/usb/dwc3/dwc3-generic-plat.c:121:12: warning: 'dwc3_generic_resume' defined but not used [-Wunused-function] static int dwc3_generic_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~ >> drivers/usb/dwc3/dwc3-generic-plat.c:107:12: warning: 'dwc3_generic_suspend' defined but not used [-Wunused-function] static int dwc3_generic_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~ vim +/dwc3_generic_runtime_idle +151 drivers/usb/dwc3/dwc3-generic-plat.c 106 > 107 static int dwc3_generic_suspend(struct device *dev) 108 { 109 struct dwc3_generic *dwc3 = dev_get_drvdata(dev); 110 int ret; 111 112 ret = dwc3_pm_suspend(&dwc3->dwc); 113 if (ret) 114 return ret; 115 116 clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks); 117 118 return 0; 119 } 120 > 121 static int dwc3_generic_resume(struct device *dev) 122 { 123 struct dwc3_generic *dwc3 = dev_get_drvdata(dev); 124 int ret; 125 126 ret = clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks); 127 if (ret) 128 return ret; 129 130 ret = dwc3_pm_resume(&dwc3->dwc); 131 if (ret) 132 return ret; 133 134 return 0; 135 } 136 > 137 static int dwc3_generic_runtime_suspend(struct device *dev) 138 { 139 struct dwc3_generic *dwc3 = dev_get_drvdata(dev); 140 141 return dwc3_runtime_suspend(&dwc3->dwc); 142 } 143 > 144 static int dwc3_generic_runtime_resume(struct device *dev) 145 { 146 struct dwc3_generic *dwc3 = dev_get_drvdata(dev); 147 148 return dwc3_runtime_resume(&dwc3->dwc); 149 } 150 > 151 static int dwc3_generic_runtime_idle(struct device *dev) 152 { 153 struct dwc3_generic *dwc3 = dev_get_drvdata(dev); 154 155 return dwc3_runtime_idle(&dwc3->dwc); 156 } 157 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
© 2016 - 2025 Red Hat, Inc.