[PATCH RFC/RFT 5/5] ufs: ufs-qcom: Kill ufshcd_res_info

Konrad Dybcio posted 5 patches 3 months ago
[PATCH RFC/RFT 5/5] ufs: ufs-qcom: Kill ufshcd_res_info
Posted by Konrad Dybcio 3 months ago
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

This is not used by any driver and doesn't seem like it's going to be.
Remove it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 include/ufs/ufshcd.h | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 28132ff759afbd3bf8977bc481da225d95fd461c..e99df617ac31e983d452f8983ea0a5498ed64962 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -794,29 +794,6 @@ struct ufs_hba_monitor {
 	bool enabled;
 };
 
-/**
- * struct ufshcd_res_info_t - MCQ related resource regions
- *
- * @name: resource name
- * @resource: pointer to resource region
- * @base: register base address
- */
-struct ufshcd_res_info {
-	const char *name;
-	struct resource *resource;
-	void __iomem *base;
-};
-
-enum ufshcd_res {
-	RES_MCQ,
-	RES_MCQ_SQD,
-	RES_MCQ_SQIS,
-	RES_MCQ_CQD,
-	RES_MCQ_CQIS,
-	RES_MCQ_VS,
-	RES_MAX,
-};
-
 /**
  * struct ufshcd_mcq_opr_info_t - Operation and Runtime registers
  *
@@ -1127,7 +1104,6 @@ struct ufs_hba {
 	bool lsdb_sup;
 	bool mcq_enabled;
 	bool mcq_esi_enabled;
-	struct ufshcd_res_info res[RES_MAX];
 	void __iomem *mcq_base;
 	struct ufs_hw_queue *uhq;
 	struct ufs_hw_queue *dev_cmd_queue;

-- 
2.50.0
Re: [PATCH RFC/RFT 5/5] ufs: ufs-qcom: Kill ufshcd_res_info
Posted by Bart Van Assche 3 months ago
On 7/4/25 10:36 AM, Konrad Dybcio wrote:
> This is not used by any driver and doesn't seem like it's going to be.
> Remove it.

The above description seems misleading to me. I think it should say that
previous patches from this series removed all users of what is removed
by this patch rather than suggesting that what has been removed never
had any users.

Bart.