[PATCH v8 3/3] staging: media: atomisp: fix indentation in bh

LiangCheng Wang posted 3 patches 3 months ago
There is a newer version of this series
[PATCH v8 3/3] staging: media: atomisp: fix indentation in bh
Posted by LiangCheng Wang 3 months ago
This patch fixes tab/space indentation issues in bh
following kernel coding style guidelines.

No functional logic changes were made.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/all/CAHp75VcPzq9XrFD29+uZ1rbFcDxb4UbXNkv_QZ=3iyVm3dxyPg@mail.gmail.com/
Suggested-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/all/e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org/
Signed-off-by: LiangCheng Wang<zaq14760@gmail.com>
---
 .../atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c   | 18 ++++++++----------
 .../atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h   | 12 +++++-------
 .../atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h  | 14 +++++++-------
 3 files changed, 20 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
index 69c87e53f3c22fade6c4c7914d1550f68dd8f5c2..c120ecb178b2c60a3512725327779819d1888268 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
@@ -13,9 +13,8 @@
 #include "ia_css_bh.host.h"
 
 void
-ia_css_bh_hmem_decode(
-    struct ia_css_3a_rgby_output *out_ptr,
-    const struct ia_css_bh_table *hmem_buf)
+ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
+		      const struct ia_css_bh_table *hmem_buf)
 {
 	int i;
 
@@ -38,18 +37,17 @@ ia_css_bh_hmem_decode(
 }
 
 void
-ia_css_bh_encode(
-    struct sh_css_isp_bh_params *to,
-    const struct ia_css_3a_config *from,
-    unsigned int size)
+ia_css_bh_encode(struct sh_css_isp_bh_params *to,
+		 const struct ia_css_3a_config *from,
+		 unsigned int size)
 {
 	(void)size;
 	/* coefficients to calculate Y */
 	to->y_coef_r =
-	    uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
+		uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
 	to->y_coef_g =
-	    uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
+		uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
 	to->y_coef_b =
-	    uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);
+		uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);
 }
 
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
index 36b360cfe62e65037522e0037cf51fca0fabdfba..9912dfea06074c6ecdbb1afb8de771b54b45aebf 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
@@ -11,14 +11,12 @@
 #include "s3a/s3a_1.0/ia_css_s3a_types.h"
 
 void
-ia_css_bh_hmem_decode(
-    struct ia_css_3a_rgby_output *out_ptr,
-    const struct ia_css_bh_table *hmem_buf);
+ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
+		      const struct ia_css_bh_table *hmem_buf);
 
 void
-ia_css_bh_encode(
-    struct sh_css_isp_bh_params *to,
-    const struct ia_css_3a_config *from,
-    unsigned int size);
+ia_css_bh_encode(struct sh_css_isp_bh_params *to,
+		 const struct ia_css_3a_config *from,
+		 unsigned int size);
 
 #endif /* __IA_CSS_BH_HOST_H */
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h
index c717c636f666b984665f9d11c494843b55ee8c92..d62cb05d201dc8c9cabda03256f1d16103c5161a 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h
@@ -10,14 +10,14 @@
 /* Number of elements in the BH table.
   * Should be consistent with hmem.h
   */
-#define IA_CSS_HMEM_BH_TABLE_SIZE	ISP_HIST_DEPTH
-#define IA_CSS_HMEM_BH_UNIT_SIZE	(ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
+#define IA_CSS_HMEM_BH_TABLE_SIZE ISP_HIST_DEPTH
+#define IA_CSS_HMEM_BH_UNIT_SIZE (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
 
-#define BH_COLOR_R	(0)
-#define BH_COLOR_G	(1)
-#define BH_COLOR_B	(2)
-#define BH_COLOR_Y	(3)
-#define BH_COLOR_NUM	(4)
+#define BH_COLOR_R (0)
+#define BH_COLOR_G (1)
+#define BH_COLOR_B (2)
+#define BH_COLOR_Y (3)
+#define BH_COLOR_NUM (4)
 
 /* BH table */
 struct ia_css_bh_table {

-- 
2.43.0
Re: [PATCH v8 3/3] staging: media: atomisp: fix indentation in bh
Posted by Andy Shevchenko 3 months ago
On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@gmail.com> wrote:
>
> This patch fixes tab/space indentation issues in bh
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

>  void
> -ia_css_bh_hmem_decode(
> -    struct ia_css_3a_rgby_output *out_ptr,
> -    const struct ia_css_bh_table *hmem_buf)
> +ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
> +                     const struct ia_css_bh_table *hmem_buf)

Same comment as per previous patch.

...

>         to->y_coef_r =
> -           uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
>         to->y_coef_g =
> -           uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
>         to->y_coef_b =
> -           uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);

Not sure what's going on here. But I think this is just a churn.

...

> -#define IA_CSS_HMEM_BH_TABLE_SIZE      ISP_HIST_DEPTH
> -#define IA_CSS_HMEM_BH_UNIT_SIZE       (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
> +#define IA_CSS_HMEM_BH_TABLE_SIZE ISP_HIST_DEPTH
> +#define IA_CSS_HMEM_BH_UNIT_SIZE (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
>
> -#define BH_COLOR_R     (0)
> -#define BH_COLOR_G     (1)
> -#define BH_COLOR_B     (2)
> -#define BH_COLOR_Y     (3)
> -#define BH_COLOR_NUM   (4)
> +#define BH_COLOR_R (0)
> +#define BH_COLOR_G (1)
> +#define BH_COLOR_B (2)
> +#define BH_COLOR_Y (3)
> +#define BH_COLOR_NUM (4)

Doesn't look like a good change.

-- 
With Best Regards,
Andy Shevchenko