[PATCH v8 1/3] staging: media: atomisp: fix indentation in aa

LiangCheng Wang posted 3 patches 3 months ago
There is a newer version of this series
[PATCH v8 1/3] staging: media: atomisp: fix indentation in aa
Posted by LiangCheng Wang 3 months ago
This patch fixes tab/space indentation issues in aa
following kernel coding style guidelines.

No functional logic changes were made.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/all/CAHp75VcPzq9XrFD29+uZ1rbFcDxb4UbXNkv_QZ=3iyVm3dxyPg@mail.gmail.com/
Suggested-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/all/e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org/
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
 .../staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
index 2f568a7062da726397f55b1e73dadd27fcd1f2f8..edca987ee20931cc124a9af74a14698ec12419e5 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
@@ -30,7 +30,7 @@
  *     ISP2: BAA2 is used.
  */
 struct ia_css_aa_config {
-	u16 strength;	/** Strength of the filter.
+	u16 strength; /** Strength of the filter.
 					u0.13, [0,8191],
 					default/ineffective 0 */
 };

-- 
2.43.0
Re: [PATCH v8 1/3] staging: media: atomisp: fix indentation in aa
Posted by Dan Carpenter 2 months, 3 weeks ago
In the subject "aa" is weird and confusing.  Say "ia_css_aa_config"
instead.

regards,
dan carpenter
Re: [PATCH v8 1/3] staging: media: atomisp: fix indentation in aa
Posted by Andy Shevchenko 3 months ago
On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@gmail.com> wrote:
>
> This patch fixes tab/space indentation issues in aa
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

>   *     ISP2: BAA2 is used.
>   */
>  struct ia_css_aa_config {
> -       u16 strength;   /** Strength of the filter.
> +       u16 strength; /** Strength of the filter.
>                                         u0.13, [0,8191],
>                                         default/ineffective 0 */
>  };

This seems to be a kernel-doc format. Instead of fixing this, move the
description of the field to the top comment and make sure it follows
kernel-doc. In such case the change will be much more useful.

-- 
With Best Regards,
Andy Shevchenko