1. Patchew
  2. linux
  3. View series

[PATCH] pmdomain: ti: Select PM_GENERIC_DOMAINS

Guillaume La Roque posted 1 patch 3 months ago
There is a newer version of this series
drivers/pmdomain/ti/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] pmdomain: ti: Select PM_GENERIC_DOMAINS
Posted by Guillaume La Roque 3 months ago 
Select PM_GENERIC_DOMAINS instead of depending on it to ensure
it is always enabled when TI_SCI_PM_DOMAINS is selected. This
simplifies the configuration process and prevents build errors
if PM_GENERIC_DOMAINS is not explicitly enabled.

Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
---
 drivers/pmdomain/ti/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
index 67c608bf7ed0..35a4c73da17a 100644
--- a/drivers/pmdomain/ti/Kconfig
+++ b/drivers/pmdomain/ti/Kconfig
@@ -10,7 +10,7 @@ if SOC_TI
 config TI_SCI_PM_DOMAINS
 	tristate "TI SCI PM Domains Driver"
 	depends on TI_SCI_PROTOCOL
-	depends on PM_GENERIC_DOMAINS
+	select PM_GENERIC_DOMAINS
 	help
 	  Generic power domain implementation for TI device implementing
 	  the TI SCI protocol.

---
base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
change-id: 20250704-depspmdomain-2c584745dca8

Best regards,
-- 
Guillaume La Roque <glaroque@baylibre.com>
Re: [PATCH] pmdomain: ti: Select PM_GENERIC_DOMAINS
Posted by Ulf Hansson 3 months ago 
On Fri, 4 Jul 2025 at 11:08, Guillaume La Roque <glaroque@baylibre.com> wrote:
>
> Select PM_GENERIC_DOMAINS instead of depending on it to ensure
> it is always enabled when TI_SCI_PM_DOMAINS is selected. This
> simplifies the configuration process and prevents build errors
> if PM_GENERIC_DOMAINS is not explicitly enabled.
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
>  drivers/pmdomain/ti/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
> index 67c608bf7ed0..35a4c73da17a 100644
> --- a/drivers/pmdomain/ti/Kconfig
> +++ b/drivers/pmdomain/ti/Kconfig
> @@ -10,7 +10,7 @@ if SOC_TI
>  config TI_SCI_PM_DOMAINS
>         tristate "TI SCI PM Domains Driver"
>         depends on TI_SCI_PROTOCOL
> -       depends on PM_GENERIC_DOMAINS
> +       select PM_GENERIC_DOMAINS

You need an "if PM" too here. So:

select PM_GENERIC_DOMAINS if PM

>         help
>           Generic power domain implementation for TI device implementing
>           the TI SCI protocol.
>
> ---
> base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
> change-id: 20250704-depspmdomain-2c584745dca8
>
> Best regards,
> --
> Guillaume La Roque <glaroque@baylibre.com>
>

Kind regards
Uffe
Re: [PATCH] pmdomain: ti: Select PM_GENERIC_DOMAINS
Posted by Guillaume La Roque 3 months ago 
Le 09/07/2025 à 13:09, Ulf Hansson a écrit :
> On Fri, 4 Jul 2025 at 11:08, Guillaume La Roque <glaroque@baylibre.com> wrote:
>> Select PM_GENERIC_DOMAINS instead of depending on it to ensure
>> it is always enabled when TI_SCI_PM_DOMAINS is selected. This
>> simplifies the configuration process and prevents build errors
>> if PM_GENERIC_DOMAINS is not explicitly enabled.
>>
>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
>> ---
>>   drivers/pmdomain/ti/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
>> index 67c608bf7ed0..35a4c73da17a 100644
>> --- a/drivers/pmdomain/ti/Kconfig
>> +++ b/drivers/pmdomain/ti/Kconfig
>> @@ -10,7 +10,7 @@ if SOC_TI
>>   config TI_SCI_PM_DOMAINS
>>          tristate "TI SCI PM Domains Driver"
>>          depends on TI_SCI_PROTOCOL
>> -       depends on PM_GENERIC_DOMAINS
>> +       select PM_GENERIC_DOMAINS
> You need an "if PM" too here. So:
>
> select PM_GENERIC_DOMAINS if PM

ah yes sorry i forgot it.

i'll fix in v2


thanks for review

Guillaume

>
>>          help
>>            Generic power domain implementation for TI device implementing
>>            the TI SCI protocol.
>>
>> ---
>> base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
>> change-id: 20250704-depspmdomain-2c584745dca8
>>
>> Best regards,
>> --
>> Guillaume La Roque <glaroque@baylibre.com>
>>
> Kind regards
> Uffe
Re: [PATCH] pmdomain: ti: Select PM_GENERIC_DOMAINS
Posted by Matthias Schiffer 3 months ago 
On Fri, 2025-07-04 at 11:08 +0200, Guillaume La Roque wrote:
> Select PM_GENERIC_DOMAINS instead of depending on it to ensure
> it is always enabled when TI_SCI_PM_DOMAINS is selected. This
> simplifies the configuration process and prevents build errors
> if PM_GENERIC_DOMAINS is not explicitly enabled.
> 
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>

Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

The commit message is a bit off - as PM_GENERIC_DOMAINS is an implicit symbol,
it can only be enabled by 'select', enabling it explicitly is not possible.

A Fixes tag may also be a good idea.

Best,
Matthias



> ---
>  drivers/pmdomain/ti/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
> index 67c608bf7ed0..35a4c73da17a 100644
> --- a/drivers/pmdomain/ti/Kconfig
> +++ b/drivers/pmdomain/ti/Kconfig
> @@ -10,7 +10,7 @@ if SOC_TI
>  config TI_SCI_PM_DOMAINS
>  	tristate "TI SCI PM Domains Driver"
>  	depends on TI_SCI_PROTOCOL
> -	depends on PM_GENERIC_DOMAINS
> +	select PM_GENERIC_DOMAINS
>  	help
>  	  Generic power domain implementation for TI device implementing
>  	  the TI SCI protocol.
> 
> ---
> base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
> change-id: 20250704-depspmdomain-2c584745dca8
> 
> Best regards,

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.