[PATCH] rust: devres: remove unused import

Tamir Duberstein posted 1 patch 5 months, 1 week ago
rust/kernel/devres.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rust: devres: remove unused import
Posted by Tamir Duberstein 5 months, 1 week ago
As far as I can tell, this was never used.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 rust/kernel/devres.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
index d0e6c6e162c2..dff443908278 100644
--- a/rust/kernel/devres.rs
+++ b/rust/kernel/devres.rs
@@ -47,7 +47,7 @@ struct DevresInner<T> {
 /// # Examples
 ///
 /// ```no_run
-/// # use kernel::{bindings, c_str, device::{Bound, Device}, devres::Devres, io::{Io, IoRaw}};
+/// # use kernel::{bindings, device::{Bound, Device}, devres::Devres, io::{Io, IoRaw}};
 /// # use core::ops::Deref;
 ///
 /// // See also [`pci::Bar`] for a real example.

---
base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
change-id: 20250704-cstr-include-devres-151c26d36bbc

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>
Re: [PATCH] rust: devres: remove unused import
Posted by Danilo Krummrich 5 months, 1 week ago
On Fri, Jul 04, 2025 at 04:11:02PM -0400, Tamir Duberstein wrote:
> As far as I can tell, this was never used.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Applied to driver-core-testing, thanks!
Re: [PATCH] rust: devres: remove unused import
Posted by Danilo Krummrich 5 months, 1 week ago
On 7/4/25 10:11 PM, Tamir Duberstein wrote:
> As far as I can tell, this was never used.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Do you want me to take this and the other include fixups through the driver-core
tree or do you need them in rust-next as prerequisite for your CStr series?
Re: [PATCH] rust: devres: remove unused import
Posted by Tamir Duberstein 5 months, 1 week ago
On Fri, Jul 4, 2025 at 4:23 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> On 7/4/25 10:11 PM, Tamir Duberstein wrote:
> > As far as I can tell, this was never used.
> >
> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
>
> Do you want me to take this and the other include fixups through the driver-core
> tree or do you need them in rust-next as prerequisite for your CStr series?

If you can take them through the driver-core tree, that would be
great. They're needed for the CStr workstream but not for the first
(out of 5) cycle.

Thanks!