[PATCH] ALSA: hda: Remove old commented out sanity check

Thorsten Blum posted 1 patch 3 months ago
sound/pci/hda/hda_codec.c | 9 ---------
1 file changed, 9 deletions(-)
[PATCH] ALSA: hda: Remove old commented out sanity check
Posted by Thorsten Blum 3 months ago
The sanity check has been commented out for more than 12 years since
commit d5657ec9f4ad ("ALSA: hda - Disable the sanity check in
snd_hda_add_pincfg()") - remove it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 sound/pci/hda/hda_codec.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 5508381a1833..cb72e9655c8a 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -479,15 +479,6 @@ int snd_hda_add_pincfg(struct hda_codec *codec, struct snd_array *list,
 {
 	struct hda_pincfg *pin;
 
-	/* the check below may be invalid when pins are added by a fixup
-	 * dynamically (e.g. via snd_hda_codec_update_widgets()), so disabled
-	 * for now
-	 */
-	/*
-	if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
-		return -EINVAL;
-	*/
-
 	pin = look_up_pincfg(codec, list, nid);
 	if (!pin) {
 		pin = snd_array_new(list);
-- 
2.50.0
Re: [PATCH] ALSA: hda: Remove old commented out sanity check
Posted by Takashi Iwai 3 months ago
On Fri, 04 Jul 2025 00:52:36 +0200,
Thorsten Blum wrote:
> 
> The sanity check has been commented out for more than 12 years since
> commit d5657ec9f4ad ("ALSA: hda - Disable the sanity check in
> snd_hda_add_pincfg()") - remove it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Applied now.  Thanks.


Takashi