tpm: Use of_reserved_mem_region_to_resource() for "memory-region"

[PATCH] tpm: Use of_reserved_mem_region_to_resource() for "memory-region"

Posted by Rob Herring (Arm) 3 months ago

Use the newly added of_reserved_mem_region_to_resource() function to
handle "memory-region" properties.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/char/tpm/eventlog/of.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/char/tpm/eventlog/of.c b/drivers/char/tpm/eventlog/of.c
index 930fe43d5daf..92cec9722ee4 100644
--- a/drivers/char/tpm/eventlog/of.c
+++ b/drivers/char/tpm/eventlog/of.c
@@ -24,16 +24,10 @@
 
 static int tpm_read_log_memory_region(struct tpm_chip *chip)
 {
-	struct device_node *node;
 	struct resource res;
 	int rc;
 
-	node = of_parse_phandle(chip->dev.parent->of_node, "memory-region", 0);
-	if (!node)
-		return -ENODEV;
-
-	rc = of_address_to_resource(node, 0, &res);
-	of_node_put(node);
+	rc = of_reserved_mem_region_to_resource(chip->dev.parent->of_node, 0, &res);
 	if (rc)
 		return rc;
 
-- 
2.47.2

Re: [PATCH] tpm: Use of_reserved_mem_region_to_resource() for "memory-region"

Posted by Jarkko Sakkinen 3 months ago

On Thu, Jul 03, 2025 at 01:34:24PM -0500, Rob Herring (Arm) wrote:
> Use the newly added of_reserved_mem_region_to_resource() function to
> handle "memory-region" properties.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  drivers/char/tpm/eventlog/of.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/char/tpm/eventlog/of.c b/drivers/char/tpm/eventlog/of.c
> index 930fe43d5daf..92cec9722ee4 100644
> --- a/drivers/char/tpm/eventlog/of.c
> +++ b/drivers/char/tpm/eventlog/of.c
> @@ -24,16 +24,10 @@
>  
>  static int tpm_read_log_memory_region(struct tpm_chip *chip)
>  {
> -	struct device_node *node;
>  	struct resource res;
>  	int rc;
>  
> -	node = of_parse_phandle(chip->dev.parent->of_node, "memory-region", 0);
> -	if (!node)
> -		return -ENODEV;
> -
> -	rc = of_address_to_resource(node, 0, &res);
> -	of_node_put(node);
> +	rc = of_reserved_mem_region_to_resource(chip->dev.parent->of_node, 0, &res);
>  	if (rc)
>  		return rc;
>  
> -- 
> 2.47.2
> 

Thanks. It is now applied to my master.

BR, Jarkko