On Thu, Jul 3, 2025 at 11:13 PM iuncuim <iuncuim@gmail.com> wrote:
>
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> Some processors (e.g. Allwinner A523) require GPADC clocking activation for
> temperature sensors to work. So let's add support for enabling it.
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
> drivers/thermal/sun8i_thermal.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 226747906..45aaf5348 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -66,8 +66,9 @@ struct tsensor {
> };
>
> struct ths_thermal_chip {
> - bool has_mod_clk;
> - bool has_bus_clk_reset;
> + bool has_gpadc_clk;
> + bool has_mod_clk;
> + bool has_bus_clk_reset;
What's with the random whitespace change here?
> bool needs_sram;
> int sensor_num;
> int offset;
> @@ -89,7 +90,8 @@ struct ths_device {
> struct regmap_field *sram_regmap_field;
> struct reset_control *reset;
> struct clk *bus_clk;
> - struct clk *mod_clk;
> + struct clk *mod_clk;
> + struct clk *gpadc_clk;
And here?
> struct tsensor sensor[MAX_SENSOR_NUM];
> };
>
> @@ -417,6 +419,12 @@ static int sun8i_ths_resource_init(struct ths_device *tmdev)
> if (ret)
> return ret;
>
> + if (tmdev->chip->has_gpadc_clk) {
> + tmdev->gpadc_clk = devm_clk_get_enabled(&pdev->dev, "gpadc");
> + if (IS_ERR(tmdev->gpadc_clk))
> + return PTR_ERR(tmdev->gpadc_clk);
> + }
> +
This looks correct.
ChenYu
> if (tmdev->chip->needs_sram) {
> struct regmap *regmap;
>
> --
> 2.49.0
>