[v2] iio: Add support for MT6363/6373 Auxiliary ADC

[PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC

Posted by AngeloGioacchino Del Regno 3 months ago

Changes in v2:
 - Added error checks to all regmap r/w operations
 - Moved adc_vref addition to different commit
 - Various other fixes

This series adds support for the Auxiliary ADC IP found on the new
MediaTek MT6363 and MT6373 PMICs, found on board designs featuring
the MT8196 Chromebook SoC or the MT6991 Dimensity 9400 Smartphone SoC.

AngeloGioacchino Del Regno (6):
  dt-bindings: iio: adc: mt6359: Add MT6363 PMIC AuxADC
  dt-bindings: iio: adc: mt6359: Add MT6373 PMIC AuxADC
  iio: adc: mt6359: Add ready register index and mask to channel data
  iio: adc: mt6359: Move reference voltage to platform data
  iio: adc: mt6359: Add support for MediaTek MT6363 PMIC AUXADC
  iio: adc: mt6359: Add support for MediaTek MT6373 PMIC AUXADC

 .../iio/adc/mediatek,mt6359-auxadc.yaml       |   2 +
 drivers/iio/adc/mt6359-auxadc.c               | 440 +++++++++++++++---
 .../iio/adc/mediatek,mt6363-auxadc.h          |  24 +
 .../iio/adc/mediatek,mt6373-auxadc.h          |  19 +
 4 files changed, 416 insertions(+), 69 deletions(-)
 create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6363-auxadc.h
 create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6373-auxadc.h

-- 
2.49.0

Re: [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC

Posted by Andy Shevchenko 3 months ago

On Thu, Jul 03, 2025 at 04:11:40PM +0200, AngeloGioacchino Del Regno wrote:
> Changes in v2:
>  - Added error checks to all regmap r/w operations
>  - Moved adc_vref addition to different commit
>  - Various other fixes
> 
> This series adds support for the Auxiliary ADC IP found on the new
> MediaTek MT6363 and MT6373 PMICs, found on board designs featuring
> the MT8196 Chromebook SoC or the MT6991 Dimensity 9400 Smartphone SoC.

Overall LGTM, but one nit-pick in one patch.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC

Posted by Nuno Sá 3 months ago

On Thu, 2025-07-03 at 16:11 +0200, AngeloGioacchino Del Regno wrote:
> Changes in v2:
>  - Added error checks to all regmap r/w operations
>  - Moved adc_vref addition to different commit
>  - Various other fixes
> 
> This series adds support for the Auxiliary ADC IP found on the new
> MediaTek MT6363 and MT6373 PMICs, found on board designs featuring
> the MT8196 Chromebook SoC or the MT6991 Dimensity 9400 Smartphone SoC.
> 
> AngeloGioacchino Del Regno (6):
>   dt-bindings: iio: adc: mt6359: Add MT6363 PMIC AuxADC
>   dt-bindings: iio: adc: mt6359: Add MT6373 PMIC AuxADC
>   iio: adc: mt6359: Add ready register index and mask to channel data
>   iio: adc: mt6359: Move reference voltage to platform data
>   iio: adc: mt6359: Add support for MediaTek MT6363 PMIC AUXADC
>   iio: adc: mt6359: Add support for MediaTek MT6373 PMIC AUXADC
> 
>  .../iio/adc/mediatek,mt6359-auxadc.yaml       |   2 +
>  drivers/iio/adc/mt6359-auxadc.c               | 440 +++++++++++++++---
>  .../iio/adc/mediatek,mt6363-auxadc.h          |  24 +
>  .../iio/adc/mediatek,mt6373-auxadc.h          |  19 +
>  4 files changed, 416 insertions(+), 69 deletions(-)
>  create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6363-auxadc.h
>  create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6373-auxadc.h


LGTM,

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

Re: [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC

Posted by Jonathan Cameron 3 months ago

On Fri, 04 Jul 2025 13:39:56 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Thu, 2025-07-03 at 16:11 +0200, AngeloGioacchino Del Regno wrote:
> > Changes in v2:
> >  - Added error checks to all regmap r/w operations
> >  - Moved adc_vref addition to different commit
> >  - Various other fixes
> > 
> > This series adds support for the Auxiliary ADC IP found on the new
> > MediaTek MT6363 and MT6373 PMICs, found on board designs featuring
> > the MT8196 Chromebook SoC or the MT6991 Dimensity 9400 Smartphone SoC.
> > 
> > AngeloGioacchino Del Regno (6):
> >   dt-bindings: iio: adc: mt6359: Add MT6363 PMIC AuxADC
> >   dt-bindings: iio: adc: mt6359: Add MT6373 PMIC AuxADC
> >   iio: adc: mt6359: Add ready register index and mask to channel data
> >   iio: adc: mt6359: Move reference voltage to platform data
> >   iio: adc: mt6359: Add support for MediaTek MT6363 PMIC AUXADC
> >   iio: adc: mt6359: Add support for MediaTek MT6373 PMIC AUXADC
> > 
> >  .../iio/adc/mediatek,mt6359-auxadc.yaml       |   2 +
> >  drivers/iio/adc/mt6359-auxadc.c               | 440 +++++++++++++++---
> >  .../iio/adc/mediatek,mt6363-auxadc.h          |  24 +
> >  .../iio/adc/mediatek,mt6373-auxadc.h          |  19 +
> >  4 files changed, 416 insertions(+), 69 deletions(-)
> >  create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6363-auxadc.h
> >  create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6373-auxadc.h  
> 
> 
> LGTM,
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> 
Applied to the togreg branch of iio.git.  Initially pushed out as testing
for 0-day to take a first look and see if we missed anything.
Jonathan

Re: [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC

Posted by AngeloGioacchino Del Regno 3 months ago

Il 06/07/25 12:44, Jonathan Cameron ha scritto:
> On Fri, 04 Jul 2025 13:39:56 +0100
> Nuno Sá <noname.nuno@gmail.com> wrote:
> 
>> On Thu, 2025-07-03 at 16:11 +0200, AngeloGioacchino Del Regno wrote:
>>> Changes in v2:
>>>   - Added error checks to all regmap r/w operations
>>>   - Moved adc_vref addition to different commit
>>>   - Various other fixes
>>>
>>> This series adds support for the Auxiliary ADC IP found on the new
>>> MediaTek MT6363 and MT6373 PMICs, found on board designs featuring
>>> the MT8196 Chromebook SoC or the MT6991 Dimensity 9400 Smartphone SoC.
>>>
>>> AngeloGioacchino Del Regno (6):
>>>    dt-bindings: iio: adc: mt6359: Add MT6363 PMIC AuxADC
>>>    dt-bindings: iio: adc: mt6359: Add MT6373 PMIC AuxADC
>>>    iio: adc: mt6359: Add ready register index and mask to channel data
>>>    iio: adc: mt6359: Move reference voltage to platform data
>>>    iio: adc: mt6359: Add support for MediaTek MT6363 PMIC AUXADC
>>>    iio: adc: mt6359: Add support for MediaTek MT6373 PMIC AUXADC
>>>
>>>   .../iio/adc/mediatek,mt6359-auxadc.yaml       |   2 +
>>>   drivers/iio/adc/mt6359-auxadc.c               | 440 +++++++++++++++---
>>>   .../iio/adc/mediatek,mt6363-auxadc.h          |  24 +
>>>   .../iio/adc/mediatek,mt6373-auxadc.h          |  19 +
>>>   4 files changed, 416 insertions(+), 69 deletions(-)
>>>   create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6363-auxadc.h
>>>   create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6373-auxadc.h
>>
>>
>> LGTM,
>>
>> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
>>
> Applied to the togreg branch of iio.git.  Initially pushed out as testing
> for 0-day to take a first look and see if we missed anything.
> Jonathan
> 

Thanks for that!

Cheers,
Angelo