Support for Tegra264 and Tegra254 in CBB driver

[PATCH v2 0/8] Support for Tegra264 and Tegra254 in CBB driver

Posted by Sumit Gupta 3 months ago

This patch series adds support for Tegra264 and Tegra254 SoCs in the
Tegra CBB driver. It also includes a fix and some improvements to
make the driver more generic to add new SoC support.

The patches can be applied in sequence. Patch info:
- Patch 1: Fix.
- Patch 2: Change lingo from 'Master/Slave' to 'Initiator/Target'.
- Patch 3 & 4: Improvements.
- Patch 5: New feature for HW lookup.
- Patch 6 & 7: Tegra264 SoC support.
- Patch 8: Tegra254 SoC support.

---
v1[1] -> v2:
- patch 8: change name from GB10 to Tegra254.
- patch 6: added ACK from Krzysztof

Sumit Gupta (8):
  soc: tegra: cbb: clear err force register with err status
  soc: tegra: cbb: change master-slave to initiator-target
  soc: tegra: cbb: make error interrupt enable and status per SoC
  soc: tegra: cbb: improve handling for per SoC fabric data
  soc: tegra: cbb: support hw lookup to get timed out target address
  dt-bindings: arm: tegra: Add NVIDIA Tegra264 CBB 2.0 binding
  soc: tegra: cbb: add support for cbb fabrics in Tegra264
  soc: tegra: cbb: add support for cbb fabrics in T254

 .../arm/tegra/nvidia,tegra234-cbb.yaml        |   4 +
 drivers/soc/tegra/cbb/tegra194-cbb.c          |  34 +-
 drivers/soc/tegra/cbb/tegra234-cbb.c          | 758 ++++++++++++++----
 3 files changed, 606 insertions(+), 190 deletions(-)

[1] https://lore.kernel.org/lkml/20250530133336.1419971-1-sumitg@nvidia.com/

-- 
2.34.1

Re: [PATCH v2 0/8] Support for Tegra264 and Tegra254 in CBB driver

Posted by Thierry Reding 3 months ago

On Thu, Jul 03, 2025 at 04:08:21PM +0530, Sumit Gupta wrote:
> This patch series adds support for Tegra264 and Tegra254 SoCs in the
> Tegra CBB driver. It also includes a fix and some improvements to
> make the driver more generic to add new SoC support.
> 
> The patches can be applied in sequence. Patch info:
> - Patch 1: Fix.
> - Patch 2: Change lingo from 'Master/Slave' to 'Initiator/Target'.
> - Patch 3 & 4: Improvements.
> - Patch 5: New feature for HW lookup.
> - Patch 6 & 7: Tegra264 SoC support.
> - Patch 8: Tegra254 SoC support.
> 
> ---
> v1[1] -> v2:
> - patch 8: change name from GB10 to Tegra254.
> - patch 6: added ACK from Krzysztof
> 
> Sumit Gupta (8):
>   soc: tegra: cbb: clear err force register with err status
>   soc: tegra: cbb: change master-slave to initiator-target
>   soc: tegra: cbb: make error interrupt enable and status per SoC
>   soc: tegra: cbb: improve handling for per SoC fabric data
>   soc: tegra: cbb: support hw lookup to get timed out target address
>   dt-bindings: arm: tegra: Add NVIDIA Tegra264 CBB 2.0 binding
>   soc: tegra: cbb: add support for cbb fabrics in Tegra264
>   soc: tegra: cbb: add support for cbb fabrics in T254
> 
>  .../arm/tegra/nvidia,tegra234-cbb.yaml        |   4 +
>  drivers/soc/tegra/cbb/tegra194-cbb.c          |  34 +-
>  drivers/soc/tegra/cbb/tegra234-cbb.c          | 758 ++++++++++++++----
>  3 files changed, 606 insertions(+), 190 deletions(-)

Applied with a few fixups to the subject lines and commit messages.

Thanks,
Thierry

Re: [PATCH v2 0/8] Support for Tegra264 and Tegra254 in CBB driver

Posted by Rob Herring 2 months, 2 weeks ago

On Wed, Jul 9, 2025 at 7:31 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Thu, Jul 03, 2025 at 04:08:21PM +0530, Sumit Gupta wrote:
> > This patch series adds support for Tegra264 and Tegra254 SoCs in the
> > Tegra CBB driver. It also includes a fix and some improvements to
> > make the driver more generic to add new SoC support.
> >
> > The patches can be applied in sequence. Patch info:
> > - Patch 1: Fix.
> > - Patch 2: Change lingo from 'Master/Slave' to 'Initiator/Target'.
> > - Patch 3 & 4: Improvements.
> > - Patch 5: New feature for HW lookup.
> > - Patch 6 & 7: Tegra264 SoC support.
> > - Patch 8: Tegra254 SoC support.
> >
> > ---
> > v1[1] -> v2:
> > - patch 8: change name from GB10 to Tegra254.
> > - patch 6: added ACK from Krzysztof
> >
> > Sumit Gupta (8):
> >   soc: tegra: cbb: clear err force register with err status
> >   soc: tegra: cbb: change master-slave to initiator-target
> >   soc: tegra: cbb: make error interrupt enable and status per SoC
> >   soc: tegra: cbb: improve handling for per SoC fabric data
> >   soc: tegra: cbb: support hw lookup to get timed out target address
> >   dt-bindings: arm: tegra: Add NVIDIA Tegra264 CBB 2.0 binding
> >   soc: tegra: cbb: add support for cbb fabrics in Tegra264
> >   soc: tegra: cbb: add support for cbb fabrics in T254
> >
> >  .../arm/tegra/nvidia,tegra234-cbb.yaml        |   4 +
> >  drivers/soc/tegra/cbb/tegra194-cbb.c          |  34 +-
> >  drivers/soc/tegra/cbb/tegra234-cbb.c          | 758 ++++++++++++++----
> >  3 files changed, 606 insertions(+), 190 deletions(-)
>
> Applied with a few fixups to the subject lines and commit messages.

It looks like you missed the binding patch. These compatibles are not
documented in linux-next:

nvidia,tegra264-sys-cbb-fabric
nvidia,tegra264-top0-cbb-fabric
nvidia,tegra264-uphy0-cbb-fabric
nvidia,tegra264-vision-cbb-fabric

Rob