[v1] ALSA: hda/tas2781: Add bus name in device name check

[PATCH v1] ALSA: hda/tas2781: Add bus name in device name check

Posted by Baojun Xu 3 months, 1 week ago

Device name start from bus name, as we use strstarts()
to do compare, need add it for TXNW2781 device.

Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
 sound/pci/hda/tas2781_hda_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index b9cdbca95..530c2266a 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
 		hda_priv->save_calibration = tas2781_save_calibration;
 		tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
 	} else if (strstarts(dev_name(&clt->dev),
-			     "TXNW2781:00-tas2781-hda.0")) {
+			     "i2c-TXNW2781:00-tas2781-hda.0")) {
 		device_name = "TXNW2781";
 		hda_priv->save_calibration = tas2781_save_calibration;
 		tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
-- 
2.43.0

Re: [PATCH v1] ALSA: hda/tas2781: Add bus name in device name check

Posted by Takashi Iwai 3 months ago

On Thu, 03 Jul 2025 02:06:08 +0200,
Baojun Xu wrote:
> 
> Device name start from bus name, as we use strstarts()
> to do compare, need add it for TXNW2781 device.
> 
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>

Could you give the proper Fixes tag if it's a fix of the previous
changes?


thanks,

Takashi


> ---
>  sound/pci/hda/tas2781_hda_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
> index b9cdbca95..530c2266a 100644
> --- a/sound/pci/hda/tas2781_hda_i2c.c
> +++ b/sound/pci/hda/tas2781_hda_i2c.c
> @@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
>  		hda_priv->save_calibration = tas2781_save_calibration;
>  		tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
>  	} else if (strstarts(dev_name(&clt->dev),
> -			     "TXNW2781:00-tas2781-hda.0")) {
> +			     "i2c-TXNW2781:00-tas2781-hda.0")) {
>  		device_name = "TXNW2781";
>  		hda_priv->save_calibration = tas2781_save_calibration;
>  		tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR;
> -- 
> 2.43.0
>