[PATCH net-next 2/3] net: phy: qcom: qca808x: Fix WoL issue by utilizing at8031_set_wol()

Luo Jie posted 3 patches 3 months ago
There is a newer version of this series
[PATCH net-next 2/3] net: phy: qcom: qca808x: Fix WoL issue by utilizing at8031_set_wol()
Posted by Luo Jie 3 months ago
The previous commit unintentionally removed the code responsible for
enabling WoL via MMD3 register 0x8012 BIT5. As a result, Wake-on-LAN
(WoL) support for the QCA808X PHY is no longer functional.

The WoL (Wake-on-LAN) feature for the QCA808X PHY is enabled via MMD3
register 0x8012, BIT5. This implementation is aligned with the approach
used in at8031_set_wol().

Fixes: e58f30246c35 ("net: phy: at803x: fix the wol setting functions")
Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
 drivers/net/phy/qcom/qca808x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/qcom/qca808x.c b/drivers/net/phy/qcom/qca808x.c
index 71498c518f0f..6de16c0eaa08 100644
--- a/drivers/net/phy/qcom/qca808x.c
+++ b/drivers/net/phy/qcom/qca808x.c
@@ -633,7 +633,7 @@ static struct phy_driver qca808x_driver[] = {
 	.handle_interrupt	= at803x_handle_interrupt,
 	.get_tunable		= at803x_get_tunable,
 	.set_tunable		= at803x_set_tunable,
-	.set_wol		= at803x_set_wol,
+	.set_wol		= at8031_set_wol,
 	.get_wol		= at803x_get_wol,
 	.get_features		= qca808x_get_features,
 	.config_aneg		= qca808x_config_aneg,

-- 
2.34.1
Re: [PATCH net-next 2/3] net: phy: qcom: qca808x: Fix WoL issue by utilizing at8031_set_wol()
Posted by Maxime Chevallier 3 months ago
Hi,

On Thu, 3 Jul 2025 20:14:29 +0800
Luo Jie <quic_luoj@quicinc.com> wrote:

> The previous commit unintentionally removed the code responsible for
> enabling WoL via MMD3 register 0x8012 BIT5. As a result, Wake-on-LAN
> (WoL) support for the QCA808X PHY is no longer functional.
> 
> The WoL (Wake-on-LAN) feature for the QCA808X PHY is enabled via MMD3
> register 0x8012, BIT5. This implementation is aligned with the approach
> used in at8031_set_wol().
> 
> Fixes: e58f30246c35 ("net: phy: at803x: fix the wol setting functions")
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>

If this is a fix, you should target the -net tree instead -net-next :)

Maxime
Re: [PATCH net-next 2/3] net: phy: qcom: qca808x: Fix WoL issue by utilizing at8031_set_wol()
Posted by Luo Jie 3 months ago

On 7/3/2025 10:23 PM, Maxime Chevallier wrote:
> Hi,
> 
> On Thu, 3 Jul 2025 20:14:29 +0800
> Luo Jie <quic_luoj@quicinc.com> wrote:
> 
>> The previous commit unintentionally removed the code responsible for
>> enabling WoL via MMD3 register 0x8012 BIT5. As a result, Wake-on-LAN
>> (WoL) support for the QCA808X PHY is no longer functional.
>>
>> The WoL (Wake-on-LAN) feature for the QCA808X PHY is enabled via MMD3
>> register 0x8012, BIT5. This implementation is aligned with the approach
>> used in at8031_set_wol().
>>
>> Fixes: e58f30246c35 ("net: phy: at803x: fix the wol setting functions")
>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> 
> If this is a fix, you should target the -net tree instead -net-next :)
> 
> Maxime

OK. I will resend the patch series targeting the -net tree instead.
Thank you for the feedback.