The Ethernet MACs on SpacemiT K1 appears to be a custom design. SpacemiT
refers to them as "EMAC", so let's just call them "spacemit,k1-emac".
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/net/spacemit,k1-emac.yaml | 81 ++++++++++++++++++++++
1 file changed, 81 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/spacemit,k1-emac.yaml b/Documentation/devicetree/bindings/net/spacemit,k1-emac.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..500a3e1daa230ea3a1fad30d8ea56a7822fccb3d
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/spacemit,k1-emac.yaml
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/spacemit,k1-emac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SpacemiT K1 Ethernet MAC
+
+allOf:
+ - $ref: ethernet-controller.yaml#
+
+maintainers:
+ - Vivian Wang <wangruikang@iscas.ac.cn>
+
+properties:
+ compatible:
+ const: spacemit,k1-emac
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ mdio-bus:
+ $ref: mdio.yaml#
+ unevaluatedProperties: false
+
+ resets:
+ maxItems: 1
+
+ spacemit,apmu:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ - items:
+ - description: phandle to syscon that controls this MAC
+ - description: offset of control registers
+ description:
+ A phandle to syscon with byte offset to control registers for this MAC
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - interrupts
+ - resets
+ - spacemit,apmu
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/spacemit,k1-syscon.h>
+
+ ethernet@cac80000 {
+ compatible = "spacemit,k1-emac";
+ reg = <0xcac80000 0x00000420>;
+ clocks = <&syscon_apmu CLK_EMAC0_BUS>;
+ interrupts = <131>;
+ mac-address = [ 00 00 00 00 00 00 ];
+ phy-handle = <&rgmii0>;
+ phy-mode = "rgmii-id";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac0_cfg>;
+ resets = <&syscon_apmu RESET_EMAC0>;
+ rx-internal-delay-ps = <0>;
+ tx-internal-delay-ps = <0>;
+ spacemit,apmu = <&syscon_apmu 0x3e4>;
+
+ mdio-bus {
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+
+ rgmii0: phy@1 {
+ reg = <0x1>;
+ };
+ };
+ };
--
2.49.0On Thu, 03 Jul 2025 17:42:02 +0800, Vivian Wang wrote: > The Ethernet MACs on SpacemiT K1 appears to be a custom design. SpacemiT > refers to them as "EMAC", so let's just call them "spacemit,k1-emac". > > Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/net/spacemit,k1-emac.yaml | 81 ++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dts:36.36-37 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2 make: *** [Makefile:248: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250703-net-k1-emac-v4-1-686d09c4cfa8@iscas.ac.cn The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 7/3/25 18:49, Rob Herring (Arm) wrote: > On Thu, 03 Jul 2025 17:42:02 +0800, Vivian Wang wrote: >> The Ethernet MACs on SpacemiT K1 appears to be a custom design. SpacemiT >> refers to them as "EMAC", so let's just call them "spacemit,k1-emac". >> >> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >> --- >> .../devicetree/bindings/net/spacemit,k1-emac.yaml | 81 ++++++++++++++++++++++ >> 1 file changed, 81 insertions(+) >> > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dts:36.36-37 syntax error > FATAL ERROR: Unable to parse input tree My bad. The example still depends on the reset bindings for the constant RESET_EMAC0. I just tried with reset v12 [1] and that fixes it. [1]: https://lore.kernel.org/spacemit/20250702113709.291748-2-elder@riscstar.com/ Vivian "dramforever" Wang > make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2 > make: *** [Makefile:248: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250703-net-k1-emac-v4-1-686d09c4cfa8@iscas.ac.cn > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema.
On 7/3/25 20:31, Vivian Wang wrote: > > On 7/3/25 18:49, Rob Herring (Arm) wrote: >> On Thu, 03 Jul 2025 17:42:02 +0800, Vivian Wang wrote: >>> The Ethernet MACs on SpacemiT K1 appears to be a custom design. >>> SpacemiT >>> refers to them as "EMAC", so let's just call them "spacemit,k1-emac". >>> >>> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn> >>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >>> --- >>> .../devicetree/bindings/net/spacemit,k1-emac.yaml | 81 >>> ++++++++++++++++++++++ >>> 1 file changed, 81 insertions(+) >>> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Error: >> Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dts:36.36-37 >> syntax error >> FATAL ERROR: Unable to parse input tree > > My bad. The example still depends on the reset bindings for the > constant RESET_EMAC0. I just tried with reset v12 [1] and that fixes it. > > [1]: > https://lore.kernel.org/spacemit/20250702113709.291748-2-elder@riscstar.com/ > > Vivian "dramforever" Wang > Just for the record for anyone watching this thread, I'm most likely going to be holding off sending the next version of this until reset v12 (probably?) gets at least taken up by a maintainer. It's a bit of a weird situation over there since they're sending the reset controller stuff through the clk tree, but then it's also a mega-syscon situation for the K1 and that's how they decided they want it, so it is what it is. (The DMA bus dependency that was in v3 is all DTS changes with no bindings and no driver, so that could be easily handled entirely in the SpacemiT SoC tree, which is nice.) Vivian >> [...]
© 2016 - 2025 Red Hat, Inc.