On 7/2/2025 12:12 PM, Lee Trager wrote:
> Firmware running on fbnic generates device logs. These logs contain useful
> information about the device which may or may not be related to the host.
> Logs are stored in a ring buffer and accessible through DebugFS.
>
> Lee Trager (6):
> eth: fbnic: Fix incorrect minimum firmware version
> eth: fbnic: Use FIELD_PREP to generate minimum firmware version
> eth: fbnic: Create ring buffer for firmware logs
> eth: fbnic: Add mailbox support for firmware logs
> eth: fbnic: Enable firmware logging
> eth: fbnic: Create fw_log file in DebugFS
>
Everything looked straight forward to me.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> drivers/net/ethernet/meta/fbnic/Makefile | 1 +
> drivers/net/ethernet/meta/fbnic/fbnic.h | 3 +
> drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 27 ++-
> .../net/ethernet/meta/fbnic/fbnic_debugfs.c | 29 +++
> drivers/net/ethernet/meta/fbnic/fbnic_fw.c | 179 +++++++++++++++++-
> drivers/net/ethernet/meta/fbnic/fbnic_fw.h | 36 ++++
> .../net/ethernet/meta/fbnic/fbnic_fw_log.c | 123 ++++++++++++
> .../net/ethernet/meta/fbnic/fbnic_fw_log.h | 45 +++++
> drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 21 ++
> 9 files changed, 451 insertions(+), 13 deletions(-)
> create mode 100644 drivers/net/ethernet/meta/fbnic/fbnic_fw_log.c
> create mode 100644 drivers/net/ethernet/meta/fbnic/fbnic_fw_log.h
>
> --
> 2.47.1