mtd: rawnand: atmel: Fix dma_mapping_error() address

[PATCH v2] mtd: rawnand: atmel: Fix dma_mapping_error() address

Posted by Thomas Fourier 7 months, 1 week ago

It seems like what was intended is to test if the dma_map of the
previous line failed but the wrong dma address was passed.

Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
v1 -> v2:
- Add stable@vger.kernel.org
- Fix subject prefix

 drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index dedcca87defc..84ab4a83cbd6 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -373,7 +373,7 @@ static int atmel_nand_dma_transfer(struct atmel_nand_controller *nc,
 	dma_cookie_t cookie;
 
 	buf_dma = dma_map_single(nc->dev, buf, len, dir);
-	if (dma_mapping_error(nc->dev, dev_dma)) {
+	if (dma_mapping_error(nc->dev, buf_dma)) {
 		dev_err(nc->dev,
 			"Failed to prepare a buffer for DMA access\n");
 		goto err;
-- 
2.43.0

Re: [PATCH v2] mtd: rawnand: atmel: Fix dma_mapping_error() address

Posted by Miquel Raynal 6 months, 2 weeks ago

On Wed, 02 Jul 2025 08:45:11 +0200, Thomas Fourier wrote:
> It seems like what was intended is to test if the dma_map of the
> previous line failed but the wrong dma address was passed.
> 
> 

Applied to nand/next, thanks!

[1/1] mtd: rawnand: atmel: Fix dma_mapping_error() address
      commit: 9e2e2576bc49c3bc352d402963f7ba8774c3d95f

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

Re: [PATCH v2] mtd: rawnand: atmel: Fix dma_mapping_error() address

Posted by Balamanikandan.Gunasundar@microchip.com 7 months, 1 week ago

Reviewed-by: Balamanikandan Gunasundar 
<balamanikandan.gunasundar@microchip.com>

On 02/07/25 12:15 pm, Thomas Fourier wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> It seems like what was intended is to test if the dma_map of the
> previous line failed but the wrong dma address was passed.
> 
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
> ---
> v1 -> v2:
> - Add stable@vger.kernel.org
> - Fix subject prefix
> 
>   drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index dedcca87defc..84ab4a83cbd6 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -373,7 +373,7 @@ static int atmel_nand_dma_transfer(struct atmel_nand_controller *nc,
>          dma_cookie_t cookie;
> 
>          buf_dma = dma_map_single(nc->dev, buf, len, dir);
> -       if (dma_mapping_error(nc->dev, dev_dma)) {
> +       if (dma_mapping_error(nc->dev, buf_dma)) {
>                  dev_err(nc->dev,
>                          "Failed to prepare a buffer for DMA access\n");
>                  goto err;
> --
> 2.43.0
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/