1. Patchew
  2. linux
  3. [PATCH 0/5] ARM: dts: aspeed: Add Meta Darwin dts
  4. View patch

[PATCH 1/5] ARM: dts: aspeed: Expand data0 partition in facebook-bmc-flash-layout-128.dtsi

rentao.bupt@gmail.com posted 5 patches 5 months, 2 weeks ago
There is a newer version of this series
[PATCH 1/5] ARM: dts: aspeed: Expand data0 partition in facebook-bmc-flash-layout-128.dtsi
Posted by rentao.bupt@gmail.com 5 months, 2 weeks ago 
From: Tao Ren <rentao.bupt@gmail.com>

Expand data0 partition to 64MB in facebook-bmc-flash-layout-128.dtsi for
larger persistent storage.

Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
---
 .../boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
index 7f3652dea550..efd92232cda2 100644
--- a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
+++ b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
@@ -32,19 +32,19 @@ image-meta@f0000 {
 	};
 
 	/*
-	 * FIT image: 119 MB.
+	 * FIT image: 63 MB.
 	 */
 	fit@100000 {
-		reg = <0x100000 0x7700000>;
+		reg = <0x100000 0x3f00000>;
 		label = "fit";
 	};
 
 	/*
-	 * "data0" partition (8MB) is used by Facebook BMC platforms as
+	 * "data0" partition (64MB) is used by Facebook BMC platforms as
 	 * persistent data store.
 	 */
-	data0@7800000 {
-		reg = <0x7800000 0x800000>;
+	data0@4000000 {
+		reg = <0x4000000 0x4000000>;
 		label = "data0";
 	};
 
-- 
2.47.1
Re: [PATCH 1/5] ARM: dts: aspeed: Expand data0 partition in facebook-bmc-flash-layout-128.dtsi
Posted by Andrew Jeffery 5 months, 2 weeks ago 
On Tue, 2025-07-01 at 22:04 -0700, rentao.bupt@gmail.com wrote:
> From: Tao Ren <rentao.bupt@gmail.com>
> 
> Expand data0 partition to 64MB in facebook-bmc-flash-layout-128.dtsi for
> larger persistent storage.
> 
> Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
> ---
>  .../boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> index 7f3652dea550..efd92232cda2 100644
> --- a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> +++ b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> @@ -32,19 +32,19 @@ image-meta@f0000 {
>         };
>  
>         /*
> -        * FIT image: 119 MB.
> +        * FIT image: 63 MB.
>          */
>         fit@100000 {
> -               reg = <0x100000 0x7700000>;
> +               reg = <0x100000 0x3f00000>;
>                 label = "fit";
>         };
>  
>         /*
> -        * "data0" partition (8MB) is used by Facebook BMC platforms as
> +        * "data0" partition (64MB) is used by Facebook BMC platforms as
>          * persistent data store.
>          */
> -       data0@7800000 {
> -               reg = <0x7800000 0x800000>;
> +       data0@4000000 {
> +               reg = <0x4000000 0x4000000>;
>                 label = "data0";
>         };
>  

Two existing systems use this dtsi:

   > git grep facebook-bmc-flash-layout-128.dtsi
   arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge400.dts:#include "facebook-bmc-flash-layout-128.dtsi"
   arch/arm/boot/dts/aspeed/ast2600-facebook-netbmc-common.dtsi:#include "facebook-bmc-flash-layout-128.dtsi"

This change requires a full reflash of those devices, which is pretty
disruptive.

It seems more appropriate to me to create a separate dtsi for the new
flash layout to use in new systems.

Andrew
Re: [PATCH 1/5] ARM: dts: aspeed: Expand data0 partition in facebook-bmc-flash-layout-128.dtsi
Posted by Tao Ren 5 months, 2 weeks ago 
On Fri, Jul 04, 2025 at 09:36:29AM +0930, Andrew Jeffery wrote:
> On Tue, 2025-07-01 at 22:04 -0700, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> > 
> > Expand data0 partition to 64MB in facebook-bmc-flash-layout-128.dtsi for
> > larger persistent storage.
> > 
> > Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
> > ---
> >  .../boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> > index 7f3652dea550..efd92232cda2 100644
> > --- a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> > +++ b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> > @@ -32,19 +32,19 @@ image-meta@f0000 {
> >         };
> >  
> >         /*
> > -        * FIT image: 119 MB.
> > +        * FIT image: 63 MB.
> >          */
> >         fit@100000 {
> > -               reg = <0x100000 0x7700000>;
> > +               reg = <0x100000 0x3f00000>;
> >                 label = "fit";
> >         };
> >  
> >         /*
> > -        * "data0" partition (8MB) is used by Facebook BMC platforms as
> > +        * "data0" partition (64MB) is used by Facebook BMC platforms as
> >          * persistent data store.
> >          */
> > -       data0@7800000 {
> > -               reg = <0x7800000 0x800000>;
> > +       data0@4000000 {
> > +               reg = <0x4000000 0x4000000>;
> >                 label = "data0";
> >         };
> >  
> 
> Two existing systems use this dtsi:
> 
>    > git grep facebook-bmc-flash-layout-128.dtsi
>    arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge400.dts:#include "facebook-bmc-flash-layout-128.dtsi"
>    arch/arm/boot/dts/aspeed/ast2600-facebook-netbmc-common.dtsi:#include "facebook-bmc-flash-layout-128.dtsi"
> 
> This change requires a full reflash of those devices, which is pretty
> disruptive.
> 
> It seems more appropriate to me to create a separate dtsi for the new
> flash layout to use in new systems.
> 
> Andrew

Hi Andrew,

I agree it's better to create a new layout, and I will take care of it
in v2. The migration is already done for all the network BMC platforms
except elbert/darwin, and having separate layouts will make my life
easier :)

Any suggestions about the file name of the new layout?


Thanks,

Tao

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.