[v3] net: Remove unused function parameters in skbuff.c

[PATCH net-next v3 0/6] net: Remove unused function parameters in skbuff.c

Michal Luczaj posted 6 patches 3 months, 1 week ago

Diff against v1 v2
Download series mbox

.../chelsio/inline_crypto/chtls/chtls_io.c         |  3 +-
include/linux/skbuff.h                             |  2 +-
net/core/skbuff.c                                  | 34 +++++++++-------------
net/ipv4/ip_output.c                               |  3 +-
net/ipv4/tcp.c                                     |  3 +-
net/ipv6/ip6_output.c                              |  3 +-
net/kcm/kcmsock.c                                  |  3 +-
net/smc/smc_rx.c                                   |  1 -
net/unix/af_unix.c                                 |  3 +-
9 files changed, 20 insertions(+), 35 deletions(-)

Expand all Fold all

[PATCH net-next v3 0/6] net: Remove unused function parameters in skbuff.c

Posted by Michal Luczaj 3 months, 1 week ago

Couple of cleanup patches to get rid of unused function parameters around
skbuff.c, plus little things spotted along the way.

Offshoot of my question in [1], but way more contained. Found by adding
"-Wunused-parameter -Wno-error" to KBUILD_CFLAGS and grepping for specific
skbuff.c warnings.

[1]: https://lore.kernel.org/netdev/972af569-0c90-4585-9e1f-f2266dab6ec6@rbox.co/

Signed-off-by: Michal Luczaj <mhal@rbox.co>
---
Changes in v3:
- Keep skb_splice_bits() @flags [Jakub, Paolo]
- Link to v2: https://lore.kernel.org/r/20250626-splice-drop-unused-v2-0-3268fac1af89@rbox.co

Changes in v2:
- Fix typos in commit messages
- Remove one more unused parameter in skbuff.c (patch 9)
- Collect R-b, add a one-line cleanup of smc_rx_splice() (patch 7) [Simon]
- Link to v1: https://lore.kernel.org/r/20250624-splice-drop-unused-v1-0-cf641a676d04@rbox.co

---
Michal Luczaj (6):
      net: splice: Drop unused @pipe
      net: splice: Drop unused @gfp
      net: splice: Drop nr_pages_max initialization
      net/smc: Drop nr_pages_max initialization
      net: skbuff: Drop unused @skb
      net: skbuff: Drop unused @skb

 .../chelsio/inline_crypto/chtls/chtls_io.c         |  3 +-
 include/linux/skbuff.h                             |  2 +-
 net/core/skbuff.c                                  | 34 +++++++++-------------
 net/ipv4/ip_output.c                               |  3 +-
 net/ipv4/tcp.c                                     |  3 +-
 net/ipv6/ip6_output.c                              |  3 +-
 net/kcm/kcmsock.c                                  |  3 +-
 net/smc/smc_rx.c                                   |  1 -
 net/unix/af_unix.c                                 |  3 +-
 9 files changed, 20 insertions(+), 35 deletions(-)
---
base-commit: e96ee511c906c59b7c4e6efd9d9b33917730e000
change-id: 20250618-splice-drop-unused-0e4ea8a12681

Best regards,
-- 
Michal Luczaj <mhal@rbox.co>