1. Patchew
  2. linux
  3. [PATCH v3 0/2] Add video clock controller DT support for sc8180x
  4. View patch

[PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

Satya Priya Kakitapalli posted 2 patches 3 months, 1 week ago
There is a newer version of this series
[PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Posted by Satya Priya Kakitapalli 3 months, 1 week ago 
The sc8180x video clock controller block is identical to that
of sm8150. Add a new compatible string for sc8180x videocc and
use sm8150 as fallback.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
index 5f7738d6835c4ba999402e163fc85a07e3a47a5a..b490caaf843243a7a96395fdd2b99972a45679f9 100644
--- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
@@ -23,13 +23,17 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - qcom,sc7180-videocc
-      - qcom,sc7280-videocc
-      - qcom,sdm845-videocc
-      - qcom,sm6350-videocc
-      - qcom,sm8150-videocc
-      - qcom,sm8250-videocc
+    oneOf:
+      - enum:
+          - qcom,sc7180-videocc
+          - qcom,sc7280-videocc
+          - qcom,sdm845-videocc
+          - qcom,sm6350-videocc
+          - qcom,sm8150-videocc
+          - qcom,sm8250-videocc
+      - items:
+          - const: qcom,sc8180x-videocc
+          - const: qcom,sm8150-videocc
 
   clocks:
     minItems: 1
@@ -111,6 +115,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,sc8180x-videocc
             - qcom,sm8150-videocc
     then:
       properties:

-- 
2.25.1
Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Posted by Dmitry Baryshkov 3 months, 1 week ago 
On Wed, Jul 02, 2025 at 08:43:13PM +0530, Satya Priya Kakitapalli wrote:
> The sc8180x video clock controller block is identical to that
> of sm8150. Add a new compatible string for sc8180x videocc and
> use sm8150 as fallback.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> index 5f7738d6835c4ba999402e163fc85a07e3a47a5a..b490caaf843243a7a96395fdd2b99972a45679f9 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> @@ -23,13 +23,17 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,sc7180-videocc
> -      - qcom,sc7280-videocc
> -      - qcom,sdm845-videocc
> -      - qcom,sm6350-videocc
> -      - qcom,sm8150-videocc
> -      - qcom,sm8250-videocc
> +    oneOf:
> +      - enum:
> +          - qcom,sc7180-videocc
> +          - qcom,sc7280-videocc
> +          - qcom,sdm845-videocc
> +          - qcom,sm6350-videocc
> +          - qcom,sm8150-videocc
> +          - qcom,sm8250-videocc
> +      - items:
> +          - const: qcom,sc8180x-videocc
> +          - const: qcom,sm8150-videocc
>  
>    clocks:
>      minItems: 1
> @@ -111,6 +115,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,sc8180x-videocc

Is there a need for this? Isn't it already covered by the SM8150 entry?

>              - qcom,sm8150-videocc
>      then:
>        properties:
> 
> -- 
> 2.25.1
> 

-- 
With best wishes
Dmitry
Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Posted by Krzysztof Kozlowski 3 months ago 
On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
> > -      - qcom,sc7180-videocc
> > -      - qcom,sc7280-videocc
> > -      - qcom,sdm845-videocc
> > -      - qcom,sm6350-videocc
> > -      - qcom,sm8150-videocc
> > -      - qcom,sm8250-videocc
> > +    oneOf:
> > +      - enum:
> > +          - qcom,sc7180-videocc
> > +          - qcom,sc7280-videocc
> > +          - qcom,sdm845-videocc
> > +          - qcom,sm6350-videocc
> > +          - qcom,sm8150-videocc
> > +          - qcom,sm8250-videocc
> > +      - items:
> > +          - const: qcom,sc8180x-videocc
> > +          - const: qcom,sm8150-videocc
> >  
> >    clocks:
> >      minItems: 1
> > @@ -111,6 +115,7 @@ allOf:
> >        properties:
> >          compatible:
> >            enum:
> > +            - qcom,sc8180x-videocc
> 
> Is there a need for this? Isn't it already covered by the SM8150 entry?

Yes and no. Yes - some change here is needed as I explained. No - this
exact change does not work, so it is obviously redundant.

Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Posted by Satya Priya Kakitapalli 3 months ago 
On 7/3/2025 12:55 PM, Krzysztof Kozlowski wrote:
> On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
>>> -      - qcom,sc7180-videocc
>>> -      - qcom,sc7280-videocc
>>> -      - qcom,sdm845-videocc
>>> -      - qcom,sm6350-videocc
>>> -      - qcom,sm8150-videocc
>>> -      - qcom,sm8250-videocc
>>> +    oneOf:
>>> +      - enum:
>>> +          - qcom,sc7180-videocc
>>> +          - qcom,sc7280-videocc
>>> +          - qcom,sdm845-videocc
>>> +          - qcom,sm6350-videocc
>>> +          - qcom,sm8150-videocc
>>> +          - qcom,sm8250-videocc
>>> +      - items:
>>> +          - const: qcom,sc8180x-videocc
>>> +          - const: qcom,sm8150-videocc
>>>   
>>>     clocks:
>>>       minItems: 1
>>> @@ -111,6 +115,7 @@ allOf:
>>>         properties:
>>>           compatible:
>>>             enum:
>>> +            - qcom,sc8180x-videocc
>> Is there a need for this? Isn't it already covered by the SM8150 entry?
> Yes and no. Yes - some change here is needed as I explained. No - this
> exact change does not work, so it is obviously redundant.


Yes, I agree. I'll add 'contains:' throughout the schema and remove this 
compatible since anyway it matches with sm8150 compatible.


Thanks,

Satya Priya
Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Posted by Satya Priya Kakitapalli 3 months ago 
Hi Krzysztof,


On 7/4/2025 4:41 PM, Satya Priya Kakitapalli wrote:
>
> On 7/3/2025 12:55 PM, Krzysztof Kozlowski wrote:
>> On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
>>>> -      - qcom,sc7180-videocc
>>>> -      - qcom,sc7280-videocc
>>>> -      - qcom,sdm845-videocc
>>>> -      - qcom,sm6350-videocc
>>>> -      - qcom,sm8150-videocc
>>>> -      - qcom,sm8250-videocc
>>>> +    oneOf:
>>>> +      - enum:
>>>> +          - qcom,sc7180-videocc
>>>> +          - qcom,sc7280-videocc
>>>> +          - qcom,sdm845-videocc
>>>> +          - qcom,sm6350-videocc
>>>> +          - qcom,sm8150-videocc
>>>> +          - qcom,sm8250-videocc
>>>> +      - items:
>>>> +          - const: qcom,sc8180x-videocc
>>>> +          - const: qcom,sm8150-videocc
>>>>       clocks:
>>>>       minItems: 1
>>>> @@ -111,6 +115,7 @@ allOf:
>>>>         properties:
>>>>           compatible:
>>>>             enum:
>>>> +            - qcom,sc8180x-videocc
>>> Is there a need for this? Isn't it already covered by the SM8150 entry?
>> Yes and no. Yes - some change here is needed as I explained. No - this
>> exact change does not work, so it is obviously redundant.
>
>
> Yes, I agree. I'll add 'contains:' throughout the schema and remove 
> this compatible since anyway it matches with sm8150 compatible.
>

I checked this further and see that 'contains' is only needed for 
devices having multiple compatibles or using fallback.
Since we are not using the fallback for any of the other compatibles in 
this schema, I will add contains only for the sm8150 if/then block.


>
> Thanks,
>
> Satya Priya
>
>
Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Posted by Krzysztof Kozlowski 3 months, 1 week ago 
On 02/07/2025 17:13, Satya Priya Kakitapalli wrote:
>  
>    clocks:
>      minItems: 1
> @@ -111,6 +115,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,sc8180x-videocc

This is not correct, does not match the compatibles - test yourself. You
want here contains.

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.