[PATCH 0/7] Further kernel-doc tweakery

Jonathan Corbet posted 7 patches 3 months, 1 week ago
There is a newer version of this series
Documentation/sphinx/kerneldoc.py |   2 -
scripts/lib/kdoc/kdoc_parser.py   | 150 +++++++++++++++---------------
scripts/lib/kdoc/kdoc_re.py       |   6 +-
3 files changed, 79 insertions(+), 79 deletions(-)
[PATCH 0/7] Further kernel-doc tweakery
Posted by Jonathan Corbet 3 months, 1 week ago
This is a set of miscellaneous improvements, finishing my pass over the
first parsing pass and getting into the second ("dump_*") pass.

Jonathan Corbet (7):
  docs: kdoc: don't reinvent string.strip()
  docs: kdoc: micro-optimize KernRe
  docs: kdoc: remove the brcount floor in process_proto_type()
  docs: kdoc: rework type prototype parsing
  docs: kdoc: some tweaks to process_proto_function()
  docs: kdoc: Remove a Python 2 comment
  docs: kdoc: pretty up dump_enum()

 Documentation/sphinx/kerneldoc.py |   2 -
 scripts/lib/kdoc/kdoc_parser.py   | 150 +++++++++++++++---------------
 scripts/lib/kdoc/kdoc_re.py       |   6 +-
 3 files changed, 79 insertions(+), 79 deletions(-)

-- 
2.49.0
Re: [PATCH 0/7] Further kernel-doc tweakery
Posted by Akira Yokosawa 3 months ago
Hi Jon,

On Tue,  1 Jul 2025 14:57:23 -0600, Jonathan Corbet wrote:
> This is a set of miscellaneous improvements, finishing my pass over the
> first parsing pass and getting into the second ("dump_*") pass.
> 
> Jonathan Corbet (7):
>   docs: kdoc: don't reinvent string.strip()
>   docs: kdoc: micro-optimize KernRe
>   docs: kdoc: remove the brcount floor in process_proto_type()
>   docs: kdoc: rework type prototype parsing
>   docs: kdoc: some tweaks to process_proto_function()
>   docs: kdoc: Remove a Python 2 comment
>   docs: kdoc: pretty up dump_enum()
> 
>  Documentation/sphinx/kerneldoc.py |   2 -
>  scripts/lib/kdoc/kdoc_parser.py   | 150 +++++++++++++++---------------
>  scripts/lib/kdoc/kdoc_re.py       |   6 +-
>  3 files changed, 79 insertions(+), 79 deletions(-)
> 

I just applied this set and got the error of:

---------------------------------------------------------------
  File "/<srcdir>/scripts/lib/kdoc/kdoc_parser.py", line 881
    	    else:
    ^
TabError: inconsistent use of tabs and spaces in indentation
---------------------------------------------------------------

I didn't look into individual patches, assuming it should be an easy fix
for you.

I guess it'd be better to test (and hopefully to review) other pending
series from you and Mauro ...

        Thanks, Akira
Re: [PATCH 0/7] Further kernel-doc tweakery
Posted by Jonathan Corbet 3 months ago
Akira Yokosawa <akiyks@gmail.com> writes:

> Hi Jon,
>
> On Tue,  1 Jul 2025 14:57:23 -0600, Jonathan Corbet wrote:
>> This is a set of miscellaneous improvements, finishing my pass over the
>> first parsing pass and getting into the second ("dump_*") pass.
>> 
>> Jonathan Corbet (7):
>>   docs: kdoc: don't reinvent string.strip()
>>   docs: kdoc: micro-optimize KernRe
>>   docs: kdoc: remove the brcount floor in process_proto_type()
>>   docs: kdoc: rework type prototype parsing
>>   docs: kdoc: some tweaks to process_proto_function()
>>   docs: kdoc: Remove a Python 2 comment
>>   docs: kdoc: pretty up dump_enum()
>> 
>>  Documentation/sphinx/kerneldoc.py |   2 -
>>  scripts/lib/kdoc/kdoc_parser.py   | 150 +++++++++++++++---------------
>>  scripts/lib/kdoc/kdoc_re.py       |   6 +-
>>  3 files changed, 79 insertions(+), 79 deletions(-)
>> 
>
> I just applied this set and got the error of:
>
> ---------------------------------------------------------------
>   File "/<srcdir>/scripts/lib/kdoc/kdoc_parser.py", line 881
>     	    else:
>     ^
> TabError: inconsistent use of tabs and spaces in indentation
> ---------------------------------------------------------------
>
> I didn't look into individual patches, assuming it should be an easy fix
> for you.
>
> I guess it'd be better to test (and hopefully to review) other pending
> series from you and Mauro ...

Yes, sorry, I ran into that after sending ... I have no idea which weird
last-second edit introduced that error.  It worked before, honest...

I'll go ahead and send a new series shortly.

Thanks for testing!

jon