[PATCH v9 0/4] Enable debugfs information based on client-id

Sunil Khatri posted 4 patches 3 months, 1 week ago
There is a newer version of this series
drivers/accel/drm_accel.c                   |  16 ---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |  52 +++++++++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h |   1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c     |   2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c   |  52 +++++++++
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h   |   1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c      |   4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h      |   4 +-
drivers/gpu/drm/drm_debugfs.c               | 113 ++++++++++++++++++--
drivers/gpu/drm/drm_drv.c                   |  14 +--
drivers/gpu/drm/drm_file.c                  |   9 ++
drivers/gpu/drm/drm_internal.h              |   6 +-
include/drm/drm_accel.h                     |   5 -
include/drm/drm_debugfs.h                   |  11 ++
include/drm/drm_drv.h                       |  14 ++-
include/drm/drm_file.h                      |   7 ++
16 files changed, 265 insertions(+), 46 deletions(-)
[PATCH v9 0/4] Enable debugfs information based on client-id
Posted by Sunil Khatri 3 months, 1 week ago
client-id is a unique id across the system no matter if its from a VM
or on a host system. This unique id is a good base to use create
client-id based dentry in debugfs in the root directory.

This directory could be a unique directory where drivers could dump
the debug information.

For amdgpu driver, we want to dump the VM PTBASE address and MQD for 
userqueue which can be used by a tool like amd umr to dump the memory
and that is really important to debug userqueues and VM related issues.

One of the challenge in this how to access the root directory which is
beyond the drm_device hence moving the debugfs related information to
drm_debugfs.c 

Sunil Khatri (4):
  drm: move drm based debugfs funcs to drm_debugfs.c
  drm: add debugfs support on per client-id basis
  drm/amdgpu: add debugfs support for VM pagetable per client
  drm/amdgpu: add support of debugfs for mqd information

 drivers/accel/drm_accel.c                   |  16 ---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |  52 +++++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c     |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c   |  52 +++++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h   |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c      |   4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h      |   4 +-
 drivers/gpu/drm/drm_debugfs.c               | 113 ++++++++++++++++++--
 drivers/gpu/drm/drm_drv.c                   |  14 +--
 drivers/gpu/drm/drm_file.c                  |   9 ++
 drivers/gpu/drm/drm_internal.h              |   6 +-
 include/drm/drm_accel.h                     |   5 -
 include/drm/drm_debugfs.h                   |  11 ++
 include/drm/drm_drv.h                       |  14 ++-
 include/drm/drm_file.h                      |   7 ++
 16 files changed, 265 insertions(+), 46 deletions(-)

-- 
2.34.1
Re: [PATCH v9 0/4] Enable debugfs information based on client-id
Posted by Philipp Stanner 3 months, 1 week ago
On Tue, 2025-07-01 at 22:19 +0530, Sunil Khatri wrote:
> client-id is a unique id across the system no matter if its from a VM
> or on a host system. This unique id is a good base to use create
> client-id based dentry in debugfs in the root directory.
> 
> This directory could be a unique directory where drivers could dump
> the debug information.
> 
> For amdgpu driver, we want to dump the VM PTBASE address and MQD for 
> userqueue which can be used by a tool like amd umr to dump the memory
> and that is really important to debug userqueues and VM related
> issues.
> 
> One of the challenge in this how to access the root directory which
> is
> beyond the drm_device hence moving the debugfs related information to
> drm_debugfs.c 
> 
> Sunil Khatri (4):
>   drm: move drm based debugfs funcs to drm_debugfs.c
>   drm: add debugfs support on per client-id basis
>   drm/amdgpu: add debugfs support for VM pagetable per client
>   drm/amdgpu: add support of debugfs for mqd information

Hi,

please wait >24h before sending new versions of a series, so that more
people can opt in and traffic on the lists gets reduced

Thx


> 
>  drivers/accel/drm_accel.c                   |  16 ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |  52 +++++++++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h |   1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c     |   2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c   |  52 +++++++++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h   |   1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c      |   4 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h      |   4 +-
>  drivers/gpu/drm/drm_debugfs.c               | 113
> ++++++++++++++++++--
>  drivers/gpu/drm/drm_drv.c                   |  14 +--
>  drivers/gpu/drm/drm_file.c                  |   9 ++
>  drivers/gpu/drm/drm_internal.h              |   6 +-
>  include/drm/drm_accel.h                     |   5 -
>  include/drm/drm_debugfs.h                   |  11 ++
>  include/drm/drm_drv.h                       |  14 ++-
>  include/drm/drm_file.h                      |   7 ++
>  16 files changed, 265 insertions(+), 46 deletions(-)
>