[v2] iio: imu: inv_mpu6050: Replace scnprintf with sysfs_emit

[PATCH v2] iio: imu: inv_mpu6050: Replace scnprintf with sysfs_emit

Posted by Chelsy Ratnawat 3 months, 1 week ago

Documentation/filesystems/sysfs.rst mentions that show() should only
use sysfs_emit() or sysfs_emit_at() when formating the value to be
returned to user space. So replace scnprintf() with sysfs_emit().

Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index b8656c02354a..39eb516acc73 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -1382,7 +1382,7 @@ inv_fifo_rate_show(struct device *dev, struct device_attribute *attr,
 	fifo_rate = INV_MPU6050_DIVIDER_TO_FIFO_RATE(st->chip_config.divider);
 	mutex_unlock(&st->lock);
 
-	return scnprintf(buf, PAGE_SIZE, "%u\n", fifo_rate);
+	return sysfs_emit(buf, "%u\n", fifo_rate);
 }
 
 /*
@@ -1409,8 +1409,7 @@ static ssize_t inv_attr_show(struct device *dev, struct device_attribute *attr,
 	case ATTR_ACCL_MATRIX:
 		m = st->plat_data.orientation;
 
-		return scnprintf(buf, PAGE_SIZE,
-			"%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
+		return sysfs_emit(buf, "%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
 			m[0], m[1], m[2], m[3], m[4], m[5], m[6], m[7], m[8]);
 	default:
 		return -EINVAL;
-- 
2.47.1

Re: [PATCH v2] iio: imu: inv_mpu6050: Replace scnprintf with sysfs_emit

Posted by Andy Shevchenko 3 months, 1 week ago

On Tue, Jul 01, 2025 at 08:47:20AM -0700, Chelsy Ratnawat wrote:
> Documentation/filesystems/sysfs.rst mentions that show() should only
> use sysfs_emit() or sysfs_emit_at() when formating the value to be
> returned to user space. So replace scnprintf() with sysfs_emit().

...

> -		return scnprintf(buf, PAGE_SIZE,
> -			"%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
> +		return sysfs_emit(buf, "%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
>  			m[0], m[1], m[2], m[3], m[4], m[5], m[6], m[7], m[8]);

Ideally second line should be reindented, but I won't be bothered by that
right now.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] iio: imu: inv_mpu6050: Replace scnprintf with sysfs_emit

Posted by Jonathan Cameron 3 months ago

On Tue, 1 Jul 2025 22:19:09 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Tue, Jul 01, 2025 at 08:47:20AM -0700, Chelsy Ratnawat wrote:
> > Documentation/filesystems/sysfs.rst mentions that show() should only
> > use sysfs_emit() or sysfs_emit_at() when formating the value to be
> > returned to user space. So replace scnprintf() with sysfs_emit().  
> 
> ...
> 
> > -		return scnprintf(buf, PAGE_SIZE,
> > -			"%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
> > +		return sysfs_emit(buf, "%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
> >  			m[0], m[1], m[2], m[3], m[4], m[5], m[6], m[7], m[8]);  
> 
> Ideally second line should be reindented, but I won't be bothered by that
> right now.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to the togreg branch of iio.git.  I'll initially push that out
as testing to get some early build testing from 0-day.

Thanks,

Jonathan

>