Add a dedicated compatible string for USB HS phy found in this SoC.
The SoC requires two clocks, named "phy" and "ref" (same as clocks
required by Exynos850).
It also requires various power supplies (regulators) for the internal
circuitry to work. The required voltages are:
* avdd075_usb - 0.75v
* avdd18_usb20 - 1.8v
* avdd33_usb20 - 3.3v
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
---
.../bindings/phy/samsung,usb3-drd-phy.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
index e906403208c0..2e29ff749bba 100644
--- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
@@ -34,6 +34,7 @@ properties:
- samsung,exynos7870-usbdrd-phy
- samsung,exynos850-usbdrd-phy
- samsung,exynos990-usbdrd-phy
+ - samsung,exynosautov920-usbdrd-phy
clocks:
minItems: 1
@@ -110,6 +111,15 @@ properties:
vddh-usbdp-supply:
description: VDDh power supply for the USB DP phy.
+ avdd075_usb-supply:
+ description: 0.75V power supply for USB phy
+
+ avdd18_usb20-supply:
+ description: 1.8V power supply for USB phy
+
+ avdd33_usb20-supply:
+ description: 3.3V power supply for USB phy
+
required:
- compatible
- clocks
@@ -235,6 +245,33 @@ allOf:
reg-names:
maxItems: 1
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynosautov920-usbdrd-phy
+ then:
+ properties:
+ clocks:
+ minItems: 2
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: phy
+ - const: ref
+
+ reg:
+ maxItems: 1
+
+ reg-names:
+ maxItems: 1
+
+ required:
+ - avdd075_usb-supply
+ - avdd18_usb20-supply
+ - avdd33_usb20-supply
unevaluatedProperties: false
--
2.34.1On Tue, Jul 01, 2025 at 05:37:01PM +0530, Pritam Manohar Sutar wrote: > Add a dedicated compatible string for USB HS phy found in this SoC. > The SoC requires two clocks, named "phy" and "ref" (same as clocks > required by Exynos850). > > It also requires various power supplies (regulators) for the internal > circuitry to work. The required voltages are: > * avdd075_usb - 0.75v > * avdd18_usb20 - 1.8v > * avdd33_usb20 - 3.3v > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> No, really. Look: > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > --- > .../bindings/phy/samsung,usb3-drd-phy.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > index e906403208c0..2e29ff749bba 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > @@ -34,6 +34,7 @@ properties: > - samsung,exynos7870-usbdrd-phy > - samsung,exynos850-usbdrd-phy > - samsung,exynos990-usbdrd-phy > + - samsung,exynosautov920-usbdrd-phy > > clocks: > minItems: 1 > @@ -110,6 +111,15 @@ properties: > vddh-usbdp-supply: > description: VDDh power supply for the USB DP phy. > > + avdd075_usb-supply: > + description: 0.75V power supply for USB phy > + > + avdd18_usb20-supply: > + description: 1.8V power supply for USB phy > + > + avdd33_usb20-supply: > + description: 3.3V power supply for USB phy > + None of these were here. Follow DTS coding style... but why are you adding completely new supplies? > required: > - compatible > - clocks > @@ -235,6 +245,33 @@ allOf: > > reg-names: > maxItems: 1 > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynosautov920-usbdrd-phy > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + > + clock-names: > + items: > + - const: phy > + - const: ref > + > + reg: > + maxItems: 1 > + > + reg-names: > + maxItems: 1 > + > + required: > + - avdd075_usb-supply > + - avdd18_usb20-supply > + - avdd33_usb20-supply Neither was this entire diff hunk here. This was part of other block for a reason. NAK Best regards, Krzysztof
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 06 July 2025 03:11 PM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com;
> andre.draszik@linaro.org; peter.griffin@linaro.org; neil.armstrong@linaro.org;
> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com;
> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux-
> phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
>
> On Tue, Jul 01, 2025 at 05:37:01PM +0530, Pritam Manohar Sutar wrote:
> > Add a dedicated compatible string for USB HS phy found in this SoC.
> > The SoC requires two clocks, named "phy" and "ref" (same as clocks
> > required by Exynos850).
> >
> > It also requires various power supplies (regulators) for the internal
> > circuitry to work. The required voltages are:
> > * avdd075_usb - 0.75v
> > * avdd18_usb20 - 1.8v
> > * avdd33_usb20 - 3.3v
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> No, really. Look:
>
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> > ---
> > .../bindings/phy/samsung,usb3-drd-phy.yaml | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> > b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> > index e906403208c0..2e29ff749bba 100644
> > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> > @@ -34,6 +34,7 @@ properties:
> > - samsung,exynos7870-usbdrd-phy
> > - samsung,exynos850-usbdrd-phy
> > - samsung,exynos990-usbdrd-phy
> > + - samsung,exynosautov920-usbdrd-phy
> >
> > clocks:
> > minItems: 1
> > @@ -110,6 +111,15 @@ properties:
> > vddh-usbdp-supply:
> > description: VDDh power supply for the USB DP phy.
> >
> > + avdd075_usb-supply:
> > + description: 0.75V power supply for USB phy
> > +
> > + avdd18_usb20-supply:
> > + description: 1.8V power supply for USB phy
> > +
> > + avdd33_usb20-supply:
> > + description: 3.3V power supply for USB phy
> > +
>
> None of these were here. Follow DTS coding style... but why are you adding
> completely new supplies?
Digital supplies were here. Need Analog supplies for exynosautov920, hence added new Analog supplies; 'a'vdd075_usb, 'a'vdd18_usb20, 'a'vdd33_usb20
Will add "full stops" for DTS coding style in description.
>
>
> > required:
> > - compatible
> > - clocks
> > @@ -235,6 +245,33 @@ allOf:
> >
> > reg-names:
> > maxItems: 1
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - samsung,exynosautov920-usbdrd-phy
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 2
> > + maxItems: 2
> > +
> > + clock-names:
> > + items:
> > + - const: phy
> > + - const: ref
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + reg-names:
> > + maxItems: 1
> > +
> > + required:
> > + - avdd075_usb-supply
> > + - avdd18_usb20-supply
> > + - avdd33_usb20-supply
>
> Neither was this entire diff hunk here.
>
> This was part of other block for a reason.
Added regulators in driver. This block is added for regulators (other block does not have "required" field for power supplies)
if excluded this block,
"make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml" will fail as mentioned below
/home/pritam.sutar/workspace/auto/kitt2/projects/upstream/src/kernel/github/linux-next/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: phy@16480000: Unevaluated properties are not allowed ('avdd075_usb-supply', 'avdd18_usb20-supply', 'avdd33_usb20-supply' were unexpected)
from schema $id: http://devicetree.org/schemas/phy/samsung,usb3-drd-phy.yaml#
/home/pritam.sutar/workspace/auto/kitt2/projects/upstream/src/kernel/github/linux-next/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: phy@16490000: Unevaluated properties are not allowed ('avdd075_usb-supply', 'avdd18_usb20-supply', 'avdd33_usb20-supply' were unexpected)
from schema $id: http://devicetree.org/schemas/phy/samsung,usb3-drd-phy.yaml#
/home/pritam.sutar/workspace/auto/kitt2/projects/upstream/src/kernel/github/linux-next/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: phy@16500000: Unevaluated properties are not allowed ('avdd075_usb-supply', 'avdd18_usb20-supply', 'avdd33_usb20-supply' were unexpected)
from schema $id: http://devicetree.org/schemas/phy/samsung,usb3-drd-phy.yaml#
/home/pritam.sutar/workspace/auto/kitt2/projects/upstream/src/kernel/github/linux-next/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: phy@16510000: Unevaluated properties are not allowed ('avdd075_usb-supply', 'avdd18_usb20-supply', 'avdd33_usb20-supply' were unexpected)
from schema $id: http://devicetree.org/schemas/phy/samsung,usb3-drd-phy.yaml#
/home/pritam.sutar/workspace/auto/kitt2/projects/upstream/src/kernel/github/linux-next/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: phy@16520000: Unevaluated properties are not allowed ('avdd075_usb-supply', 'avdd18_usb20-supply', 'avdd33_usb20-supply' were unexpected)
from schema $id: http://devicetree.org/schemas/phy/samsung,usb3-drd-phy.yaml#
Note: These patches are being validated by enabling DTS (However, DTS patches are planned in next phase).
If you have any idea to re-use existing block by differentiating required power supplies, please suggest.
>
> NAK
>
> Best regards,
> Krzysztof
On 09/07/2025 10:46, Pritam Manohar Sutar wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 06 July 2025 03:11 PM >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; >> andre.draszik@linaro.org; peter.griffin@linaro.org; neil.armstrong@linaro.org; >> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; >> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- >> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- >> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; >> faraz.ata@samsung.com; muhammed.ali@samsung.com; >> selvarasu.g@samsung.com >> Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add >> ExynosAutov920 HS phy compatible >> >> On Tue, Jul 01, 2025 at 05:37:01PM +0530, Pritam Manohar Sutar wrote: >>> Add a dedicated compatible string for USB HS phy found in this SoC. >>> The SoC requires two clocks, named "phy" and "ref" (same as clocks >>> required by Exynos850). >>> >>> It also requires various power supplies (regulators) for the internal >>> circuitry to work. The required voltages are: >>> * avdd075_usb - 0.75v >>> * avdd18_usb20 - 1.8v >>> * avdd33_usb20 - 3.3v >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> No, really. Look: >> >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> >>> --- >>> .../bindings/phy/samsung,usb3-drd-phy.yaml | 37 +++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> index e906403208c0..2e29ff749bba 100644 >>> --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> @@ -34,6 +34,7 @@ properties: >>> - samsung,exynos7870-usbdrd-phy >>> - samsung,exynos850-usbdrd-phy >>> - samsung,exynos990-usbdrd-phy >>> + - samsung,exynosautov920-usbdrd-phy >>> >>> clocks: >>> minItems: 1 >>> @@ -110,6 +111,15 @@ properties: >>> vddh-usbdp-supply: >>> description: VDDh power supply for the USB DP phy. >>> >>> + avdd075_usb-supply: >>> + description: 0.75V power supply for USB phy >>> + >>> + avdd18_usb20-supply: >>> + description: 1.8V power supply for USB phy >>> + >>> + avdd33_usb20-supply: >>> + description: 3.3V power supply for USB phy >>> + >> >> None of these were here. Follow DTS coding style... but why are you adding >> completely new supplies? > > Digital supplies were here. Need Analog supplies for exynosautov920, hence added new Analog supplies; 'a'vdd075_usb, 'a'vdd18_usb20, 'a'vdd33_usb20 > > Will add "full stops" for DTS coding style in description. You cannot grow one line change into 50 line change and retain the review. > >> >> >>> required: >>> - compatible >>> - clocks >>> @@ -235,6 +245,33 @@ allOf: >>> >>> reg-names: >>> maxItems: 1 >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - samsung,exynosautov920-usbdrd-phy >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 2 >>> + maxItems: 2 >>> + >>> + clock-names: >>> + items: >>> + - const: phy >>> + - const: ref >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + reg-names: >>> + maxItems: 1 >>> + >>> + required: >>> + - avdd075_usb-supply >>> + - avdd18_usb20-supply >>> + - avdd33_usb20-supply >> >> Neither was this entire diff hunk here. >> >> This was part of other block for a reason. > > Added regulators in driver. This block is added for regulators (other block does not have "required" field for power supplies) > if excluded this block, > "make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml" will fail as mentioned below Nothing is explained in changelog/cover letter. You claim you only added Rb tag. This is an entirely silent change while keeping the review. Combined with not even following DTS style! It's not acceptable. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 12 July 2025 01:44 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; 'Krzysztof Kozlowski' > <krzysztof.kozlowski@linaro.org> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; neil.armstrong@linaro.org; > kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 09/07/2025 10:46, Pritam Manohar Sutar wrote: > > Hi Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: 06 July 2025 03:11 PM > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > >> andre.draszik@linaro.org; peter.griffin@linaro.org; > >> neil.armstrong@linaro.org; kauschluss@disroot.org; > >> ivo.ivanov.ivanov1@gmail.com; m.szyprowski@samsung.com; > >> s.nawrocki@samsung.com; linux- phy@lists.infradead.org; > >> devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; > >> linux-arm-kernel@lists.infradead.org; linux-samsung- > >> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > >> faraz.ata@samsung.com; muhammed.ali@samsung.com; > >> selvarasu.g@samsung.com > >> Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: > >> add > >> ExynosAutov920 HS phy compatible > >> > >> On Tue, Jul 01, 2025 at 05:37:01PM +0530, Pritam Manohar Sutar wrote: > >>> Add a dedicated compatible string for USB HS phy found in this SoC. > >>> The SoC requires two clocks, named "phy" and "ref" (same as clocks > >>> required by Exynos850). > >>> > >>> It also requires various power supplies (regulators) for the > >>> internal circuitry to work. The required voltages are: > >>> * avdd075_usb - 0.75v > >>> * avdd18_usb20 - 1.8v > >>> * avdd33_usb20 - 3.3v > >>> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> > >> No, really. Look: > >> > >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >>> --- > >>> .../bindings/phy/samsung,usb3-drd-phy.yaml | 37 +++++++++++++++++++ > >>> 1 file changed, 37 insertions(+) > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> index e906403208c0..2e29ff749bba 100644 > >>> --- > >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yam > >>> +++ l > >>> @@ -34,6 +34,7 @@ properties: > >>> - samsung,exynos7870-usbdrd-phy > >>> - samsung,exynos850-usbdrd-phy > >>> - samsung,exynos990-usbdrd-phy > >>> + - samsung,exynosautov920-usbdrd-phy > >>> > >>> clocks: > >>> minItems: 1 > >>> @@ -110,6 +111,15 @@ properties: > >>> vddh-usbdp-supply: > >>> description: VDDh power supply for the USB DP phy. > >>> > >>> + avdd075_usb-supply: > >>> + description: 0.75V power supply for USB phy > >>> + > >>> + avdd18_usb20-supply: > >>> + description: 1.8V power supply for USB phy > >>> + > >>> + avdd33_usb20-supply: > >>> + description: 3.3V power supply for USB phy > >>> + > >> > >> None of these were here. Follow DTS coding style... but why are you > >> adding completely new supplies? > > > > Digital supplies were here. Need Analog supplies for exynosautov920, > > hence added new Analog supplies; 'a'vdd075_usb, 'a'vdd18_usb20, > > 'a'vdd33_usb20 > > > > Will add "full stops" for DTS coding style in description. > > You cannot grow one line change into 50 line change and retain the review. Yes agreed. Will remove "Reviewed-by" tag and requesting you to review the patches again and provide your valuable comments. > > > >> > >> > >>> required: > >>> - compatible > >>> - clocks > >>> @@ -235,6 +245,33 @@ allOf: > >>> > >>> reg-names: > >>> maxItems: 1 > >>> + - if: > >>> + properties: > >>> + compatible: > >>> + contains: > >>> + enum: > >>> + - samsung,exynosautov920-usbdrd-phy > >>> + then: > >>> + properties: > >>> + clocks: > >>> + minItems: 2 > >>> + maxItems: 2 > >>> + > >>> + clock-names: > >>> + items: > >>> + - const: phy > >>> + - const: ref > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + reg-names: > >>> + maxItems: 1 > >>> + > >>> + required: > >>> + - avdd075_usb-supply > >>> + - avdd18_usb20-supply > >>> + - avdd33_usb20-supply > >> > >> Neither was this entire diff hunk here. > >> > >> This was part of other block for a reason. > > > > Added regulators in driver. This block is added for regulators (other > > block does not have "required" field for power supplies) if excluded > > this block, "make ARCH=arm64 dtbs_check > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/samsung,usb3- > drd > > -phy.yaml" will fail as mentioned below > > > Nothing is explained in changelog/cover letter. You claim you only added Rb tag. > This is an entirely silent change while keeping the review. Will add more explanations in cover letter/changelog why this block is added. > Combined with not even following DTS style! Ok got it. Will change supplies name as below avdd075_usb => avdd075-usb avdd18_usb20 => avdd18-usb20 avdd33_usb20 => avdd33-usb20 Confirm the above change that is meant in terms of DTS style. > > It's not acceptable. > > Best regards, > Krzysztof Thank you. Regards, Pritam
On 17/07/2025 13:13, Pritam Manohar Sutar wrote: >> >> >> Nothing is explained in changelog/cover letter. You claim you only added Rb tag. >> This is an entirely silent change while keeping the review. > > Will add more explanations in cover letter/changelog why this block is added. > >> Combined with not even following DTS style! > > Ok got it. Will change supplies name as below > avdd075_usb => avdd075-usb > avdd18_usb20 => avdd18-usb20 > avdd33_usb20 => avdd33-usb20 > > Confirm the above change that is meant in terms of DTS style. Yes. I have doubts that actual supplies have suffix usb20. Are there more than one avdd18 for this block? Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 17 July 2025 04:59 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; 'Krzysztof Kozlowski' > <krzysztof.kozlowski@linaro.org> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; neil.armstrong@linaro.org; > kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 17/07/2025 13:13, Pritam Manohar Sutar wrote: > >> > >> > >> Nothing is explained in changelog/cover letter. You claim you only added Rb > tag. > >> This is an entirely silent change while keeping the review. > > > > Will add more explanations in cover letter/changelog why this block is added. > > > >> Combined with not even following DTS style! > > > > Ok got it. Will change supplies name as below avdd075_usb => > > avdd075-usb > > avdd18_usb20 => avdd18-usb20 > > avdd33_usb20 => avdd33-usb20 > > > > Confirm the above change that is meant in terms of DTS style. > Yes. I have doubts that actual supplies have suffix usb20. Are there more than > one avdd18 for this block? > Yes, there are more than one vdd18 supplies for this block. Re-analysed your comment on adding new supplies. Going to re-use existing supplies as mentioned below, rather than introducing new supplies dvdd-usb20-supply => for 0.75v vddh-usb20-supply => for 1.8v vdd33-usb20-supply => for 3.3v > Best regards, > Krzysztof Thank you. Regards, Pritam
On 22/07/2025 06:34, Pritam Manohar Sutar wrote: >>>> Nothing is explained in changelog/cover letter. You claim you only added Rb >> tag. >>>> This is an entirely silent change while keeping the review. >>> >>> Will add more explanations in cover letter/changelog why this block is added. >>> >>>> Combined with not even following DTS style! >>> >>> Ok got it. Will change supplies name as below avdd075_usb => >>> avdd075-usb >>> avdd18_usb20 => avdd18-usb20 >>> avdd33_usb20 => avdd33-usb20 >>> >>> Confirm the above change that is meant in terms of DTS style. >> Yes. I have doubts that actual supplies have suffix usb20. Are there more than >> one avdd18 for this block? >> > > Yes, there are more than one vdd18 supplies for this block. And their names are? > > Re-analysed your comment on adding new supplies. > Going to re-use existing supplies as mentioned below, rather than > introducing new supplies > > dvdd-usb20-supply => for 0.75v > vddh-usb20-supply => for 1.8v > vdd33-usb20-supply => for 3.3v You just expect us to guess whether this is correct... Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 22 July 2025 11:37 AM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; 'Krzysztof Kozlowski' > <krzysztof.kozlowski@linaro.org> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; neil.armstrong@linaro.org; > kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 22/07/2025 06:34, Pritam Manohar Sutar wrote: > >>>> Nothing is explained in changelog/cover letter. You claim you only > >>>> added Rb > >> tag. > >>>> This is an entirely silent change while keeping the review. > >>> > >>> Will add more explanations in cover letter/changelog why this block is > added. > >>> > >>>> Combined with not even following DTS style! > >>> > >>> Ok got it. Will change supplies name as below avdd075_usb => > >>> avdd075-usb > >>> avdd18_usb20 => avdd18-usb20 > >>> avdd33_usb20 => avdd33-usb20 > >>> > >>> Confirm the above change that is meant in terms of DTS style. > >> Yes. I have doubts that actual supplies have suffix usb20. Are there > >> more than one avdd18 for this block? > >> > > > > Yes, there are more than one vdd18 supplies for this block. > > And their names are? > > > > > Re-analysed your comment on adding new supplies. > > Going to re-use existing supplies as mentioned below, rather than > > introducing new supplies > > > > dvdd-usb20-supply => for 0.75v > > vddh-usb20-supply => for 1.8v > > vdd33-usb20-supply => for 3.3v > > > You just expect us to guess whether this is correct... Sorry about not being clear so far. V920 needs three supplies, 0.75v, 1.8v and 3.3v for USB PHY The naming convention used in the schematic are avdd075-usb, avdd18_usb20, avdd33_usb20. However, PHY's user manual just mentions DVDD, VDD33 and VDD18. Since GS101 binding already using supply names similar to what is mentioned in the PHY user manual. I thought of using the same instead of earlier naming conventions (which was as per v920 schematic). Let me know if this make sense or we should be just using as per schematic? > > Best regards, > Krzysztof Regards, Pritam
On 23/07/2025 07:11, Pritam Manohar Sutar wrote: >> On 22/07/2025 06:34, Pritam Manohar Sutar wrote: >>>>>> Nothing is explained in changelog/cover letter. You claim you only >>>>>> added Rb >>>> tag. >>>>>> This is an entirely silent change while keeping the review. >>>>> >>>>> Will add more explanations in cover letter/changelog why this block is >> added. >>>>> >>>>>> Combined with not even following DTS style! >>>>> >>>>> Ok got it. Will change supplies name as below avdd075_usb => >>>>> avdd075-usb >>>>> avdd18_usb20 => avdd18-usb20 >>>>> avdd33_usb20 => avdd33-usb20 >>>>> >>>>> Confirm the above change that is meant in terms of DTS style. >>>> Yes. I have doubts that actual supplies have suffix usb20. Are there >>>> more than one avdd18 for this block? >>>> >>> >>> Yes, there are more than one vdd18 supplies for this block. >> >> And their names are? >> >>> >>> Re-analysed your comment on adding new supplies. >>> Going to re-use existing supplies as mentioned below, rather than >>> introducing new supplies >>> >>> dvdd-usb20-supply => for 0.75v >>> vddh-usb20-supply => for 1.8v >>> vdd33-usb20-supply => for 3.3v >> >> >> You just expect us to guess whether this is correct... > > Sorry about not being clear so far. > > V920 needs three supplies, 0.75v, 1.8v and 3.3v for USB PHY > The naming convention used in the schematic are > avdd075-usb, > avdd18_usb20, > avdd33_usb20. > > However, PHY's user manual just mentions DVDD, VDD33 and VDD18. Then dvdd, vdd33 and vdd18. > Since GS101 binding already using supply names similar to what is mentioned in the PHY user manual. GS101 has USB 2.0 and DP, thus the suffix made some sense. I think you have only USB 2.0, that's why I question the suffix. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Wednesday, July 23, 2025 2:13 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; 'Krzysztof > Kozlowski' <krzysztof.kozlowski@linaro.org> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; [snip] > >>>>> Ok got it. Will change supplies name as below avdd075_usb => > >>>>> avdd075-usb > >>>>> avdd18_usb20 => avdd18-usb20 > >>>>> avdd33_usb20 => avdd33-usb20 > >>>>> > >>>>> Confirm the above change that is meant in terms of DTS style. > >>>> Yes. I have doubts that actual supplies have suffix usb20. Are > >>>> there more than one avdd18 for this block? > >>>> > >>> > >>> Yes, there are more than one vdd18 supplies for this block. > >> > >> And their names are? > >> > >>> > >>> Re-analysed your comment on adding new supplies. > >>> Going to re-use existing supplies as mentioned below, rather than > >>> introducing new supplies > >>> > >>> dvdd-usb20-supply => for 0.75v > >>> vddh-usb20-supply => for 1.8v > >>> vdd33-usb20-supply => for 3.3v > >> > >> > >> You just expect us to guess whether this is correct... > > > > Sorry about not being clear so far. > > > > V920 needs three supplies, 0.75v, 1.8v and 3.3v for USB PHY The naming > > convention used in the schematic are avdd075-usb, avdd18_usb20, > > avdd33_usb20. > > > > However, PHY's user manual just mentions DVDD, VDD33 and VDD18. > > > Then dvdd, vdd33 and vdd18. > > > Since GS101 binding already using supply names similar to what is > mentioned in the PHY user manual. > > > GS101 has USB 2.0 and DP, thus the suffix made some sense. I think you have > only USB 2.0, that's why I question the suffix. > I cross checked the schematic of v920 SADK, this is a combo PHY which support USB-3.0 as well. @ Pritam Schema should capture all the supplies including USB-3.0, similar to GS101 (which has USB2.0 and DP combo). So that would be as below: dvdd075-usb20-supply vdd18-usb20-supply vdd33-usb20-supply dvdd075-usb30-supply vdd18-usb30-supply please cross check the supply at your end and do the needful. > > Best regards, > Krzysztof
Hi, > -----Original Message----- > From: Alim Akhtar <alim.akhtar@samsung.com> > Sent: 23 July 2025 06:15 PM > To: 'Krzysztof Kozlowski' <krzk@kernel.org>; 'Pritam Manohar Sutar' > <pritam.sutar@samsung.com>; 'Krzysztof Kozlowski' > <krzysztof.kozlowski@linaro.org> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; andre.draszik@linaro.org; > peter.griffin@linaro.org; neil.armstrong@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; m.szyprowski@samsung.com; > s.nawrocki@samsung.com; linux-phy@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; > rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: RE: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzk@kernel.org> > > Sent: Wednesday, July 23, 2025 2:13 PM > > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; 'Krzysztof > > Kozlowski' <krzysztof.kozlowski@linaro.org> > > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > [snip] > > >>>>> Ok got it. Will change supplies name as below avdd075_usb => > > >>>>> avdd075-usb > > >>>>> avdd18_usb20 => avdd18-usb20 > > >>>>> avdd33_usb20 => avdd33-usb20 > > >>>>> > > >>>>> Confirm the above change that is meant in terms of DTS style. > > >>>> Yes. I have doubts that actual supplies have suffix usb20. Are > > >>>> there more than one avdd18 for this block? > > >>>> > > >>> > > >>> Yes, there are more than one vdd18 supplies for this block. > > >> > > >> And their names are? > > >> > > >>> > > >>> Re-analysed your comment on adding new supplies. > > >>> Going to re-use existing supplies as mentioned below, rather than > > >>> introducing new supplies > > >>> > > >>> dvdd-usb20-supply => for 0.75v > > >>> vddh-usb20-supply => for 1.8v > > >>> vdd33-usb20-supply => for 3.3v > > >> > > >> > > >> You just expect us to guess whether this is correct... > > > > > > Sorry about not being clear so far. > > > > > > V920 needs three supplies, 0.75v, 1.8v and 3.3v for USB PHY The > > > naming convention used in the schematic are avdd075-usb, > > > avdd18_usb20, avdd33_usb20. > > > > > > However, PHY's user manual just mentions DVDD, VDD33 and VDD18. > > > > > > Then dvdd, vdd33 and vdd18. > > > > > Since GS101 binding already using supply names similar to what is > > mentioned in the PHY user manual. > > > > > > GS101 has USB 2.0 and DP, thus the suffix made some sense. I think you > > have only USB 2.0, that's why I question the suffix. > > > I cross checked the schematic of v920 SADK, this is a combo PHY which > support USB-3.0 as well. > @ Pritam > Schema should capture all the supplies including USB-3.0, similar to GS101 > (which has USB2.0 and DP combo). > So that would be as below: > dvdd075-usb20-supply > vdd18-usb20-supply > vdd33-usb20-supply > dvdd075-usb30-supply > vdd18-usb30-supply > please cross check the supply at your end and do the needful. > Yes, we have a combo PHY that supports USB20 and USB30 and need these supplies. Will update the binding accordingly. > > > > Best regards, > > Krzysztof Thank you. Regards, Pritam
© 2016 - 2025 Red Hat, Inc.