[v1] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies

[PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies

Posted by Pushpendra Singh 3 months, 1 week ago

Cc: kernel@quicinc.com, kernel@oss.qualcomm.com

The SC7280 SoC now supports two additional frequencies. This patch
add those frequencies to the BWMON OPP table and updates the frequency
mapping table accordingly.

These changes do not impact existing platforms, as the updated mapping
only affects the highest OPP. On any given platform, this will continue
to vote for the maximum available OPP.

Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 64a2abd30100..cb945abf0475 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -620,12 +620,12 @@ cpu4_opp_2208mhz: opp-2208000000 {
 
 		cpu4_opp_2400mhz: opp-2400000000 {
 			opp-hz = /bits/ 64 <2400000000>;
-			opp-peak-kBps = <8532000 48537600>;
+			opp-peak-kBps = <12787200 48537600>;
 		};
 
 		cpu4_opp_2611mhz: opp-2611200000 {
 			opp-hz = /bits/ 64 <2611200000>;
-			opp-peak-kBps = <8532000 48537600>;
+			opp-peak-kBps = <12787200 48537600>;
 		};
 	};
 
@@ -685,22 +685,22 @@ cpu7_opp_2381mhz: opp-2380800000 {
 
 		cpu7_opp_2400mhz: opp-2400000000 {
 			opp-hz = /bits/ 64 <2400000000>;
-			opp-peak-kBps = <8532000 48537600>;
+			opp-peak-kBps = <12787200 48537600>;
 		};
 
 		cpu7_opp_2515mhz: opp-2515200000 {
 			opp-hz = /bits/ 64 <2515200000>;
-			opp-peak-kBps = <8532000 48537600>;
+			opp-peak-kBps = <12787200 48537600>;
 		};
 
 		cpu7_opp_2707mhz: opp-2707200000 {
 			opp-hz = /bits/ 64 <2707200000>;
-			opp-peak-kBps = <8532000 48537600>;
+			opp-peak-kBps = <12787200 48537600>;
 		};
 
 		cpu7_opp_3014mhz: opp-3014400000 {
 			opp-hz = /bits/ 64 <3014400000>;
-			opp-peak-kBps = <8532000 48537600>;
+			opp-peak-kBps = <12787200 48537600>;
 		};
 	};
 
@@ -4013,6 +4013,12 @@ opp-6 {
 				opp-7 {
 					opp-peak-kBps = <8532000>;
 				};
+				opp-8 {
+					opp-peak-kBps = <10944000>;
+				};
+				opp-9 {
+					opp-peak-kBps = <12787200>;
+				};
 			};
 		};
 
-- 
2.34.1

Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies

Posted by Trilok Soni 3 months, 1 week ago

On 7/1/2025 12:43 AM, Pushpendra Singh wrote:
> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
> 
> The SC7280 SoC now supports two additional frequencies. This patch
> add those frequencies to the BWMON OPP table and updates the frequency
> mapping table accordingly.
> 
> These changes do not impact existing platforms, as the updated mapping
> only affects the highest OPP. On any given platform, this will continue
> to vote for the maximum available OPP.
> 
> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5

Why Change-Id? 

> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 64a2abd30100..cb945abf0475 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -620,12 +620,12 @@ cpu4_opp_2208mhz: opp-2208000000 {
>  
>  		cpu4_opp_2400mhz: opp-2400000000 {
>  			opp-hz = /bits/ 64 <2400000000>;
> -			opp-peak-kBps = <8532000 48537600>;
> +			opp-peak-kBps = <12787200 48537600>;
>  		};
>  
>  		cpu4_opp_2611mhz: opp-2611200000 {
>  			opp-hz = /bits/ 64 <2611200000>;
> -			opp-peak-kBps = <8532000 48537600>;
> +			opp-peak-kBps = <12787200 48537600>;
>  		};
>  	};
>  
> @@ -685,22 +685,22 @@ cpu7_opp_2381mhz: opp-2380800000 {
>  
>  		cpu7_opp_2400mhz: opp-2400000000 {
>  			opp-hz = /bits/ 64 <2400000000>;
> -			opp-peak-kBps = <8532000 48537600>;
> +			opp-peak-kBps = <12787200 48537600>;
>  		};
>  
>  		cpu7_opp_2515mhz: opp-2515200000 {
>  			opp-hz = /bits/ 64 <2515200000>;
> -			opp-peak-kBps = <8532000 48537600>;
> +			opp-peak-kBps = <12787200 48537600>;
>  		};
>  
>  		cpu7_opp_2707mhz: opp-2707200000 {
>  			opp-hz = /bits/ 64 <2707200000>;
> -			opp-peak-kBps = <8532000 48537600>;
> +			opp-peak-kBps = <12787200 48537600>;
>  		};
>  
>  		cpu7_opp_3014mhz: opp-3014400000 {
>  			opp-hz = /bits/ 64 <3014400000>;
> -			opp-peak-kBps = <8532000 48537600>;
> +			opp-peak-kBps = <12787200 48537600>;
>  		};
>  	};
>  
> @@ -4013,6 +4013,12 @@ opp-6 {
>  				opp-7 {
>  					opp-peak-kBps = <8532000>;
>  				};
> +				opp-8 {
> +					opp-peak-kBps = <10944000>;
> +				};
> +				opp-9 {
> +					opp-peak-kBps = <12787200>;
> +				};
>  			};
>  		};
>  


-- 
---Trilok Soni

Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies

Posted by Pushpendra Singh 3 months, 1 week ago

On 7/1/2025 11:43 PM, Trilok Soni wrote:
> On 7/1/2025 12:43 AM, Pushpendra Singh wrote:
>> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
>>
>> The SC7280 SoC now supports two additional frequencies. This patch
>> add those frequencies to the BWMON OPP table and updates the frequency
>> mapping table accordingly.
>>
>> These changes do not impact existing platforms, as the updated mapping
>> only affects the highest OPP. On any given platform, this will continue
>> to vote for the maximum available OPP.
>>
>> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
> 
> Why Change-Id? 

CC is a typo and fixed the Change-id in V2.

>> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 18 ++++++++++++------
>>  1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 64a2abd30100..cb945abf0475 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -620,12 +620,12 @@ cpu4_opp_2208mhz: opp-2208000000 {
>>  
>>  		cpu4_opp_2400mhz: opp-2400000000 {
>>  			opp-hz = /bits/ 64 <2400000000>;
>> -			opp-peak-kBps = <8532000 48537600>;
>> +			opp-peak-kBps = <12787200 48537600>;
>>  		};
>>  
>>  		cpu4_opp_2611mhz: opp-2611200000 {
>>  			opp-hz = /bits/ 64 <2611200000>;
>> -			opp-peak-kBps = <8532000 48537600>;
>> +			opp-peak-kBps = <12787200 48537600>;
>>  		};
>>  	};
>>  
>> @@ -685,22 +685,22 @@ cpu7_opp_2381mhz: opp-2380800000 {
>>  
>>  		cpu7_opp_2400mhz: opp-2400000000 {
>>  			opp-hz = /bits/ 64 <2400000000>;
>> -			opp-peak-kBps = <8532000 48537600>;
>> +			opp-peak-kBps = <12787200 48537600>;
>>  		};
>>  
>>  		cpu7_opp_2515mhz: opp-2515200000 {
>>  			opp-hz = /bits/ 64 <2515200000>;
>> -			opp-peak-kBps = <8532000 48537600>;
>> +			opp-peak-kBps = <12787200 48537600>;
>>  		};
>>  
>>  		cpu7_opp_2707mhz: opp-2707200000 {
>>  			opp-hz = /bits/ 64 <2707200000>;
>> -			opp-peak-kBps = <8532000 48537600>;
>> +			opp-peak-kBps = <12787200 48537600>;
>>  		};
>>  
>>  		cpu7_opp_3014mhz: opp-3014400000 {
>>  			opp-hz = /bits/ 64 <3014400000>;
>> -			opp-peak-kBps = <8532000 48537600>;
>> +			opp-peak-kBps = <12787200 48537600>;
>>  		};
>>  	};
>>  
>> @@ -4013,6 +4013,12 @@ opp-6 {
>>  				opp-7 {
>>  					opp-peak-kBps = <8532000>;
>>  				};
>> +				opp-8 {
>> +					opp-peak-kBps = <10944000>;
>> +				};
>> +				opp-9 {
>> +					opp-peak-kBps = <12787200>;
>> +				};
>>  			};
>>  		};
>>  
> 
>

Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies

Posted by Krzysztof Kozlowski 3 months, 1 week ago

On 01/07/2025 09:43, Pushpendra Singh wrote:
> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
> 
> The SC7280 SoC now supports two additional frequencies. This patch
> add those frequencies to the BWMON OPP table and updates the frequency
> mapping table accordingly.
> 
> These changes do not impact existing platforms, as the updated mapping
> only affects the highest OPP. On any given platform, this will continue
> to vote for the maximum available OPP.
> 
> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>

Doesn't your internal guideline tell you to run checkpatch before sending?

Also it mentions many other things, so read entire guideline prior to
posting.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies

Posted by Pushpendra Singh 3 months ago

On 7/1/2025 1:26 PM, Krzysztof Kozlowski wrote:
> On 01/07/2025 09:43, Pushpendra Singh wrote:
>> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
>>
>> The SC7280 SoC now supports two additional frequencies. This patch
>> add those frequencies to the BWMON OPP table and updates the frequency
>> mapping table accordingly.
>>
>> These changes do not impact existing platforms, as the updated mapping
>> only affects the highest OPP. On any given platform, this will continue
>> to vote for the maximum available OPP.
>>
>> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
>> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
> 
> Doesn't your internal guideline tell you to run checkpatch before sending?
> 
> Also it mentions many other things, so read entire guideline prior to
> posting.
> 

You're absolutely right, I should have run checkpatch before submitting. I appreciate you pointing that out. I've reviewed the internal guidelines more thoroughly now and will make sure to follow them closely in future submissions. Also, the issues are addressed in v2.

Thanks,
Pushpendra 

> Best regards,
> Krzysztof