dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example

[PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example

Posted by Krzysztof Kozlowski 7 months, 1 week ago

Examples should be complete and should not have a 'status' property,
especially a disabled one because this disables the dt_binding_check of
the example against the schema.  Dropping 'status' property shows
missing other properties - phy-mode and phy-handle.

Fixes: 114508a89ddc ("dt-bindings: net: Add support for Sophgo SG2044 dwmac")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
index 4dd2dc9c678b..8afbd9ebd73f 100644
--- a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
@@ -80,6 +80,8 @@ examples:
       interrupt-parent = <&intc>;
       interrupts = <296 IRQ_TYPE_LEVEL_HIGH>;
       interrupt-names = "macirq";
+      phy-handle = <&phy0>;
+      phy-mode = "rgmii-id";
       resets = <&rst 30>;
       reset-names = "stmmaceth";
       snps,multicast-filter-bins = <0>;
@@ -91,7 +93,6 @@ examples:
       snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
       snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
       snps,axi-config = <&gmac0_stmmac_axi_setup>;
-      status = "disabled";
 
       gmac0_mtl_rx_setup: rx-queues-config {
         snps,rx-queues-to-use = <8>;
-- 
2.43.0

Re: [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example

Posted by Alexander Sverdlin 7 months, 1 week ago

On Tue, 2025-07-01 at 08:36 +0200, Krzysztof Kozlowski wrote:
> Examples should be complete and should not have a 'status' property,
> especially a disabled one because this disables the dt_binding_check of
> the example against the schema.  Dropping 'status' property shows
> missing other properties - phy-mode and phy-handle.
> 
> Fixes: 114508a89ddc ("dt-bindings: net: Add support for Sophgo SG2044 dwmac")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

> ---
>  Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> index 4dd2dc9c678b..8afbd9ebd73f 100644
> --- a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> @@ -80,6 +80,8 @@ examples:
>        interrupt-parent = <&intc>;
>        interrupts = <296 IRQ_TYPE_LEVEL_HIGH>;
>        interrupt-names = "macirq";
> +      phy-handle = <&phy0>;
> +      phy-mode = "rgmii-id";
>        resets = <&rst 30>;
>        reset-names = "stmmaceth";
>        snps,multicast-filter-bins = <0>;
> @@ -91,7 +93,6 @@ examples:
>        snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
>        snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
>        snps,axi-config = <&gmac0_stmmac_axi_setup>;
> -      status = "disabled";
>  
>        gmac0_mtl_rx_setup: rx-queues-config {
>          snps,rx-queues-to-use = <8>;

-- 
Alexander Sverdlin.