selftests/sched_ext: Fix exit selftest hang on UP

[PATCH] selftests/sched_ext: Fix exit selftest hang on UP

Posted by Andrea Righi 3 months, 1 week ago

On single-CPU systems, ops.select_cpu() is never called, causing the
EXIT_SELECT_CPU test case to wait indefinitely.

Avoid the stall by skipping this specific sub-test when only one CPU is
available.

Reported-by: Phil Auld <pauld@redhat.com>
Fixes: a5db7817af780 ("sched_ext: Add selftests")
Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
 tools/testing/selftests/sched_ext/exit.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/testing/selftests/sched_ext/exit.c b/tools/testing/selftests/sched_ext/exit.c
index 9451782689de1..ee25824b1cbe6 100644
--- a/tools/testing/selftests/sched_ext/exit.c
+++ b/tools/testing/selftests/sched_ext/exit.c
@@ -22,6 +22,14 @@ static enum scx_test_status run(void *ctx)
 		struct bpf_link *link;
 		char buf[16];
 
+		/*
+		 * On single-CPU systems, ops.select_cpu() is never
+		 * invoked, so skip this test to avoid getting stuck
+		 * indefinitely.
+		 */
+		if (tc == EXIT_SELECT_CPU && libbpf_num_possible_cpus() == 1)
+			continue;
+
 		skel = exit__open();
 		SCX_ENUM_INIT(skel);
 		skel->rodata->exit_point = tc;
-- 
2.50.0

Re: [PATCH] selftests/sched_ext: Fix exit selftest hang on UP

Posted by Tejun Heo 3 months ago

On Tue, Jul 01, 2025 at 08:08:45AM +0200, Andrea Righi wrote:
> On single-CPU systems, ops.select_cpu() is never called, causing the
> EXIT_SELECT_CPU test case to wait indefinitely.
> 
> Avoid the stall by skipping this specific sub-test when only one CPU is
> available.
> 
> Reported-by: Phil Auld <pauld@redhat.com>
> Fixes: a5db7817af780 ("sched_ext: Add selftests")
> Signed-off-by: Andrea Righi <arighi@nvidia.com>

Applied to sched_ext/for-6.16-fixes.

Thanks.

-- 
tejun

Re: [PATCH] selftests/sched_ext: Fix exit selftest hang on UP

Posted by Phil Auld 3 months, 1 week ago

On Tue, Jul 01, 2025 at 08:08:45AM +0200 Andrea Righi wrote:
> On single-CPU systems, ops.select_cpu() is never called, causing the
> EXIT_SELECT_CPU test case to wait indefinitely.
> 
> Avoid the stall by skipping this specific sub-test when only one CPU is
> available.
> 
> Reported-by: Phil Auld <pauld@redhat.com>
> Fixes: a5db7817af780 ("sched_ext: Add selftests")
> Signed-off-by: Andrea Righi <arighi@nvidia.com>


Thanks Andrea! You beat me to it. I didn't know that libbpf
call existed :)

Reviewed-by: Phil Auld <pauld@redhat.com>

and

Tested-by: Phil Auld <pauld@redhat.com>


Cheers,
Phil

> ---
>  tools/testing/selftests/sched_ext/exit.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/sched_ext/exit.c b/tools/testing/selftests/sched_ext/exit.c
> index 9451782689de1..ee25824b1cbe6 100644
> --- a/tools/testing/selftests/sched_ext/exit.c
> +++ b/tools/testing/selftests/sched_ext/exit.c
> @@ -22,6 +22,14 @@ static enum scx_test_status run(void *ctx)
>  		struct bpf_link *link;
>  		char buf[16];
>  
> +		/*
> +		 * On single-CPU systems, ops.select_cpu() is never
> +		 * invoked, so skip this test to avoid getting stuck
> +		 * indefinitely.
> +		 */
> +		if (tc == EXIT_SELECT_CPU && libbpf_num_possible_cpus() == 1)
> +			continue;
> +
>  		skel = exit__open();
>  		SCX_ENUM_INIT(skel);
>  		skel->rodata->exit_point = tc;
> -- 
> 2.50.0
> 

--