[PATCH] reset: brcmstb: Enable reset drivers for ARCH_BCM2835

Peter Robinson posted 1 patch 3 months, 1 week ago
There is a newer version of this series
drivers/reset/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] reset: brcmstb: Enable reset drivers for ARCH_BCM2835
Posted by Peter Robinson 3 months, 1 week ago
The BRCMSTB and BRCMSTB_RESCAL reset drivers are also
used in the BCM2712, AKA the RPi5. The RPi platforms
have typically used the ARCH_BCM2835, and the PCIe
support for this SoC can use this config which depends
on these drivers so enable building them when just that
arch option is enabled to ensure the platform works as
expected.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/reset/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index d85be5899da6a..43151d12f88c3 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -51,7 +51,7 @@ config RESET_BERLIN
 
 config RESET_BRCMSTB
 	tristate "Broadcom STB reset controller"
-	depends on ARCH_BRCMSTB || COMPILE_TEST
+	depends on ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST
 	default ARCH_BRCMSTB
 	help
 	  This enables the reset controller driver for Broadcom STB SoCs using
@@ -60,11 +60,11 @@ config RESET_BRCMSTB
 config RESET_BRCMSTB_RESCAL
 	tristate "Broadcom STB RESCAL reset controller"
 	depends on HAS_IOMEM
-	depends on ARCH_BRCMSTB || COMPILE_TEST
+	depends on ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST
 	default ARCH_BRCMSTB
 	help
 	  This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
-	  BCM7216.
+	  BCM7216 or the BCM2712.
 
 config RESET_EYEQ
 	bool "Mobileye EyeQ reset controller"
-- 
2.50.0
Re: [PATCH] reset: brcmstb: Enable reset drivers for ARCH_BCM2835
Posted by Florian Fainelli 3 months, 1 week ago
On 6/30/25 09:45, Peter Robinson wrote:
> The BRCMSTB and BRCMSTB_RESCAL reset drivers are also
> used in the BCM2712, AKA the RPi5. The RPi platforms
> have typically used the ARCH_BCM2835, and the PCIe
> support for this SoC can use this config which depends
> on these drivers so enable building them when just that
> arch option is enabled to ensure the platform works as
> expected.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

That makes sense, I would also update the default to expand to 
ARCH_BRCMSTB || ARCH_BCM2835
-- 
Florian
Re: [PATCH] reset: brcmstb: Enable reset drivers for ARCH_BCM2835
Posted by Peter Robinson 3 months, 1 week ago
On Mon, 30 Jun 2025 at 17:47, Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> On 6/30/25 09:45, Peter Robinson wrote:
> > The BRCMSTB and BRCMSTB_RESCAL reset drivers are also
> > used in the BCM2712, AKA the RPi5. The RPi platforms
> > have typically used the ARCH_BCM2835, and the PCIe
> > support for this SoC can use this config which depends
> > on these drivers so enable building them when just that
> > arch option is enabled to ensure the platform works as
> > expected.
> >
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>
> That makes sense, I would also update the default to expand to
> ARCH_BRCMSTB || ARCH_BCM2835

Will do, I erred there a little, but I agree.