hwmon: (pmbus) Add support for MPS mp2869a/mp29612a controllers

[PATCH v2 0/2] hwmon: (pmbus) Add support for MPS mp2869a/mp29612a controllers

Posted by tzuhao.wtmh@gmail.com 3 months ago

From: Henry Wu <Henry_Wu@quantatw.com>

Add support for the mp2869a and mp29612a controllers from Monolithic Power
Systems, Inc. (MPS). These are dual-loop, digital, multi-phase modulation
controllers.

---

Changes in v2:
- Fix coding style issues.
- Using the pointer to replace the memcpy.
- Fix wrong device tree entries.

Link to v1: https://lore.kernel.org/lkml/20250624074156.291176-1-Henry_Wu@quantatw.tw/

---

Henry Wu (2):
  hwmon: (pmbus) Add support for MPS multi-phase mp2869a/mp29612a
    controllers
  dt-bindings: trivial-devices: Add mp2869a/mp29612a device entry

 .../devicetree/bindings/trivial-devices.yaml  |   4 +
 Documentation/hwmon/index.rst                 |   1 +
 Documentation/hwmon/mp2869a.rst               |  86 +++++
 drivers/hwmon/pmbus/Kconfig                   |  10 +
 drivers/hwmon/pmbus/Makefile                  |   1 +
 drivers/hwmon/pmbus/mp2869a.c                 | 299 ++++++++++++++++++
 6 files changed, 401 insertions(+)
 create mode 100644 Documentation/hwmon/mp2869a.rst
 create mode 100644 drivers/hwmon/pmbus/mp2869a.c

-- 
2.43.0

Re: [PATCH v2 0/2] hwmon: (pmbus) Add support for MPS mp2869a/mp29612a controllers

Posted by Krzysztof Kozlowski 3 months ago

On 30/06/2025 13:20, tzuhao.wtmh@gmail.com wrote:
> From: Henry Wu <Henry_Wu@quantatw.com>
> 
> Add support for the mp2869a and mp29612a controllers from Monolithic Power
> Systems, Inc. (MPS). These are dual-loop, digital, multi-phase modulation
> controllers.
> 
> ---
> 
> Changes in v2:
> - Fix coding style issues.

Which ones? How?

> - Using the pointer to replace the memcpy.
> - Fix wrong device tree entries.

What exactly? How did you fix it? I see zero changes. Your changelog
should be specific, not vague.


Best regards,
Krzysztof

Re: [PATCH v2 0/2] hwmon: (pmbus) Add support for MPS mp2869a/mp29612a controllers

Posted by Henry Wu 3 months ago

Krzysztof Kozlowski <krzk@kernel.org> 於 2025年6月30日 週一 下午7:29寫道：
>
> On 30/06/2025 13:20, tzuhao.wtmh@gmail.com wrote:
> > From: Henry Wu <Henry_Wu@quantatw.com>
> >
> > Add support for the mp2869a and mp29612a controllers from Monolithic Power
> > Systems, Inc. (MPS). These are dual-loop, digital, multi-phase modulation
> > controllers.
> >
> > ---
> >
> > Changes in v2:
> > - Fix coding style issues.
>
> Which ones? How?

I used checkpatch.pl with the "--strict" option and made the following
adjustments:
- Removed illegal spaces
- Converted comments to block style using /** ... */ instead of //
- Applied lowercase formatting to function names
Would you like me to list all the changes here, or should I include
them in the next patch?

>
> > - Using the pointer to replace the memcpy.
> > - Fix wrong device tree entries.
>
> What exactly? How did you fix it? I see zero changes. Your changelog
> should be specific, not vague.
In patch v1, I placed the mp2869a entry in the wrong order in
trivial-devices.yaml. In patch v2, I reordered it based on the
numerical order in the device name
>
>
> Best regards,
> Krzysztof

Best regards,
Henry Wu