From: Manikandan K Pillai <mpillai@cadence.com>

Document the compatible property for HPA (High Performance Architecture)
PCIe controller EP configuration.

Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>
---
 .../devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml          | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
index 8735293962ee..c3f0a620f1c2 100644
--- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
@@ -7,14 +7,16 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Cadence PCIe EP Controller
 
 maintainers:
-  - Tom Joseph <tjoseph@cadence.com>
+  - Manikandan K Pillai <mpillai@cadence.com>
 
 allOf:
   - $ref: cdns-pcie-ep.yaml#
 
 properties:
   compatible:
-    const: cdns,cdns-pcie-ep
+    enum:
+      - cdns,cdns-pcie-ep
+      - cdns,cdns-pcie-hpa-ep
 
   reg:
     maxItems: 2
-- 
2.49.0

On Mon, Jun 30, 2025 at 12:15:49PM +0800, hans.zhang@cixtech.com wrote:
> From: Manikandan K Pillai <mpillai@cadence.com>
> 
> Document the compatible property for HPA (High Performance Architecture)
> PCIe controller EP configuration.

That's the same patch which we already commented on. :/

> 
> Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>
> ---
>  .../devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml          | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> index 8735293962ee..c3f0a620f1c2 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> @@ -7,14 +7,16 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  title: Cadence PCIe EP Controller
>  
>  maintainers:
> -  - Tom Joseph <tjoseph@cadence.com>
> +  - Manikandan K Pillai <mpillai@cadence.com>

This is not explained in commit msg. You need to say WHY you are doing
such changes.

Best regards,
Krzysztof

On Mon, Jun 30, 2025 at 12:15:49PM +0800, hans.zhang@cixtech.com wrote:
> From: Manikandan K Pillai <mpillai@cadence.com>
> 
> Document the compatible property for HPA (High Performance Architecture)
> PCIe controller EP configuration.
> 
> Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>

Missing SoB.

Why are you sending someone else's patches? This just duplicates the
review and creates confusion.

Did you address ENTIRE previous review when you resent this?

Best regards,
Krzysztof

On 2025/6/30 15:27, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On Mon, Jun 30, 2025 at 12:15:49PM +0800, hans.zhang@cixtech.com wrote:
>> From: Manikandan K Pillai <mpillai@cadence.com>
>>
>> Document the compatible property for HPA (High Performance Architecture)
>> PCIe controller EP configuration.
>>
>> Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>
> 
> Missing SoB.
> 


Dear Krzysztof,

Thank you very much for your reply. Sorry, I missed it. Will add:
Signed-off-by: Hans Zhang <hans.zhang@cixtech.com>



> Why are you sending someone else's patches? This just duplicates the
> review and creates confusion.
> 
> Did you address ENTIRE previous review when you resent this?
> 

Previously, due to the Manikandan environment issue, the entire series 
of patches couldn't be sent. Now it is Manikandan who sends the patch to 
me by email, not by git send email. Then I will send out the patches of 
Manikandan together with those of Cix Sky1.

The following is the previous communication record:
https://lore.kernel.org/linux-pci/4bcc07b1-00ce-4ff9-bf23-e06b78950026@cixtech.com/

https://lore.kernel.org/linux-pci/d275cfe1-db7e-47d6-9ec6-b36f13524d65@kernel.org/


Regarding the opinions you mentioned that some Maintainers' issues were 
not resolved before, please reply from Manikandan here.

Best regards,
Hans

> Best regards,
> Krzysztof
>