[v5] Enhance the PCIe controller driver

[PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for new RP configuration

Posted by hans.zhang@cixtech.com 3 months, 1 week ago

From: Manikandan K Pillai <mpillai@cadence.com>

Document the compatible property for HPA (High Performance Architecture)
PCIe controller RP configuration.

Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>
---
 .../devicetree/bindings/pci/cdns,cdns-pcie-host.yaml        | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
index a8190d9b100f..83a33c4c008f 100644
--- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
+++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
@@ -7,14 +7,16 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Cadence PCIe host controller
 
 maintainers:
-  - Tom Joseph <tjoseph@cadence.com>
+  - Manikandan K Pillai <mpillai@cadence.com>
 
 allOf:
   - $ref: cdns-pcie-host.yaml#
 
 properties:
   compatible:
-    const: cdns,cdns-pcie-host
+    enum:
+      - cdns,cdns-pcie-host
+      - cdns,cdns-pcie-hpa-host
 
   reg:
     maxItems: 2
-- 
2.49.0

Re: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for new RP configuration

Posted by Krzysztof Kozlowski 3 months, 1 week ago

On Mon, Jun 30, 2025 at 12:15:48PM +0800, hans.zhang@cixtech.com wrote:
> From: Manikandan K Pillai <mpillai@cadence.com>
> 
> Document the compatible property for HPA (High Performance Architecture)
> PCIe controller RP configuration.

I don't see Conor's comment addressed:

https://lore.kernel.org/linux-devicetree/20250424-elm-magma-b791798477ab@spud/

You cannot just send someone's work and bypassing the review feedback.

> 
> Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>

SoB.

Best regards,
Krzysztof

Re: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for new RP configuration

Posted by Hans Zhang 3 months, 1 week ago


On 2025/6/30 15:30, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On Mon, Jun 30, 2025 at 12:15:48PM +0800, hans.zhang@cixtech.com wrote:
>> From: Manikandan K Pillai <mpillai@cadence.com>
>>
>> Document the compatible property for HPA (High Performance Architecture)
>> PCIe controller RP configuration.
> 
> I don't see Conor's comment addressed:
> 
> https://lore.kernel.org/linux-devicetree/20250424-elm-magma-b791798477ab@spud/
> 
> You cannot just send someone's work and bypassing the review feedback.
> 
>>
>> Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>
> 
> SoB.

Dear Krzysztof,

Thank you very much for your reply. The questions mentioned above, 
please answer by Manikandan.

Sorry, I missed it. Will add:
Signed-off-by: Hans Zhang <hans.zhang@cixtech.com>

Best regards,
Hans

> 
> Best regards,
> Krzysztof
>