[v2] media: i2c: imx214: Add some style improvements

[PATCH v2 0/5] media: i2c: imx214: Add some style improvements

Posted by André Apitzsch via B4 Relay 3 months, 1 week ago

The following changes have be suggested by Laurent in [1]. But the
related series had already be applied. That's why they are addressed in
this series.

[1] https://lore.kernel.org/linux-media/20250621181751.GA9125@pendragon.ideasonboard.com/

Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
Changes in v2:
- Drop unnecessary sentence from commit message (patch 3/5)
- Fix typo in summary (patch 5/5)
- Use imperative mood for commit message (patch 5/5)
- Add R-b tags
- Link to v1: https://lore.kernel.org/r/20250629-imx214_fixes-v1-0-873eb94ad635@apitzsch.eu

---
André Apitzsch (5):
      media: i2c: imx214: Remove unneeded parentheses
      media: i2c: imx214: Drop dev argument from imx214_parse_fwnode()
      media: i2c: imx214: Use __free(fwnode_handle)
      media: i2c: imx214: Move imx214_pll_update to imx214_ctrls_init
      media: i2c: imx214: Separate legacy link frequency check from PLL calculation

 drivers/media/i2c/imx214.c | 245 ++++++++++++++++++++++-----------------------
 1 file changed, 121 insertions(+), 124 deletions(-)
---
base-commit: 5e2562c1e46d3623fbdef77693f374eade075840
change-id: 20250623-imx214_fixes-123f285f5b62

Best regards,
-- 
André Apitzsch <git@apitzsch.eu>

Re: [v2 0/5] media: i2c: imx214: Add some style improvements

Posted by Markus Elfring 3 months, 1 week ago

…> ---
> Changes in v2:
…
> - Use imperative mood for commit message (patch …)
…

Will this review concern become relevant for further update steps?

Regards,
Markus

Re: [PATCH v2 0/5] media: i2c: imx214: Add some style improvements

Posted by André Apitzsch 1 month, 4 weeks ago

Am Montag, dem 30.06.2025 um 21:05 +0200 schrieb André Apitzsch via B4
Relay:
> The following changes have be suggested by Laurent in [1]. But the
> related series had already be applied. That's why they are addressed
> in this series.
> 
> [1]
> https://lore.kernel.org/linux-media/20250621181751.GA9125@pendragon.ideasonboard.com/
> 
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> Changes in v2:
> - Drop unnecessary sentence from commit message (patch 3/5)
> - Fix typo in summary (patch 5/5)
> - Use imperative mood for commit message (patch 5/5)
> - Add R-b tags
> - Link to v1:
> https://lore.kernel.org/r/20250629-imx214_fixes-v1-0-873eb94ad635@apitzsch.eu
> 
> ---
> André Apitzsch (5):
>       media: i2c: imx214: Remove unneeded parentheses
>       media: i2c: imx214: Drop dev argument from
> imx214_parse_fwnode()
>       media: i2c: imx214: Use __free(fwnode_handle)
>       media: i2c: imx214: Move imx214_pll_update to imx214_ctrls_init
>       media: i2c: imx214: Separate legacy link frequency check from
> PLL calculation
> 
>  drivers/media/i2c/imx214.c | 245 ++++++++++++++++++++++-------------
> ----------
>  1 file changed, 121 insertions(+), 124 deletions(-)
> ---
> base-commit: 5e2562c1e46d3623fbdef77693f374eade075840
> change-id: 20250623-imx214_fixes-123f285f5b62
> 
> Best regards,

Hi Sakari,

kind reminder, that this series is still pending.

Is there anything left to do from my side?

Best regards,
André

Re: [PATCH v2 0/5] media: i2c: imx214: Add some style improvements

Posted by Sakari Ailus 1 month, 3 weeks ago

Hi André,

On Sun, Aug 10, 2025 at 11:48:14PM +0200, André Apitzsch wrote:
> Am Montag, dem 30.06.2025 um 21:05 +0200 schrieb André Apitzsch via B4
> Relay:
> > The following changes have be suggested by Laurent in [1]. But the
> > related series had already be applied. That's why they are addressed
> > in this series.
> > 
> > [1]
> > https://lore.kernel.org/linux-media/20250621181751.GA9125@pendragon.ideasonboard.com/
> > 
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > ---
> > Changes in v2:
> > - Drop unnecessary sentence from commit message (patch 3/5)
> > - Fix typo in summary (patch 5/5)
> > - Use imperative mood for commit message (patch 5/5)
> > - Add R-b tags
> > - Link to v1:
> > https://lore.kernel.org/r/20250629-imx214_fixes-v1-0-873eb94ad635@apitzsch.eu
> > 
> > ---
> > André Apitzsch (5):
> >       media: i2c: imx214: Remove unneeded parentheses
> >       media: i2c: imx214: Drop dev argument from
> > imx214_parse_fwnode()
> >       media: i2c: imx214: Use __free(fwnode_handle)
> >       media: i2c: imx214: Move imx214_pll_update to imx214_ctrls_init
> >       media: i2c: imx214: Separate legacy link frequency check from
> > PLL calculation
> > 
> >  drivers/media/i2c/imx214.c | 245 ++++++++++++++++++++++-------------
> > ----------
> >  1 file changed, 121 insertions(+), 124 deletions(-)
> > ---
> > base-commit: 5e2562c1e46d3623fbdef77693f374eade075840
> > change-id: 20250623-imx214_fixes-123f285f5b62
> > 
> > Best regards,
> 
> Hi Sakari,
> 
> kind reminder, that this series is still pending.
> 
> Is there anything left to do from my side?

Thanks for the ping. The patches are now in my tree.

-- 
Regards,

Sakari Ailus