From: Cyril Chao <Cyril.Chao@mediatek.com>
Add document for mt8189 board with nau8825.
Signed-off-by: Cyril Chao <Cyril.Chao@mediatek.com>
---
.../sound/mediatek,mt8189-nau8825.yaml | 103 ++++++++++++++++++
1 file changed, 103 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml
new file mode 100644
index 000000000..331c537d3
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml
@@ -0,0 +1,103 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mediatek,mt8189-nau8825.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT8189 ASoC sound card
+
+maintainers:
+ - Darren Ye <darren.ye@mediatek.com>
+ - Cyril Chao <cyril.chao@mediatek.com>
+
+allOf:
+ - $ref: sound-card-common.yaml#
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8189-nau8825-sound
+ - mediatek,mt8189-rt5650-sound
+ - mediatek,mt8189-rt5682s-sound
+ - mediatek,mt8189-rt5682i-sound
+
+ mediatek,platform:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: The phandle of MT8189 ASoC platform.
+
+patternProperties:
+ "^dai-link-[0-9]+$":
+ type: object
+ description:
+ Container for dai-link level properties and CODEC sub-nodes.
+
+ properties:
+ link-name:
+ description:
+ This property corresponds to the name of the BE dai-link to which
+ we are going to update parameters in this node.
+ items:
+ enum:
+ - TDM_DPTX_BE
+ - I2SOUT0_BE
+ - I2SIN0_BE
+ - I2SOUT1_BE
+
+ codec:
+ description: Holds subnode which indicates codec dai.
+ type: object
+ additionalProperties: false
+ properties:
+ sound-dai:
+ minItems: 1
+ maxItems: 2
+ required:
+ - sound-dai
+
+ dai-format:
+ description: audio format.
+ items:
+ enum:
+ - i2s
+ - right_j
+ - left_j
+ - dsp_a
+ - dsp_b
+
+ mediatek,clk-provider:
+ $ref: /schemas/types.yaml#/definitions/string
+ description: Indicates dai-link clock master.
+ enum:
+ - cpu
+ - codec
+
+ additionalProperties: false
+
+ required:
+ - link-name
+
+required:
+ - compatible
+ - mediatek,platform
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ sound {
+ compatible = "mediatek,mt8189-nau8825-sound";
+ model = "mt8189_rt9123_8825";
+ mediatek,platform = <&afe>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&aud_pins_default>;
+ dai-link-0 {
+ link-name = "I2SOUT1_BE";
+ dai-format = "i2s";
+ mediatek,clk-provider = "cpu";
+ codec {
+ sound-dai = <&nau8825>;
+ };
+ };
+ };
+
+...
--
2.46.0On 28/06/2025 09:14, Cyril wrote: > From: Cyril Chao <Cyril.Chao@mediatek.com> > > Add document for mt8189 board with nau8825. > > Signed-off-by: Cyril Chao <Cyril.Chao@mediatek.com> Why does the binding come after user? Follow submitting patches in DT. > --- > .../sound/mediatek,mt8189-nau8825.yaml | 103 ++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml > new file mode 100644 > index 000000000..331c537d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8189-nau8825.yaml > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt8189-nau8825.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT8189 ASoC sound card > + > +maintainers: > + - Darren Ye <darren.ye@mediatek.com> > + - Cyril Chao <cyril.chao@mediatek.com> > + > +allOf: > + - $ref: sound-card-common.yaml# > + > +properties: > + compatible: > + enum: > + - mediatek,mt8189-nau8825-sound > + - mediatek,mt8189-rt5650-sound > + - mediatek,mt8189-rt5682s-sound > + - mediatek,mt8189-rt5682i-sound Sound is redundant. Can it be anything else? Best regards, Krzysztof
On Sat, 2025-06-28 at 14:42 +0200, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 28/06/2025 09:14, Cyril wrote: > > From: Cyril Chao <Cyril.Chao@mediatek.com> > > > > Add document for mt8189 board with nau8825. > > > > Signed-off-by: Cyril Chao <Cyril.Chao@mediatek.com> > > Why does the binding come after user? Follow submitting patches in > DT. > Could you help to clarify this? Is it the order in which I submitted the dt-binding patch that's incorrect? Much thanks~~ > > --- > > .../sound/mediatek,mt8189-nau8825.yaml | 103 > > ++++++++++++++++++ > > 1 file changed, 103 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/sound/mediatek,mt8189- > > nau8825.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/sound/mediatek,mt8189- > > nau8825.yaml > > b/Documentation/devicetree/bindings/sound/mediatek,mt8189- > > nau8825.yaml > > new file mode 100644 > > index 000000000..331c537d3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8189- > > nau8825.yaml > > @@ -0,0 +1,103 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt8189-nau8825.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BLVZS00w$ > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BzAjmYYE$ > > + > > +title: MediaTek MT8189 ASoC sound card > > + > > +maintainers: > > + - Darren Ye <darren.ye@mediatek.com> > > + - Cyril Chao <cyril.chao@mediatek.com> > > + > > +allOf: > > + - $ref: sound-card-common.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - mediatek,mt8189-nau8825-sound > > + - mediatek,mt8189-rt5650-sound > > + - mediatek,mt8189-rt5682s-sound > > + - mediatek,mt8189-rt5682i-sound > > Sound is redundant. Can it be anything else? > Okay, I will remove 'sound' next version, and like this: mediatek,mt8189-nau8825 mediatek,mt8189-rt5650 mediatek,mt8189-rt5682s mediatek,mt8189-rt5682i Thanks for review~~~ Best Regards Cyril Chao > > Best regards, > Krzysztof
On 18/07/2025 10:48, Cyril Chao (钞悦) wrote: > On Sat, 2025-06-28 at 14:42 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 28/06/2025 09:14, Cyril wrote: >>> From: Cyril Chao <Cyril.Chao@mediatek.com> >>> >>> Add document for mt8189 board with nau8825. >>> >>> Signed-off-by: Cyril Chao <Cyril.Chao@mediatek.com> >> >> Why does the binding come after user? Follow submitting patches in >> DT. >> > Could you help to clarify this? Is it the order in which I submitted > the dt-binding patch that's incorrect? Much thanks~~ Yes, it is incorrect. What does the mentioned doc say? I really hope you read the doc before you just responded to me.. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.