[v1] iio: adc: axp20x_adc: Add missing sentinel to AXP717 ADC channel maps

[PATCH] iio: adc: axp20x_adc: Add missing sentinel to AXP717 ADC channel maps

Posted by Chen-Yu Tsai 7 months, 2 weeks ago

From: Chen-Yu Tsai <wens@csie.org>

The AXP717 ADC channel maps is missing a sentinel entry at the end. This
causes a KASAN warning.

Add the missing sentinel entry.

Fixes: 5ba0cb92584b ("iio: adc: axp20x_adc: add support for AXP717 ADC")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/iio/adc/axp20x_adc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
index 71584ffd3632..1b49325ec1ce 100644
--- a/drivers/iio/adc/axp20x_adc.c
+++ b/drivers/iio/adc/axp20x_adc.c
@@ -187,6 +187,7 @@ static struct iio_map axp717_maps[] = {
 		.consumer_channel = "batt_chrg_i",
 		.adc_channel_label = "batt_chrg_i",
 	},
+	{ }
 };
 
 /*
-- 
2.39.5

Re: [PATCH] iio: adc: axp20x_adc: Add missing sentinel to AXP717 ADC channel maps

Posted by Jonathan Cameron 7 months, 2 weeks ago

On Sat, 28 Jun 2025 12:43:26 +0800
Chen-Yu Tsai <wens@kernel.org> wrote:

> From: Chen-Yu Tsai <wens@csie.org>
> 
> The AXP717 ADC channel maps is missing a sentinel entry at the end. This
> causes a KASAN warning.
> 
> Add the missing sentinel entry.
> 
> Fixes: 5ba0cb92584b ("iio: adc: axp20x_adc: add support for AXP717 ADC")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
I picked up the version you posted on 7th June.
I've been a bit slow to send a fixed pull request - sorry about that; busy
few weeks.

Jonathan


> ---
>  drivers/iio/adc/axp20x_adc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
> index 71584ffd3632..1b49325ec1ce 100644
> --- a/drivers/iio/adc/axp20x_adc.c
> +++ b/drivers/iio/adc/axp20x_adc.c
> @@ -187,6 +187,7 @@ static struct iio_map axp717_maps[] = {
>  		.consumer_channel = "batt_chrg_i",
>  		.adc_channel_label = "batt_chrg_i",
>  	},
> +	{ }
>  };
>  
>  /*

Re: [PATCH] iio: adc: axp20x_adc: Add missing sentinel to AXP717 ADC channel maps

Posted by Chen-Yu Tsai 7 months, 2 weeks ago

On Sat, Jun 28, 2025 at 10:51 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 28 Jun 2025 12:43:26 +0800
> Chen-Yu Tsai <wens@kernel.org> wrote:
>
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > The AXP717 ADC channel maps is missing a sentinel entry at the end. This
> > causes a KASAN warning.
> >
> > Add the missing sentinel entry.
> >
> > Fixes: 5ba0cb92584b ("iio: adc: axp20x_adc: add support for AXP717 ADC")
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> I picked up the version you posted on 7th June.
> I've been a bit slow to send a fixed pull request - sorry about that; busy
> few weeks.

Ah, sorry about that. I was looking through my work directory and trees,
didn't find a patch file and thought I hadn't sent it yet.

Good to know it's already queued up.

Thanks
ChenYu


> Jonathan
>
>
> > ---
> >  drivers/iio/adc/axp20x_adc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
> > index 71584ffd3632..1b49325ec1ce 100644
> > --- a/drivers/iio/adc/axp20x_adc.c
> > +++ b/drivers/iio/adc/axp20x_adc.c
> > @@ -187,6 +187,7 @@ static struct iio_map axp717_maps[] = {
> >               .consumer_channel = "batt_chrg_i",
> >               .adc_channel_label = "batt_chrg_i",
> >       },
> > +     { }
> >  };
> >
> >  /*
>