[v2] perf test: Add basic callgraph test to record testing

[PATCH v2] perf test: Add basic callgraph test to record testing

Posted by Ian Rogers 7 months, 2 weeks ago

Give some basic perf record callgraph coverage.

Signed-off-by: Ian Rogers <irogers@google.com>
---
v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
    Clark <james.clark@linaro.org>.
---
 tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 2022a4f739be..b1ad24fb3b33 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
 . "${shelldir}"/lib/perf_has_symbol.sh
 
 testsym="test_loop"
+testsym2="brstack"
 
 skip_test_missing_symbol ${testsym}
+skip_test_missing_symbol ${testsym2}
 
 err=0
 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
@@ -359,6 +361,33 @@ test_precise_max() {
   fi
 }
 
+test_callgraph() {
+  echo "Callgraph test"
+
+  case $(uname -m)
+  in s390x)
+       cmd_flags="--call-graph dwarf -e cpu-clock";;
+     *)
+       cmd_flags="-g";;
+  esac
+
+  if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
+  then
+    echo "Callgraph test [Failed missing output]"
+    err=1
+    return
+  fi
+
+  if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
+  then
+    echo "Callgraph test [Failed missing symbol]"
+    err=1
+    return
+  fi
+
+  echo "Callgraph test [Success]"
+}
+
 # raise the limit of file descriptors to minimum
 if [[ $default_fd_limit -lt $min_fd_limit ]]; then
        ulimit -Sn $min_fd_limit
@@ -374,6 +403,7 @@ test_uid
 test_leader_sampling
 test_topdown_leader_sampling
 test_precise_max
+test_callgraph
 
 # restore the default value
 ulimit -Sn $default_fd_limit
-- 
2.50.0.727.gbf7dc18ff4-goog

Re: [PATCH v2] perf test: Add basic callgraph test to record testing

Posted by Namhyung Kim 7 months, 1 week ago

On Fri, 27 Jun 2025 18:55:53 -0700, Ian Rogers wrote:
> Give some basic perf record callgraph coverage.
> 
> 
Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH v2] perf test: Add basic callgraph test to record testing

Posted by Thomas Richter 7 months, 1 week ago

On 6/28/25 03:55, Ian Rogers wrote:
> Give some basic perf record callgraph coverage.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
>     Clark <james.clark@linaro.org>.
> ---
>  tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 2022a4f739be..b1ad24fb3b33 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
>  . "${shelldir}"/lib/perf_has_symbol.sh
>  
>  testsym="test_loop"
> +testsym2="brstack"
>  
>  skip_test_missing_symbol ${testsym}
> +skip_test_missing_symbol ${testsym2}
>  
>  err=0
>  perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> @@ -359,6 +361,33 @@ test_precise_max() {
>    fi
>  }
>  
> +test_callgraph() {
> +  echo "Callgraph test"
> +
> +  case $(uname -m)
> +  in s390x)
> +       cmd_flags="--call-graph dwarf -e cpu-clock";;
> +     *)
> +       cmd_flags="-g";;
> +  esac
> +
> +  if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
> +  then
> +    echo "Callgraph test [Failed missing output]"
> +    err=1
> +    return
> +  fi
> +
> +  if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
> +  then
> +    echo "Callgraph test [Failed missing symbol]"
> +    err=1
> +    return
> +  fi
> +
> +  echo "Callgraph test [Success]"
> +}
> +
>  # raise the limit of file descriptors to minimum
>  if [[ $default_fd_limit -lt $min_fd_limit ]]; then
>         ulimit -Sn $min_fd_limit
> @@ -374,6 +403,7 @@ test_uid
>  test_leader_sampling
>  test_topdown_leader_sampling
>  test_precise_max
> +test_callgraph
>  
>  # restore the default value
>  ulimit -Sn $default_fd_limit

Works ok for s390

Tested-by: Thomas Richter <tmricht@linux.ibm.com>
-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH v2] perf test: Add basic callgraph test to record testing

Posted by James Clark 7 months, 1 week ago


On 30/06/2025 9:01 am, Thomas Richter wrote:
> On 6/28/25 03:55, Ian Rogers wrote:
>> Give some basic perf record callgraph coverage.
>>
>> Signed-off-by: Ian Rogers <irogers@google.com>
>> ---
>> v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
>>      Clark <james.clark@linaro.org>.
>> ---
>>   tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
>>
>> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
>> index 2022a4f739be..b1ad24fb3b33 100755
>> --- a/tools/perf/tests/shell/record.sh
>> +++ b/tools/perf/tests/shell/record.sh
>> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
>>   . "${shelldir}"/lib/perf_has_symbol.sh
>>   
>>   testsym="test_loop"
>> +testsym2="brstack"
>>   
>>   skip_test_missing_symbol ${testsym}
>> +skip_test_missing_symbol ${testsym2}
>>   
>>   err=0
>>   perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
>> @@ -359,6 +361,33 @@ test_precise_max() {
>>     fi
>>   }
>>   
>> +test_callgraph() {
>> +  echo "Callgraph test"
>> +
>> +  case $(uname -m)
>> +  in s390x)
>> +       cmd_flags="--call-graph dwarf -e cpu-clock";;
>> +     *)
>> +       cmd_flags="-g";;
>> +  esac
>> +
>> +  if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
>> +  then
>> +    echo "Callgraph test [Failed missing output]"
>> +    err=1
>> +    return
>> +  fi
>> +
>> +  if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
>> +  then
>> +    echo "Callgraph test [Failed missing symbol]"
>> +    err=1
>> +    return
>> +  fi
>> +
>> +  echo "Callgraph test [Success]"
>> +}
>> +
>>   # raise the limit of file descriptors to minimum
>>   if [[ $default_fd_limit -lt $min_fd_limit ]]; then
>>          ulimit -Sn $min_fd_limit
>> @@ -374,6 +403,7 @@ test_uid
>>   test_leader_sampling
>>   test_topdown_leader_sampling
>>   test_precise_max
>> +test_callgraph
>>   
>>   # restore the default value
>>   ulimit -Sn $default_fd_limit
> 
> Works ok for s390
> 
> Tested-by: Thomas Richter <tmricht@linux.ibm.com>

Reviewed-by: James Clark <james.clark@linaro.org>