[PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws

Kurt Borja posted 3 patches 3 months, 1 week ago
There is a newer version of this series
drivers/platform/x86/lenovo/think-lmi.c | 90 +++++++++++----------------------
1 file changed, 30 insertions(+), 60 deletions(-)
[PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws
Posted by Kurt Borja 3 months, 1 week ago
Hi all,

First patch is a prerequisite in order to avoid NULL pointer
dereferences in error paths. Then two fixes follow.

Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
Changes in v2:

[PATCH 02]
  - Remove kobject_del() and commit message remark. It turns out it's
    optional to call this (my bad)
  - Leave only one fixes tag. The other two are not necessary.

- Link to v1: https://lore.kernel.org/r/20250628-lmi-fix-v1-0-c6eec9aa3ca7@gmail.com

---
Kurt Borja (3):
      platform/x86: think-lmi: Create ksets consecutively
      platform/x86: think-lmi: Fix kobject cleanup
      platform/x86: think-lmi: Fix sysfs group cleanup

 drivers/platform/x86/lenovo/think-lmi.c | 90 +++++++++++----------------------
 1 file changed, 30 insertions(+), 60 deletions(-)
---
base-commit: 73f0f2b52c5ea67b3140b23f58d8079d158839c8
change-id: 20250628-lmi-fix-98143b10d9fd
-- 
 ~ Kurt
Re: [PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws
Posted by Ilpo Järvinen 3 months, 1 week ago
On Sat, 28 Jun 2025, Kurt Borja wrote:

> Hi all,
> 
> First patch is a prerequisite in order to avoid NULL pointer
> dereferences in error paths. Then two fixes follow.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Please send v3 with stable Cc tags in all these so that this dependency 
gets automatically handled (as per documentation).

I'll apply this through the fixes branch but I can deal with the removal 
of the lenovo/ folder from the file names myself while applying.

> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> Changes in v2:
> 
> [PATCH 02]
>   - Remove kobject_del() and commit message remark. It turns out it's
>     optional to call this (my bad)
>   - Leave only one fixes tag. The other two are not necessary.
> 
> - Link to v1: https://lore.kernel.org/r/20250628-lmi-fix-v1-0-c6eec9aa3ca7@gmail.com
> 
> ---
> Kurt Borja (3):
>       platform/x86: think-lmi: Create ksets consecutively
>       platform/x86: think-lmi: Fix kobject cleanup
>       platform/x86: think-lmi: Fix sysfs group cleanup
> 
>  drivers/platform/x86/lenovo/think-lmi.c | 90 +++++++++++----------------------
>  1 file changed, 30 insertions(+), 60 deletions(-)
> ---
> base-commit: 73f0f2b52c5ea67b3140b23f58d8079d158839c8
> change-id: 20250628-lmi-fix-98143b10d9fd
> 

-- 
 i.
Re: [PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws
Posted by Kurt Borja 3 months, 1 week ago
Hi Ilpo,

On Mon Jun 30, 2025 at 5:54 AM -03, Ilpo Järvinen wrote:
> On Sat, 28 Jun 2025, Kurt Borja wrote:
>
>> Hi all,
>> 
>> First patch is a prerequisite in order to avoid NULL pointer
>> dereferences in error paths. Then two fixes follow.
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thanks!

>
> Please send v3 with stable Cc tags in all these so that this dependency 
> gets automatically handled (as per documentation).

I forgot the stable tag in the dell-sysman fix too. Hopefully it gets
picked up by AUTOSEL. Else I'll submit it manually.

>
> I'll apply this through the fixes branch but I can deal with the removal 
> of the lenovo/ folder from the file names myself while applying.

It's easy to rebase too so I'll do it :)

>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>> Changes in v2:
>> 
>> [PATCH 02]
>>   - Remove kobject_del() and commit message remark. It turns out it's
>>     optional to call this (my bad)
>>   - Leave only one fixes tag. The other two are not necessary.
>> 
>> - Link to v1: https://lore.kernel.org/r/20250628-lmi-fix-v1-0-c6eec9aa3ca7@gmail.com
>> 
>> ---
>> Kurt Borja (3):
>>       platform/x86: think-lmi: Create ksets consecutively
>>       platform/x86: think-lmi: Fix kobject cleanup
>>       platform/x86: think-lmi: Fix sysfs group cleanup
>> 
>>  drivers/platform/x86/lenovo/think-lmi.c | 90 +++++++++++----------------------
>>  1 file changed, 30 insertions(+), 60 deletions(-)
>> ---
>> base-commit: 73f0f2b52c5ea67b3140b23f58d8079d158839c8
>> change-id: 20250628-lmi-fix-98143b10d9fd
>> 


-- 
 ~ Kurt