iio: adc: mp2629_adc: make mp2629_channels const

[PATCH] iio: adc: mp2629_adc: make mp2629_channels const

Posted by David Lechner 3 months, 1 week ago

Add const qualifier to struct iio_chan_spec mp2629_channels[]. This
is read-only data so it can be made const.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/iio/adc/mp2629_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/mp2629_adc.c b/drivers/iio/adc/mp2629_adc.c
index 1cb043b17437780970ce355f9d93fd36cbd26826..5a1d516f8dad8e2cf46a43e1a40d1cc7adaecc13 100644
--- a/drivers/iio/adc/mp2629_adc.c
+++ b/drivers/iio/adc/mp2629_adc.c
@@ -44,7 +44,7 @@ struct mp2629_adc {
 	struct device *dev;
 };
 
-static struct iio_chan_spec mp2629_channels[] = {
+static const struct iio_chan_spec mp2629_channels[] = {
 	MP2629_ADC_CHAN(BATT_VOLT, IIO_VOLTAGE),
 	MP2629_ADC_CHAN(SYSTEM_VOLT, IIO_VOLTAGE),
 	MP2629_ADC_CHAN(INPUT_VOLT, IIO_VOLTAGE),

---
base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
change-id: 20250628-iio-const-data-8-8c8921ee3b3f

Best regards,
-- 
David Lechner <dlechner@baylibre.com>

Re: [PATCH] iio: adc: mp2629_adc: make mp2629_channels const

Posted by Jonathan Cameron 3 months, 1 week ago

On Sat, 28 Jun 2025 11:31:02 -0500
David Lechner <dlechner@baylibre.com> wrote:

> Add const qualifier to struct iio_chan_spec mp2629_channels[]. This
> is read-only data so it can be made const.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Applied to the testing branch of iio.git.  If anyone has comments
there is still time before I push this out as the non rebasing togreg
branch.

Mostly I assume that if David and I miss somethiing on these the
compiler will scream either in my local tests of when 0-day hits the
testing tree tomorrow.

> ---
>  drivers/iio/adc/mp2629_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/mp2629_adc.c b/drivers/iio/adc/mp2629_adc.c
> index 1cb043b17437780970ce355f9d93fd36cbd26826..5a1d516f8dad8e2cf46a43e1a40d1cc7adaecc13 100644
> --- a/drivers/iio/adc/mp2629_adc.c
> +++ b/drivers/iio/adc/mp2629_adc.c
> @@ -44,7 +44,7 @@ struct mp2629_adc {
>  	struct device *dev;
>  };
>  
> -static struct iio_chan_spec mp2629_channels[] = {
> +static const struct iio_chan_spec mp2629_channels[] = {
>  	MP2629_ADC_CHAN(BATT_VOLT, IIO_VOLTAGE),
>  	MP2629_ADC_CHAN(SYSTEM_VOLT, IIO_VOLTAGE),
>  	MP2629_ADC_CHAN(INPUT_VOLT, IIO_VOLTAGE),
> 
> ---
> base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
> change-id: 20250628-iio-const-data-8-8c8921ee3b3f
> 
> Best regards,