iio: common: hid-sensor-attributes: make unit_conversion const

[PATCH] iio: common: hid-sensor-attributes: make unit_conversion const

Posted by David Lechner 3 months, 1 week ago

Add const qualifier to struct unit_conversion[]. This is read-only data
so it can be made const.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
index 2055a03cbeb187743e687c2ce3f8a339a2bd4cfc..a61428bfdce372ea0511fb7c3e80f4c43f427eb4 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
@@ -11,7 +11,7 @@
 #include <linux/hid-sensor-hub.h>
 #include <linux/iio/iio.h>
 
-static struct {
+static const struct {
 	u32 usage_id;
 	int unit; /* 0 for default others from HID sensor spec */
 	int scale_val0; /* scale, whole number */

---
base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
change-id: 20250628-iio-const-data-14-b3250e000af7

Best regards,
-- 
David Lechner <dlechner@baylibre.com>

Re: [PATCH] iio: common: hid-sensor-attributes: make unit_conversion const

Posted by Jonathan Cameron 3 months, 1 week ago

On Sat, 28 Jun 2025 12:09:26 -0500
David Lechner <dlechner@baylibre.com> wrote:

> Add const qualifier to struct unit_conversion[]. This is read-only data
> so it can be made const.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Applied as seems to be 'obviously correct'.

+CC rest of the hid-sensors maintainers. 


> ---
>  drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> index 2055a03cbeb187743e687c2ce3f8a339a2bd4cfc..a61428bfdce372ea0511fb7c3e80f4c43f427eb4 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> @@ -11,7 +11,7 @@
>  #include <linux/hid-sensor-hub.h>
>  #include <linux/iio/iio.h>
>  
> -static struct {
> +static const struct {
>  	u32 usage_id;
>  	int unit; /* 0 for default others from HID sensor spec */
>  	int scale_val0; /* scale, whole number */
> 
> ---
> base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
> change-id: 20250628-iio-const-data-14-b3250e000af7
> 
> Best regards,