[PATCH mm-unstable] mm/damon/sysfs-schemes: make damos_sysfs_action_names static

SeongJae Park posted 1 patch 3 months, 1 week ago
mm/damon/sysfs-schemes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH mm-unstable] mm/damon/sysfs-schemes: make damos_sysfs_action_names static
Posted by SeongJae Park 3 months, 1 week ago
Commit 6812c66db976 ("mm/damon/sysfs-schemes: decouple from
damos_action") in mm-unstable is defining damos_sysfs_action_names as
non-static, though it is being used only inside sysfs-schemes.c file.
Make it static.

Fixes: 6812c66db976 ("mm/damon/sysfs-schemes: decouple from damos_action") # mm-unstable
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506271655.b8yfEZIT-lkp@intel.com/

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/sysfs-schemes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index 5243b94cec24..601360e9b521 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -1679,7 +1679,7 @@ struct damos_sysfs_action_name {
 	char *name;
 };
 
-struct damos_sysfs_action_name damos_sysfs_action_names[] = {
+static struct damos_sysfs_action_name damos_sysfs_action_names[] = {
 	{
 		.action = DAMOS_WILLNEED,
 		.name = "willneed",

base-commit: 5de4c740b52ae67feaa1d08690e37e813b2281d5
-- 
2.39.5
Re: [PATCH mm-unstable] mm/damon/sysfs-schemes: make damos_sysfs_action_names static
Posted by SeongJae Park 3 months, 1 week ago
On Fri, 27 Jun 2025 09:28:06 -0700 SeongJae Park <sj@kernel.org> wrote:

> Commit 6812c66db976 ("mm/damon/sysfs-schemes: decouple from
> damos_action") in mm-unstable is defining damos_sysfs_action_names as
> non-static, though it is being used only inside sysfs-schemes.c file.
> Make it static.
> 
> Fixes: 6812c66db976 ("mm/damon/sysfs-schemes: decouple from damos_action") # mm-unstable
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506271655.b8yfEZIT-lkp@intel.com/
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>

I forgot noting this patch to the report, and Andrew thankfully made and merged
a fix[1] that is same to this one.  So this patch may be just ignored in favor
of the already merged same fix.  Noting it here just for a case of future
readers.

[1] https://lore.kernel.org/20250627125731.19f70c310cb4f315177e41e6@linux-foundation.org


Thanks,
SJ

[...]