From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

In the same spirit as e.g. Commit 6314184be391 ("arm64: dts: qcom:
sc8180x: Drop ipa-virt interconnect") drop the resources that should
be taken care of through the clk-rpmh driver.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/qcs615.dtsi | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
index bfbb210354922766a03fe05e6d117ea21d118081..b554471175de88fd96d12dd5183ee9bf61532bbf 100644
--- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
@@ -320,12 +320,6 @@ camnoc_virt: interconnect-0 {
 		qcom,bcm-voters = <&apps_bcm_voter>;
 	};
 
-	ipa_virt: interconnect-1 {
-		compatible = "qcom,qcs615-ipa-virt";
-		#interconnect-cells = <2>;
-		qcom,bcm-voters = <&apps_bcm_voter>;
-	};
-
 	mc_virt: interconnect-2 {
 		compatible = "qcom,qcs615-mc-virt";
 		#interconnect-cells = <2>;

-- 
2.50.0

On Fri, Jun 27, 2025 at 09:37:55PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> In the same spirit as e.g. Commit 6314184be391 ("arm64: dts: qcom:
> sc8180x: Drop ipa-virt interconnect") drop the resources that should
> be taken care of through the clk-rpmh driver.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs615.dtsi | 6 ------

This is non-bisectable and breaks the users. Should be the last patch,
not the first, with explicit notice that it must wait after the next
merge window.

Plus this affects all outside users, which also should be somehow
explained. "Spirit" of some other commit does not apply here. These are
different products, different users. It needs its own rationale and
justification.

Best regards,
Krzysztof

On 7/8/25 10:51 AM, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 09:37:55PM +0200, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> In the same spirit as e.g. Commit 6314184be391 ("arm64: dts: qcom:
>> sc8180x: Drop ipa-virt interconnect") drop the resources that should
>> be taken care of through the clk-rpmh driver.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs615.dtsi | 6 ------
> 
> This is non-bisectable and breaks the users.

Of which there are clearly none, as can be seen by the node not
being referenced by any other one. I can add that to the commit
message.

This is actually as bisectable as it gets, since it goes out of
the way to satisfy both compilation and dt-bindings checks

> Should be the last patch,> not the first, with explicit notice that it must wait after the next
> merge window.

Patches to all three subsystems can go in independently to their
respective trees (except maybe icc bindings going in before dts
could spawn a dt-checker warning)

> Plus this affects all outside users, which also should be somehow
> explained. "Spirit" of some other commit does not apply here. These are
> different products, different users. It needs its own rationale and
> justification.

Yes and no, you're focusing on me referencing a different commit
while I included the same rationale it presents later in the
sentence.

Konrad

On Fri, Jun 27, 2025 at 09:37:55PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> In the same spirit as e.g. Commit 6314184be391 ("arm64: dts: qcom:
> sc8180x: Drop ipa-virt interconnect") drop the resources that should
> be taken care of through the clk-rpmh driver.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs615.dtsi | 6 ------
>  1 file changed, 6 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry