Document the MPSS & WPSS remoteprocs on the SM7635 Platform.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 .../bindings/remoteproc/qcom,sm8350-pas.yaml          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
index 6d09823153fc8331f04d4657d9acba718533cce6..9ffddafea33739d325fd4c469642bff461a933b8 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
@@ -18,6 +18,8 @@ properties:
     oneOf:
       - enum:
           - qcom,sar2130p-adsp-pas
+          - qcom,sm7635-mpss-pas
+          - qcom,sm7635-wpss-pas
           - qcom,sm8350-adsp-pas
           - qcom,sm8350-cdsp-pas
           - qcom,sm8350-slpi-pas
@@ -91,6 +93,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,sm7635-mpss-pas
             - qcom,sm8350-mpss-pas
             - qcom,sm8450-mpss-pas
     then:
@@ -142,6 +145,22 @@ allOf:
             - const: cx
             - const: mxc
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,sm7635-wpss-pas
+    then:
+      properties:
+        power-domains:
+          items:
+            - description: CX power domain
+            - description: MX power domain
+        power-domain-names:
+          items:
+            - const: cx
+            - const: mx
+
 unevaluatedProperties: false
 
 examples:

-- 
2.50.0

On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
> @@ -91,6 +93,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,sm7635-mpss-pas
>              - qcom,sm8350-mpss-pas
>              - qcom,sm8450-mpss-pas
>      then:
> @@ -142,6 +145,22 @@ allOf:
>              - const: cx
>              - const: mxc
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,sm7635-wpss-pas

Everything fits better sm6350 and no need for new if:then: entry, at
least it looks like.

Best regards,
Krzysztof

Hi Krzysztof,

On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
>> @@ -91,6 +93,7 @@ allOf:
>>        properties:
>>          compatible:
>>            enum:
>> +            - qcom,sm7635-mpss-pas
>>              - qcom,sm8350-mpss-pas
>>              - qcom,sm8450-mpss-pas
>>      then:
>> @@ -142,6 +145,22 @@ allOf:
>>              - const: cx
>>              - const: mxc
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,sm7635-wpss-pas
>
> Everything fits better sm6350 and no need for new if:then: entry, at
> least it looks like.

True, that seems to work fine as well. I can add it to the
qcom,sm6350-pas.yaml bindings instead of sm8350 in the next version.

To be honest, I don't quite understand what the concept behind the
different PAS bindings are, when an SoC should get a new .yaml file, and
when to add to an existing one.

Regards
Luca

>
> Best regards,
> Krzysztof

On 01/07/2025 12:12, Luca Weiss wrote:
> Hi Krzysztof,
> 
> On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote:
>> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
>>> @@ -91,6 +93,7 @@ allOf:
>>>        properties:
>>>          compatible:
>>>            enum:
>>> +            - qcom,sm7635-mpss-pas
>>>              - qcom,sm8350-mpss-pas
>>>              - qcom,sm8450-mpss-pas
>>>      then:
>>> @@ -142,6 +145,22 @@ allOf:
>>>              - const: cx
>>>              - const: mxc
>>>  
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          enum:
>>> +            - qcom,sm7635-wpss-pas
>>
>> Everything fits better sm6350 and no need for new if:then: entry, at
>> least it looks like.
> 
> True, that seems to work fine as well. I can add it to the
> qcom,sm6350-pas.yaml bindings instead of sm8350 in the next version.
> 
> To be honest, I don't quite understand what the concept behind the
> different PAS bindings are, when an SoC should get a new .yaml file, and
> when to add to an existing one.

It is purely arbitrary way of organizing things, to reduce amount of
ifs:then: and make things easier to read. Adding ifs: does not make it
simple. Adding same SoC to multiple bindings does not make it simple.

Best regards,
Krzysztof