On 6/27/25 05:08, Théo Lebrun wrote:
> Remove NULL checks on macb_config as it is always valid:
> - either it is its default value &default_gem_config,
> - or it got overridden using match data.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 6c8a34e40b77ea37ed25c2b0414440cd3f6962c3..6926ea11d71adae7a25d5ee329c148f5882d4184 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -5227,15 +5227,13 @@ static int macb_probe(struct platform_device *pdev)
> }
> bp->num_queues = num_queues;
> bp->queue_mask = queue_mask;
> - if (macb_config)
> - bp->dma_burst_length = macb_config->dma_burst_length;
> + bp->dma_burst_length = macb_config->dma_burst_length;
> bp->pclk = pclk;
> bp->hclk = hclk;
> bp->tx_clk = tx_clk;
> bp->rx_clk = rx_clk;
> bp->tsu_clk = tsu_clk;
> - if (macb_config)
> - bp->jumbo_max_len = macb_config->jumbo_max_len;
> + bp->jumbo_max_len = macb_config->jumbo_max_len;
>
> if (!hw_is_gem(bp->regs, bp->native_io))
> bp->max_tx_length = MACB_MAX_TX_LEN;
>
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>