[PATCH v2 05/11] iio: adc: ad_sigma_delta: audit included headers

David Lechner posted 11 patches 7 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 05/11] iio: adc: ad_sigma_delta: audit included headers
Posted by David Lechner 7 months, 2 weeks ago
Drop linux/iio/sysfs.h since it is unused and replace linux/kernel.h
with more explicit headers. There are a couple of other headers added
weren't covered by kernel.h, like linux/gpio/consumer.h that are added
since the module makes used of those APIs as well.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/iio/adc/ad_sigma_delta.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index 64ed8aeb71f7c6ca19fff0438fa5ccce0c1d8f8f..ab34ff5e09146535fd6edbd288888c3afb0188a7 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -7,21 +7,28 @@
  */
 
 #include <linux/align.h>
+#include <linux/bitmap.h>
 #include <linux/bitops.h>
+#include <linux/cleanup.h>
+#include <linux/completion.h>
 #include <linux/device.h>
 #include <linux/err.h>
+#include <linux/export.h>
+#include <linux/find.h>
+#include <linux/gpio/consumer.h>
 #include <linux/interrupt.h>
-#include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/property.h>
 #include <linux/slab.h>
 #include <linux/spi/spi.h>
+#include <linux/spinlock.h>
+#include <linux/string.h>
 #include <linux/types.h>
 #include <linux/unaligned.h>
 
 #include <linux/iio/adc/ad_sigma_delta.h>
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
 #include <linux/iio/trigger_consumer.h>
 #include <linux/iio/trigger.h>
 #include <linux/iio/triggered_buffer.h>

-- 
2.43.0
Re: [PATCH v2 05/11] iio: adc: ad_sigma_delta: audit included headers
Posted by Andy Shevchenko 7 months, 2 weeks ago
On Fri, Jun 27, 2025 at 06:40:01PM -0500, David Lechner wrote:
> Drop linux/iio/sysfs.h since it is unused and replace linux/kernel.h
> with more explicit headers. There are a couple of other headers added
> weren't covered by kernel.h, like linux/gpio/consumer.h that are added
> since the module makes used of those APIs as well.

s/used/use/

> Signed-off-by: David Lechner <dlechner@baylibre.com>

...

>  #include <linux/align.h>
> +#include <linux/bitmap.h>
>  #include <linux/bitops.h>

bitops.h is implied by bitmap.h, but I'm fine with this being left untouched.

> +#include <linux/cleanup.h>
> +#include <linux/completion.h>
>  #include <linux/device.h>
>  #include <linux/err.h>
> +#include <linux/export.h>
> +#include <linux/find.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/interrupt.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
> +#include <linux/property.h>
>  #include <linux/slab.h>
>  #include <linux/spi/spi.h>
> +#include <linux/spinlock.h>
> +#include <linux/string.h>
>  #include <linux/types.h>
>  #include <linux/unaligned.h>

-- 
With Best Regards,
Andy Shevchenko