Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware:
- May optionally require an IOMMU to initialize a display region.
- May require a port connection to another block, say an MIC or a DSI
master.
Document these bindings in the devicetree schema.
Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
.../bindings/display/samsung/samsung,exynos7-decon.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
index 53916e4c95d8c0369138941a556c23f5d42fbd39..1e9500c86590d555cfa6f04790e2b64da291b78b 100644
--- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
+++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
@@ -80,6 +80,14 @@ properties:
- const: vsync
- const: lcd_sys
+ iommus:
+ maxItems: 1
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description:
+ Contains a port which is connected to mic or dsim node.
+
power-domains:
maxItems: 1
--
2.49.0On 26/06/2025 21:20, Kaustabh Chakraborty wrote: > @@ -80,6 +80,14 @@ properties: > - const: vsync > - const: lcd_sys > > + iommus: > + maxItems: 1 > + > + ports: This was supposed to be port, no? > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + Contains a port which is connected to mic or dsim node. If you are using ports, then you need to list the ports. Best regards, Krzysztof
On 2025-07-06 07:33, Krzysztof Kozlowski wrote: > On 26/06/2025 21:20, Kaustabh Chakraborty wrote: >> @@ -80,6 +80,14 @@ properties: >> - const: vsync >> - const: lcd_sys >> >> + iommus: >> + maxItems: 1 >> + >> + ports: > > This was supposed to be port, no? Yes. You have reviewed this patch though, I didn't send a new rev yet. Either way, yes this should be port (since it has a single output port). > >> + $ref: /schemas/graph.yaml#/properties/ports >> + description: >> + Contains a port which is connected to mic or dsim node. > If you are using ports, then you need to list the ports. > > Best regards, > Krzysztof
On 06/07/2025 18:00, Kaustabh Chakraborty wrote: > On 2025-07-06 07:33, Krzysztof Kozlowski wrote: >> On 26/06/2025 21:20, Kaustabh Chakraborty wrote: >>> @@ -80,6 +80,14 @@ properties: >>> - const: vsync >>> - const: lcd_sys >>> >>> + iommus: >>> + maxItems: 1 >>> + >>> + ports: >> >> This was supposed to be port, no? > > Yes. You have reviewed this patch though, I didn't send a new rev > yet. > > Either way, yes this should be port (since it has a single output > port). Ah, indeed, this popped up in my inbox and I totally missed that I already responded. Best regards, Krzysztof
On Fri, Jun 27, 2025 at 12:50:28AM +0530, Kaustabh Chakraborty wrote: > Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware: > - May optionally require an IOMMU to initialize a display region. > - May require a port connection to another block, say an MIC or a DSI > master. > > Document these bindings in the devicetree schema. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > --- > .../bindings/display/samsung/samsung,exynos7-decon.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > index 53916e4c95d8c0369138941a556c23f5d42fbd39..1e9500c86590d555cfa6f04790e2b64da291b78b 100644 > --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > @@ -80,6 +80,14 @@ properties: > - const: vsync > - const: lcd_sys > > + iommus: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + Contains a port which is connected to mic or dsim node. You need to list and describe the ports. Best regards, Krzysztof
On 2025-06-27 07:50, Krzysztof Kozlowski wrote: > On Fri, Jun 27, 2025 at 12:50:28AM +0530, Kaustabh Chakraborty wrote: >> Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware: >> - May optionally require an IOMMU to initialize a display region. >> - May require a port connection to another block, say an MIC or a DSI >> master. >> >> Document these bindings in the devicetree schema. >> >> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >> --- >> .../bindings/display/samsung/samsung,exynos7-decon.yaml | 8 >> ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >> index >> 53916e4c95d8c0369138941a556c23f5d42fbd39..1e9500c86590d555cfa6f04790e2b64da291b78b >> 100644 >> --- >> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >> +++ >> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >> @@ -80,6 +80,14 @@ properties: >> - const: vsync >> - const: lcd_sys >> >> + iommus: >> + maxItems: 1 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + description: >> + Contains a port which is connected to mic or dsim node. > > You need to list and describe the ports. - description: - Contains a port which is connected to mic or dsim node. + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: + Input port which is connected to either a Mobile Image + Compressor (MIC) or a DSI Master device. I assume you want something like this? Is the formatting correct? Should there be a space between ports:$ref and ports:properties? > > Best regards, > Krzysztof
On 27/06/2025 15:44, Kaustabh Chakraborty wrote: >>> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >>> +++ >>> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >>> @@ -80,6 +80,14 @@ properties: >>> - const: vsync >>> - const: lcd_sys >>> >>> + iommus: >>> + maxItems: 1 >>> + >>> + ports: >>> + $ref: /schemas/graph.yaml#/properties/ports >>> + description: >>> + Contains a port which is connected to mic or dsim node. >> >> You need to list and describe the ports. > > - description: > - Contains a port which is connected to mic or dsim node. > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port which is connected to either a Mobile Image > + Compressor (MIC) or a DSI Master device. If this is only one port, then just 'port' property, but I have doubts it should be one, because even you mentioned two - MIC could be the input and MIPI DSIM would be the output. Maybe if the MIC is integral part, it would not have been an input, but then only 'port'. > > I assume you want something like this? > Is the formatting correct? Should there be a space between > ports:$ref and ports:properties? Look at toshiba,tc358768.yaml or the simple-bridge (except you should name the input and output ports). Best regards, Krzysztof
On 2025-06-27 14:44, Krzysztof Kozlowski wrote: > On 27/06/2025 15:44, Kaustabh Chakraborty wrote: >>>> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >>>> +++ >>>> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >>>> @@ -80,6 +80,14 @@ properties: >>>> - const: vsync >>>> - const: lcd_sys >>>> >>>> + iommus: >>>> + maxItems: 1 >>>> + >>>> + ports: >>>> + $ref: /schemas/graph.yaml#/properties/ports >>>> + description: >>>> + Contains a port which is connected to mic or dsim node. >>> >>> You need to list and describe the ports. >> >> - description: >> - Contains a port which is connected to mic or dsim node. >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: >> + Input port which is connected to either a Mobile Image >> + Compressor (MIC) or a DSI Master device. > > > If this is only one port, then just 'port' property, but I have doubts > it should be one, because even you mentioned two - MIC could be the > input and MIPI DSIM would be the output. DECON is the first device in the pipeline. So it should only have output. It's either: DECON -> DSIM -> panel or DECON -> MIC -> DSIM -> panel Exynos7870 doesn't have MIC, but other SoCs may have one. > > Maybe if the MIC is integral part, it would not have been an input, but > then only 'port'. > >> >> I assume you want something like this? >> Is the formatting correct? Should there be a space between >> ports:$ref and ports:properties? > > Look at toshiba,tc358768.yaml or the simple-bridge (except you should > name the input and output ports). Okay, thanks! Therefore this: - description: - Contains a port which is connected to mic or dsim node. + + properties: + port: + $ref: /schemas/graph.yaml#/properties/port + description: + Output port which is connected to either a Mobile Image + Compressor (MIC) or a DSI Master device. > > > > Best regards, > Krzysztof
On 27/06/2025 17:03, Kaustabh Chakraborty wrote: > On 2025-06-27 14:44, Krzysztof Kozlowski wrote: >> On 27/06/2025 15:44, Kaustabh Chakraborty wrote: >>>>> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >>>>> +++ >>>>> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml >>>>> @@ -80,6 +80,14 @@ properties: >>>>> - const: vsync >>>>> - const: lcd_sys >>>>> >>>>> + iommus: >>>>> + maxItems: 1 >>>>> + >>>>> + ports: >>>>> + $ref: /schemas/graph.yaml#/properties/ports >>>>> + description: >>>>> + Contains a port which is connected to mic or dsim node. >>>> >>>> You need to list and describe the ports. >>> >>> - description: >>> - Contains a port which is connected to mic or dsim node. >>> + properties: >>> + port@0: >>> + $ref: /schemas/graph.yaml#/properties/port >>> + description: >>> + Input port which is connected to either a Mobile Image >>> + Compressor (MIC) or a DSI Master device. >> >> >> If this is only one port, then just 'port' property, but I have doubts >> it should be one, because even you mentioned two - MIC could be the >> input and MIPI DSIM would be the output. > > DECON is the first device in the pipeline. So it should only have > output. > > It's either: > DECON -> DSIM -> panel > or > DECON -> MIC -> DSIM -> panel > > Exynos7870 doesn't have MIC, but other SoCs may have one. Could be without ports entirely, but it is also fine to list port under. > >> >> Maybe if the MIC is integral part, it would not have been an input, but >> then only 'port'. >> >>> >>> I assume you want something like this? >>> Is the formatting correct? Should there be a space between >>> ports:$ref and ports:properties? >> >> Look at toshiba,tc358768.yaml or the simple-bridge (except you should >> name the input and output ports). > > Okay, thanks! > > Therefore this: > > - description: > - Contains a port which is connected to mic or dsim node. > + > + properties: > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port which is connected to either a Mobile Image > + Compressor (MIC) or a DSI Master device. and additionalProperties: false in ports level. Best regards, Krzysztof
2025년 6월 27일 (금) 오전 4:21, Kaustabh Chakraborty <kauschluss@disroot.org>님이 작성: > > Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware: > - May optionally require an IOMMU to initialize a display region. > - May require a port connection to another block, say an MIC or a DSI > master. > > Document these bindings in the devicetree schema. Applied. Thanks, Inki Dae > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > --- > .../bindings/display/samsung/samsung,exynos7-decon.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > index 53916e4c95d8c0369138941a556c23f5d42fbd39..1e9500c86590d555cfa6f04790e2b64da291b78b 100644 > --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > @@ -80,6 +80,14 @@ properties: > - const: vsync > - const: lcd_sys > > + iommus: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + Contains a port which is connected to mic or dsim node. > + > power-domains: > maxItems: 1 > > > -- > 2.49.0 > >
On Fri, Jun 27, 2025 at 02:02:37PM +0900, Inki Dae wrote: > 2025년 6월 27일 (금) 오전 4:21, Kaustabh Chakraborty <kauschluss@disroot.org>님이 작성: > > > > Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware: > > - May optionally require an IOMMU to initialize a display region. > > - May require a port connection to another block, say an MIC or a DSI > > master. > > > > Document these bindings in the devicetree schema. > > Applied. Please wait for DT review, giving us few hours is not enough. Please drop the patchset, needs fixes. Best regards, Krzysztof
2025년 6월 27일 (금) 오후 4:51, Krzysztof Kozlowski <krzk@kernel.org>님이 작성: > > On Fri, Jun 27, 2025 at 02:02:37PM +0900, Inki Dae wrote: > > 2025년 6월 27일 (금) 오전 4:21, Kaustabh Chakraborty <kauschluss@disroot.org>님이 작성: > > > > > > Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware: > > > - May optionally require an IOMMU to initialize a display region. > > > - May require a port connection to another block, say an MIC or a DSI > > > master. > > > > > > Document these bindings in the devicetree schema. > > > > Applied. > > Please wait for DT review, giving us few hours is not enough. Please > drop the patchset, needs fixes. Got it. Reverted. Thanks, Inki Dae > > Best regards, > Krzysztof >
© 2016 - 2025 Red Hat, Inc.