Add Exynos7870's PMU compatible to the list of nodes which allow a MIPI
PHY driver.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -172,6 +172,7 @@ allOf:
               - samsung,exynos5250-pmu
               - samsung,exynos5420-pmu
               - samsung,exynos5433-pmu
+              - samsung,exynos7870-pmu
     then:
       properties:
         mipi-phy: true

-- 
2.49.0

On Fri, Jun 27, 2025 at 01:43:25AM +0530, Kaustabh Chakraborty wrote:
> Add Exynos7870's PMU compatible to the list of nodes which allow a MIPI
> PHY driver.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> index f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> @@ -172,6 +172,7 @@ allOf:
>                - samsung,exynos5250-pmu
>                - samsung,exynos5420-pmu
>                - samsung,exynos5433-pmu
> +              - samsung,exynos7870-pmu

Don't you need to add this to 'compatible' and under 'select'?

>      then:
>        properties:
>          mipi-phy: true
> 
> -- 
> 2.49.0
>

On 2025-06-27 21:42, Rob Herring wrote:
> On Fri, Jun 27, 2025 at 01:43:25AM +0530, Kaustabh Chakraborty wrote:
>> Add Exynos7870's PMU compatible to the list of nodes which allow a 
>> MIPI
>> PHY driver.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml 
>> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> index 
>> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 
>> 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> @@ -172,6 +172,7 @@ allOf:
>>                - samsung,exynos5250-pmu
>>                - samsung,exynos5420-pmu
>>                - samsung,exynos5433-pmu
>> +              - samsung,exynos7870-pmu
> 
> Don't you need to add this to 'compatible' and under 'select'?

compatible: [1]

samsung,exynos7-pmu is under select. 7870 has a fallback on 7.
Do you think samsung,exynos7-pmu should've been added in this patch
instead?

[1] 
https://elixir.bootlin.com/linux/v6.16-rc3/source/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml#L56

> 
>>      then:
>>        properties:
>>          mipi-phy: true
>> 
>> --
>> 2.49.0
>>

On 28/06/2025 09:19, Kaustabh Chakraborty wrote:
>>> diff --git 
>>> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml 
>>> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> index 
>>> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 
>>> 100644
>>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> @@ -172,6 +172,7 @@ allOf:
>>>                - samsung,exynos5250-pmu
>>>                - samsung,exynos5420-pmu
>>>                - samsung,exynos5433-pmu
>>> +              - samsung,exynos7870-pmu
>>
>> Don't you need to add this to 'compatible' and under 'select'?
> 
> compatible: [1]
> 
> samsung,exynos7-pmu is under select. 7870 has a fallback on 7.
> Do you think samsung,exynos7-pmu should've been added in this patch
> instead?
> 
If this uses exynos7-pmu as fallback then it is fine. This should be in
commit msg - that's the point of commit msg - explain the hardware and
things not easily visible, instead of repeating what is visible in the diff.

Best regards,
Krzysztof