[PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)

Kaustabh Chakraborty posted 6 patches 3 months, 1 week ago
There is a newer version of this series
.../bindings/soc/samsung/exynos-pmu.yaml           |  1 +
.../soc/samsung/samsung,exynos-sysreg.yaml         |  2 +
.../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 52 +++++++++----
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts    | 49 ++++++++----
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 51 ++++++++----
arch/arm64/boot/dts/exynos/exynos7870.dtsi         | 90 ++++++++++++++++++++++
6 files changed, 206 insertions(+), 39 deletions(-)
[PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
Posted by Kaustabh Chakraborty 3 months, 1 week ago
Exynos7870 has a IP subsystem in its architecture dedicated to display
management. Notably, this block includes the Display Enhancement
Controller (DECON), and the DSI Master (DSIM).

The following series and its sub-series implement all components for a
functioning display pipeline. All vital information which helped shaping
up the patches have been retrieved from Exynos7870 vendor kernel sources
as provided by Samsung.

Testing has been done on all three devices available upstream, i.e.
Samsung Galaxy J7 Prime (samsung-on7xelte), Samsung Galaxy A2 Core
(samsung-a2corelte), and Samsung Galaxy J6 (samsung-j6lte). Regrettably,
I've only been able to test the functionality on video mode, as none of
the devices have panels working in command mode.

This series implements changes in the SoC subsystem, which includes
devicetree additions. It depends on all sub-series listed below:
(Legend: [R]eviewed, [A]ccepted)

exynosdrm-decon            - https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
exynos7870-mipi-phy        A https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
exynos7870-mipi-phy-fix    - https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
exynos7870-dsim            - https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
panel-synaptics-tddi       - https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
Changes in v2:
- modified compatible hierarchy to use non-deprecated syntax (krzk)
- fixed subject prefixes of [v1 2/5], [v1 3/5], [v1 4/5], [v1 5/5] (krzk)
- removed simplefb nodes instead of disabling it (krzk)
- added dt-bindings patch to allow mipi-phy node under PMU
- changed clock names of dsim node
- Link to v1: https://lore.kernel.org/r/20250612-exynos7870-drm-dts-v1-0-88c0779af6cb@disroot.org

---
Kaustabh Chakraborty (6):
      dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
      dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
      arm64: dts: exynos7870: add DSI support
      arm64: dts: exynos7870-on7xelte: enable display panel support
      arm64: dts: exynos7870-a2corelte: enable display panel support
      arm64: dts: exynos7870-j6lte: enable display panel support

 .../bindings/soc/samsung/exynos-pmu.yaml           |  1 +
 .../soc/samsung/samsung,exynos-sysreg.yaml         |  2 +
 .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 52 +++++++++----
 arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts    | 49 ++++++++----
 arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 51 ++++++++----
 arch/arm64/boot/dts/exynos/exynos7870.dtsi         | 90 ++++++++++++++++++++++
 6 files changed, 206 insertions(+), 39 deletions(-)
---
base-commit: 1b152eeca84a02bdb648f16b82ef3394007a9dcf
change-id: 20250523-exynos7870-drm-dts-87ccab731ba9

Best regards,
-- 
Kaustabh Chakraborty <kauschluss@disroot.org>
Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago
On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
> This series implements changes in the SoC subsystem, which includes
> devicetree additions. It depends on all sub-series listed below:
> (Legend: [R]eviewed, [A]ccepted)
> 
> exynosdrm-decon            - https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
> exynos7870-mipi-phy        A https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
> exynos7870-mipi-phy-fix    - https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
> exynos7870-dsim            - https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
> panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
> panel-synaptics-tddi       - https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>

What is the status of the bindings from dependencies? I think they were
not accepted.

I also replied with few nits for one of DTS patches. Everything else
looks fine.

BTW, really great job you did here, I am impressed!

Best regards,
Krzysztof
Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
Posted by Kaustabh Chakraborty 1 month, 3 weeks ago
On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>> This series implements changes in the SoC subsystem, which includes
>> devicetree additions. It depends on all sub-series listed below:
>> (Legend: [R]eviewed, [A]ccepted)
>> 
>> exynosdrm-decon            - 
>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>> exynos7870-mipi-phy        A 
>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>> exynos7870-mipi-phy-fix    - 
>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>> exynos7870-dsim            - 
>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>> panel-samsung-s6e8aa5x01   - 
>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>> panel-synaptics-tddi       - 
>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> 
> What is the status of the bindings from dependencies? I think they were
> not accepted.

Except panel-synaptics-tddi, all have been accepted. A lot of them
haven't hit next though. I'm waiting for that to send the next revision.
This rev is pretty old, so the links are old revs too.

There's also another related patch, on the IOMMU driver, which has also
been accepted. I will also add it to the list.

> 
> I also replied with few nits for one of DTS patches. Everything else
> looks fine.
> 
> BTW, really great job you did here, I am impressed!

Thank you! This was quite a ride to work on it and upstream these
patches. Thanks again to you and other kernel maintainers for all the
reviews.

> 
> Best regards,
> Krzysztof
Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago
On 17/08/2025 16:49, Kaustabh Chakraborty wrote:
> On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
>> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>>> This series implements changes in the SoC subsystem, which includes
>>> devicetree additions. It depends on all sub-series listed below:
>>> (Legend: [R]eviewed, [A]ccepted)
>>>
>>> exynosdrm-decon            - 
>>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>>> exynos7870-mipi-phy        A 
>>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>>> exynos7870-mipi-phy-fix    - 
>>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>>> exynos7870-dsim            - 
>>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>>> panel-samsung-s6e8aa5x01   - 
>>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>>> panel-synaptics-tddi       - 
>>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>>>
>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>
>> What is the status of the bindings from dependencies? I think they were
>> not accepted.
> 
> Except panel-synaptics-tddi, all have been accepted. A lot of them
> haven't hit next though. I'm waiting for that to send the next revision.

What does it mean - accepted but not hit next? If it is accepted, it
must be visible in next. Which maintainer's tree are not in the next?


Best regards,
Krzysztof
Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
Posted by Kaustabh Chakraborty 1 month, 2 weeks ago
On 2025-08-18 06:32, Krzysztof Kozlowski wrote:
> On 17/08/2025 16:49, Kaustabh Chakraborty wrote:
>> On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
>>> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>>>> This series implements changes in the SoC subsystem, which includes
>>>> devicetree additions. It depends on all sub-series listed below:
>>>> (Legend: [R]eviewed, [A]ccepted)
>>>> 
>>>> exynosdrm-decon            -
>>>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>>>> exynos7870-mipi-phy        A
>>>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>>>> exynos7870-mipi-phy-fix    -
>>>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>>>> exynos7870-dsim            -
>>>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>>>> panel-samsung-s6e8aa5x01   -
>>>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>>>> panel-synaptics-tddi       -
>>>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>>>> 
>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>> 
>>> What is the status of the bindings from dependencies? I think they 
>>> were
>>> not accepted.
>> 
>> Except panel-synaptics-tddi, all have been accepted. A lot of them
>> haven't hit next though. I'm waiting for that to send the next 
>> revision.
> 
> What does it mean - accepted but not hit next? If it is accepted, it
> must be visible in next. Which maintainer's tree are not in the next?

drm-exynos [1] branches haven't been rebased to v6.17-rc1. This should
include all some DECON and all DSIM patches.

Although [2] has been accepted, I don't see the commit in [3] anymore.
But, there's [4] which mentions my panel patches, but then I don't see
them in next (there should be a panel-samsung-s6e8aa5x01-ams561ra01.c
in [5]).

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/
[2] 
https://lore.kernel.org/all/175432157792.3671011.1104200917154441096.b4-ty@linaro.org
[3] 
https://gitlab.freedesktop.org/drm/misc/kernel/-/commits/drm-misc-next?ref_type=heads
[4] https://lore.kernel.org/all/20250814072454.GA18104@linux.fritz.box
[5] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/panel?h=next-20250818

> 
> 
> Best regards,
> Krzysztof
Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 18/08/2025 19:08, Kaustabh Chakraborty wrote:
> On 2025-08-18 06:32, Krzysztof Kozlowski wrote:
>> On 17/08/2025 16:49, Kaustabh Chakraborty wrote:
>>> On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
>>>> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>>>>> This series implements changes in the SoC subsystem, which includes
>>>>> devicetree additions. It depends on all sub-series listed below:
>>>>> (Legend: [R]eviewed, [A]ccepted)
>>>>>
>>>>> exynosdrm-decon            -
>>>>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>>>>> exynos7870-mipi-phy        A
>>>>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>>>>> exynos7870-mipi-phy-fix    -
>>>>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>>>>> exynos7870-dsim            -
>>>>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>>>>> panel-samsung-s6e8aa5x01   -
>>>>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>>>>> panel-synaptics-tddi       -
>>>>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>>>>>
>>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>>>
>>>> What is the status of the bindings from dependencies? I think they 
>>>> were
>>>> not accepted.
>>>
>>> Except panel-synaptics-tddi, all have been accepted. A lot of them
>>> haven't hit next though. I'm waiting for that to send the next 
>>> revision.
>>
>> What does it mean - accepted but not hit next? If it is accepted, it
>> must be visible in next. Which maintainer's tree are not in the next?
> 
> drm-exynos [1] branches haven't been rebased to v6.17-rc1. This should
> include all some DECON and all DSIM patches.
> 
> Although [2] has been accepted, I don't see the commit in [3] anymore.

I don't understand this. How can you find a commit via web interface?
You should be having linux-next and there you can go through the history
to check if commit is there or not.

> But, there's [4] which mentions my panel patches, but then I don't see
> them in next (there should be a panel-samsung-s6e8aa5x01-ams561ra01.c
> in [5]).

so that's the problem to solve.

I'll drop the patchset from my queue. I think you got here some other
comments as well, so I will be expecting v3 anyway.


Best regards,
Krzysztof
Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
Posted by Rob Herring (Arm) 3 months, 1 week ago
On Fri, 27 Jun 2025 01:43:23 +0530, Kaustabh Chakraborty wrote:
> Exynos7870 has a IP subsystem in its architecture dedicated to display
> management. Notably, this block includes the Display Enhancement
> Controller (DECON), and the DSI Master (DSIM).
> 
> The following series and its sub-series implement all components for a
> functioning display pipeline. All vital information which helped shaping
> up the patches have been retrieved from Exynos7870 vendor kernel sources
> as provided by Samsung.
> 
> Testing has been done on all three devices available upstream, i.e.
> Samsung Galaxy J7 Prime (samsung-on7xelte), Samsung Galaxy A2 Core
> (samsung-a2corelte), and Samsung Galaxy J6 (samsung-j6lte). Regrettably,
> I've only been able to test the functionality on video mode, as none of
> the devices have panels working in command mode.
> 
> This series implements changes in the SoC subsystem, which includes
> devicetree additions. It depends on all sub-series listed below:
> (Legend: [R]eviewed, [A]ccepted)
> 
> exynosdrm-decon            - https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
> exynos7870-mipi-phy        A https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
> exynos7870-mipi-phy-fix    - https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
> exynos7870-dsim            - https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
> panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
> panel-synaptics-tddi       - https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
> Changes in v2:
> - modified compatible hierarchy to use non-deprecated syntax (krzk)
> - fixed subject prefixes of [v1 2/5], [v1 3/5], [v1 4/5], [v1 5/5] (krzk)
> - removed simplefb nodes instead of disabling it (krzk)
> - added dt-bindings patch to allow mipi-phy node under PMU
> - changed clock names of dsim node
> - Link to v1: https://lore.kernel.org/r/20250612-exynos7870-drm-dts-v1-0-88c0779af6cb@disroot.org
> 
> ---
> Kaustabh Chakraborty (6):
>       dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
>       dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
>       arm64: dts: exynos7870: add DSI support
>       arm64: dts: exynos7870-on7xelte: enable display panel support
>       arm64: dts: exynos7870-a2corelte: enable display panel support
>       arm64: dts: exynos7870-j6lte: enable display panel support
> 
>  .../bindings/soc/samsung/exynos-pmu.yaml           |  1 +
>  .../soc/samsung/samsung,exynos-sysreg.yaml         |  2 +
>  .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 52 +++++++++----
>  arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts    | 49 ++++++++----
>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 51 ++++++++----
>  arch/arm64/boot/dts/exynos/exynos7870.dtsi         | 90 ++++++++++++++++++++++
>  6 files changed, 206 insertions(+), 39 deletions(-)
> ---
> base-commit: 1b152eeca84a02bdb648f16b82ef3394007a9dcf
> change-id: 20250523-exynos7870-drm-dts-87ccab731ba9
> 
> Best regards,
> --
> Kaustabh Chakraborty <kauschluss@disroot.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 1b152eeca84a02bdb648f16b82ef3394007a9dcf

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250627-exynos7870-drm-dts-v2-0-d4a59207390d@disroot.org:

arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['syna,td4300-panel']
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['syna,td4101-panel']
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['samsung,s6e8aa5x01']
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#