[PATCH v1 2/2] firmware: sysfb: Don't use "proxy" headers

Andy Shevchenko posted 2 patches 3 months, 1 week ago
[PATCH v1 2/2] firmware: sysfb: Don't use "proxy" headers
Posted by Andy Shevchenko 3 months, 1 week ago
Update header inclusions to follow IWYU (Include What You Use)
principle.

Note that kernel.h is discouraged to be included as it's written
at the top of that file.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/sysfb.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/linux/sysfb.h b/include/linux/sysfb.h
index 07cbab516942..b449665c686a 100644
--- a/include/linux/sysfb.h
+++ b/include/linux/sysfb.h
@@ -7,9 +7,13 @@
  * Copyright (c) 2012-2013 David Herrmann <dh.herrmann@gmail.com>
  */
 
-#include <linux/kernel.h>
+#include <linux/err.h>
+#include <linux/types.h>
+
 #include <linux/platform_data/simplefb.h>
 
+struct device;
+struct platform_device;
 struct screen_info;
 
 enum {
-- 
2.47.2
Re: [PATCH v1 2/2] firmware: sysfb: Don't use "proxy" headers
Posted by Javier Martinez Canillas 3 months, 1 week ago
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Re: [PATCH v1 2/2] firmware: sysfb: Don't use "proxy" headers
Posted by Andy Shevchenko 3 months, 1 week ago
On Fri, Jun 27, 2025 at 10:51:07AM +0200, Javier Martinez Canillas wrote:
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Thank you for the review!

I just sent a v2 without first patch.

-- 
With Best Regards,
Andy Shevchenko