[v1] net: phy: bcm54811: Fix the PHY initialization

[PATCH 2/3] dt-bindings: ethernet-phy: add MII-Lite phy interface type

Posted by Kamil Horák - 2N 3 months, 2 weeks ago

Some Broadcom PHYs are capable to operate in simplified MII mode,
without TXER, RXER, CRS and COL signals as defined for the MII.
The MII-Lite mode can be used on most Ethernet controllers with full
MII interface by just leaving the input signals (RXER, CRS, COL)
inactive. The absence of COL signal makes half-duplex link modes
impossible but does not interfere with BroadR-Reach link modes on
Broadcom PHYs, because they are all full-duplex only.

Add new interface type "mii-lite" to phy-connection-type enum.

Fixes: 03ab6c244bb0 ("net: phy: bcm-phy-lib: Implement BroadR-Reach link modes")
Signed-off-by: Kamil Horák - 2N <kamilh@axis.com>
---
 Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index 7cbf11bbe99c..66b1cfbbfe22 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -39,6 +39,7 @@ properties:
       # MAC.
       - internal
       - mii
+      - mii-lite
       - gmii
       - sgmii
       - psgmii
--
2.39.5

Re: [PATCH 2/3] dt-bindings: ethernet-phy: add MII-Lite phy interface type

Posted by Krzysztof Kozlowski 3 months, 2 weeks ago

On 26/06/2025 13:56, Kamil Horák - 2N wrote:
> Some Broadcom PHYs are capable to operate in simplified MII mode,
> without TXER, RXER, CRS and COL signals as defined for the MII.
> The MII-Lite mode can be used on most Ethernet controllers with full
> MII interface by just leaving the input signals (RXER, CRS, COL)
> inactive. The absence of COL signal makes half-duplex link modes
> impossible but does not interfere with BroadR-Reach link modes on
> Broadcom PHYs, because they are all full-duplex only.
> 
> Add new interface type "mii-lite" to phy-connection-type enum.
> 
> Fixes: 03ab6c244bb0 ("net: phy: bcm-phy-lib: Implement BroadR-Reach link modes")
> Signed-off-by: Kamil Horák - 2N <kamilh@axis.com>
> ---
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +

You just sent v3 (double v3!) of this, no changelog, no explanations.

Please slow down and don't send the same triple time. Provide changelog,
as explained in submitting patches.

Best regards,
Krzysztof

[PATCH 1/3] net: phy: MII-Lite PHY interface mode
[PATCH 2/3] dt-bindings: ethernet-phy: add MII-Lite phy interface type
[PATCH 3/3] net: phy: bcm54811: Fix the PHY initialization