[PATCH] soundwire: stream: restore params when prepare ports fail

Bard Liao posted 1 patch 3 months, 2 weeks ago
drivers/soundwire/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] soundwire: stream: restore params when prepare ports fail
Posted by Bard Liao 3 months, 2 weeks ago
The bus->params should be restored if the stream is failed to prepare.
The issue exists since beginning. The Fixes tag just indicates the
first commit that the commit can be applied to.

Fixes: 17ed5bef49f4 ("soundwire: add missing newlines in dynamic debug logs")
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
 drivers/soundwire/stream.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index a4bea742b5d9..38c9dbd35606 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -1510,7 +1510,7 @@ static int _sdw_prepare_stream(struct sdw_stream_runtime *stream,
 		if (ret < 0) {
 			dev_err(bus->dev, "Prepare port(s) failed ret = %d\n",
 				ret);
-			return ret;
+			goto restore_params;
 		}
 	}
 
-- 
2.43.0

Re: [PATCH] soundwire: stream: restore params when prepare ports fail
Posted by Vinod Koul 2 months, 2 weeks ago
On Thu, 26 Jun 2025 14:09:52 +0800, Bard Liao wrote:
> The bus->params should be restored if the stream is failed to prepare.
> The issue exists since beginning. The Fixes tag just indicates the
> first commit that the commit can be applied to.
> 
> 

Applied, thanks!

[1/1] soundwire: stream: restore params when prepare ports fail
      commit: dba7d9dbfdc4389361ff3a910e767d3cfca22587

Best regards,
-- 
~Vinod