[PATCH net-next v2 9/9] net: skbuff: Drop unused @skb

Michal Luczaj posted 9 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH net-next v2 9/9] net: skbuff: Drop unused @skb
Posted by Michal Luczaj 3 months, 2 weeks ago
Since its introduction in commit 6fa01ccd8830 ("skbuff: Add pskb_extract()
helper function"), pskb_carve_frag_list() never used the argument @skb.
Drop it and adapt the only caller.

No functional change intended.

Signed-off-by: Michal Luczaj <mhal@rbox.co>
---
 net/core/skbuff.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index b5f685b6611c177c199f70bb16fd3940bce8cded..f8553c674fe5052e7c1ea53022e252a54a9d6c72 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -6756,8 +6756,7 @@ static int pskb_carve(struct sk_buff *skb, const u32 off, gfp_t gfp);
 /* carve out the first eat bytes from skb's frag_list. May recurse into
  * pskb_carve()
  */
-static int pskb_carve_frag_list(struct sk_buff *skb,
-				struct skb_shared_info *shinfo, int eat,
+static int pskb_carve_frag_list(struct skb_shared_info *shinfo, int eat,
 				gfp_t gfp_mask)
 {
 	struct sk_buff *list = shinfo->frag_list;
@@ -6862,7 +6861,7 @@ static int pskb_carve_inside_nonlinear(struct sk_buff *skb, const u32 off,
 		skb_clone_fraglist(skb);
 
 	/* split line is in frag list */
-	if (k == 0 && pskb_carve_frag_list(skb, shinfo, off - pos, gfp_mask)) {
+	if (k == 0 && pskb_carve_frag_list(shinfo, off - pos, gfp_mask)) {
 		/* skb_frag_unref() is not needed here as shinfo->nr_frags = 0. */
 		if (skb_has_frag_list(skb))
 			kfree_skb_list(skb_shinfo(skb)->frag_list);

-- 
2.49.0
Re: [PATCH net-next v2 9/9] net: skbuff: Drop unused @skb
Posted by Simon Horman 3 months, 2 weeks ago
On Thu, Jun 26, 2025 at 10:33:42AM +0200, Michal Luczaj wrote:
> Since its introduction in commit 6fa01ccd8830 ("skbuff: Add pskb_extract()
> helper function"), pskb_carve_frag_list() never used the argument @skb.
> Drop it and adapt the only caller.
> 
> No functional change intended.
> 
> Signed-off-by: Michal Luczaj <mhal@rbox.co>

Reviewed-by: Simon Horman <horms@kernel.org>