[PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add pm4125 audio codec

Alexey Klimov posted 3 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add pm4125 audio codec
Posted by Alexey Klimov 3 months, 2 weeks ago
PM4125 has audio codec hardware block. Add pattern for respecive node
so the devicetree for those blocks can be validated properly.

Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 078a6886f8b1e9ceb2187e988ce7c9514ff6dc2c..5718cfe7f4c2b696ee2700fafe8dc071c70a6476 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -137,7 +137,9 @@ patternProperties:
 
   "^audio-codec@[0-9a-f]+$":
     type: object
-    $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
+    oneOf:
+      - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
+      - $ref: /schemas/sound/qcom,pm4125-codec.yaml#
 
   "^battery@[0-9a-f]+$":
     type: object

-- 
2.47.2
Re: [PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add pm4125 audio codec
Posted by Krzysztof Kozlowski 3 months, 2 weeks ago
On 26/06/2025 01:50, Alexey Klimov wrote:
> PM4125 has audio codec hardware block. Add pattern for respecive node
> so the devicetree for those blocks can be validated properly.
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>

Remember to ALWAYS explain the dependencies between patches (merging
strategy), because this now creates impression is independent patch. It
is not and should be squashed into previous.

Best regards,
Krzysztof
Re: [PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add pm4125 audio codec
Posted by Alexey Klimov 3 months, 1 week ago
On Thu Jun 26, 2025 at 9:48 AM BST, Krzysztof Kozlowski wrote:
> On 26/06/2025 01:50, Alexey Klimov wrote:
>> PM4125 has audio codec hardware block. Add pattern for respecive node
>> so the devicetree for those blocks can be validated properly.
>> 
>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>
> Remember to ALWAYS explain the dependencies between patches (merging
> strategy), because this now creates impression is independent patch. It
> is not and should be squashed into previous.

What's the proper way to describe such dependency?

Best regards,
Alexey
Re: [PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add pm4125 audio codec
Posted by Krzysztof Kozlowski 3 months, 1 week ago
On 28/06/2025 18:42, Alexey Klimov wrote:
> On Thu Jun 26, 2025 at 9:48 AM BST, Krzysztof Kozlowski wrote:
>> On 26/06/2025 01:50, Alexey Klimov wrote:
>>> PM4125 has audio codec hardware block. Add pattern for respecive node
>>> so the devicetree for those blocks can be validated properly.
>>>
>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>>
>> Remember to ALWAYS explain the dependencies between patches (merging
>> strategy), because this now creates impression is independent patch. It
>> is not and should be squashed into previous.
> 
> What's the proper way to describe such dependency?

The best changelog. Acceptable is also cover letter, although some
people skip cover letters.

Best regards,
Krzysztof
Re: [PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add pm4125 audio codec
Posted by Dmitry Baryshkov 3 months, 1 week ago
On Sat, Jun 28, 2025 at 05:42:52PM +0100, Alexey Klimov wrote:
> On Thu Jun 26, 2025 at 9:48 AM BST, Krzysztof Kozlowski wrote:
> > On 26/06/2025 01:50, Alexey Klimov wrote:
> >> PM4125 has audio codec hardware block. Add pattern for respecive node
> >> so the devicetree for those blocks can be validated properly.
> >> 
> >> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> >
> > Remember to ALWAYS explain the dependencies between patches (merging
> > strategy), because this now creates impression is independent patch. It
> > is not and should be squashed into previous.
> 
> What's the proper way to describe such dependency?

Text in the cover letter.

-- 
With best wishes
Dmitry